New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 643404 link

Starred by 1 user
Status: Verified
Owner:
jianli@chromium.org
Closed: Sep 2016
Cc:
dewittj@chromium.org
█ dim...@chromium.org
fgor...@chromium.org
█ talo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Latest downloaded page is shown when opening an item that is downloaded earlier

Project Member Reported by jianli@chromium.org, Sep 1 2016 
Repro steps:
1. Download a web page multiple times. Make sure each time the web page is showing different content before it is downloaded.
2. Go to Download home and open a page that is downloaded earlier.

Observed behavior: 
The offline page with latest content is shown.

Expected behavior:
The offline page with the content corresponding to the clicked downloaded page should be shown.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d28e413d6a8607db4f82b5e2dc35c58bea543098

commit d28e413d6a8607db4f82b5e2dc35c58bea543098
Author: jianli <jianli@chromium.org>
Date: Mon Sep 12 22:58:25 2016

Support serving offline page by offline ID
BUG= 643404 
TEST=new tests added

Review-Url: https://codereview.chromium.org/2322833002
Cr-Commit-Position: refs/heads/master@{#418089}

[modify] https://crrev.com/d28e413d6a8607db4f82b5e2dc35c58bea543098/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
[modify] https://crrev.com/d28e413d6a8607db4f82b5e2dc35c58bea543098/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/d28e413d6a8607db4f82b5e2dc35c58bea543098/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h
[modify] https://crrev.com/d28e413d6a8607db4f82b5e2dc35c58bea543098/chrome/browser/android/offline_pages/offline_page_request_interceptor.cc
[modify] https://crrev.com/d28e413d6a8607db4f82b5e2dc35c58bea543098/chrome/browser/android/offline_pages/offline_page_request_interceptor.h
[modify] https://crrev.com/d28e413d6a8607db4f82b5e2dc35c58bea543098/chrome/browser/android/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/d28e413d6a8607db4f82b5e2dc35c58bea543098/chrome/browser/android/offline_pages/offline_page_request_job.h
[modify] https://crrev.com/d28e413d6a8607db4f82b5e2dc35c58bea543098/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
[modify] https://crrev.com/d28e413d6a8607db4f82b5e2dc35c58bea543098/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
[modify] https://crrev.com/d28e413d6a8607db4f82b5e2dc35c58bea543098/chrome/browser/profiles/profile_impl_io_data.cc
[add] https://crrev.com/d28e413d6a8607db4f82b5e2dc35c58bea543098/chrome/test/data/offline_pages/hello.mhtml
[modify] https://crrev.com/d28e413d6a8607db4f82b5e2dc35c58bea543098/components/offline_pages/downloads/download_ui_adapter.cc
[modify] https://crrev.com/d28e413d6a8607db4f82b5e2dc35c58bea543098/components/offline_pages/downloads/download_ui_adapter.h
[modify] https://crrev.com/d28e413d6a8607db4f82b5e2dc35c58bea543098/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/d28e413d6a8607db4f82b5e2dc35c58bea543098/components/offline_pages/offline_page_model_impl.h

Comment 2 by jianli@chromium.org, Sep 14 2016

Labels: M-54 Merge-Request-54

Comment 3 by dimu@chromium.org, Sep 14 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 16 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca

commit 1becb232faf7661a17d5a14b4ba2a0d4e072c5ca
Author: Jian Li <jianli@chromium.org>
Date: Fri Sep 16 21:09:02 2016

Merge M54: Support serving offline page by offline ID

Review-Url: https://codereview.chromium.org/2322833002
Cr-Commit-Position: refs/heads/master@{#418089}
(cherry picked from commit d28e413d6a8607db4f82b5e2dc35c58bea543098)

BUG= 643404 
TEST=new tests added

Review URL: https://codereview.chromium.org/2340133005 .

Cr-Commit-Position: refs/branch-heads/2840@{#395}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/offline_page_request_interceptor.cc
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/offline_page_request_interceptor.h
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/offline_page_request_job.h
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/profiles/profile_impl_io_data.cc
[add] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/test/data/offline_pages/hello.mhtml
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/components/offline_pages/downloads/download_ui_adapter.cc
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/components/offline_pages/downloads/download_ui_adapter.h
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/components/offline_pages/offline_page_model_impl.h

Comment 5 by jianli@chromium.org, Sep 16 2016

Status: Fixed (was: Assigned)

Comment 6 by kgna...@chromium.org, Sep 21 2016

Status: Verified (was: Fixed)
Works as per expected behavior, Issues tested in Lenovo K50a40 / LRX21M, Moto G4 Plus / 6.0 on 54.0.2840.34
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca

commit 1becb232faf7661a17d5a14b4ba2a0d4e072c5ca
Author: Jian Li <jianli@chromium.org>
Date: Fri Sep 16 21:09:02 2016

Merge M54: Support serving offline page by offline ID

Review-Url: https://codereview.chromium.org/2322833002
Cr-Commit-Position: refs/heads/master@{#418089}
(cherry picked from commit d28e413d6a8607db4f82b5e2dc35c58bea543098)

BUG= 643404 
TEST=new tests added

Review URL: https://codereview.chromium.org/2340133005 .

Cr-Commit-Position: refs/branch-heads/2840@{#395}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/offline_page_request_interceptor.cc
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/offline_page_request_interceptor.h
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/offline_page_request_job.h
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/browser/profiles/profile_impl_io_data.cc
[add] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/chrome/test/data/offline_pages/hello.mhtml
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/components/offline_pages/downloads/download_ui_adapter.cc
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/components/offline_pages/downloads/download_ui_adapter.h
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca/components/offline_pages/offline_page_model_impl.h
►

Sign in to add a comment