New issue
Advanced search Search tips

Issue 643396 link

Starred by 1 user
Status: Fixed
Owner:
riajiang@chromium.org
Closed: Sep 2016
Cc:
mustash-bugs@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

touch hud app cannot be launched in mash

Project Member Reported by riajiang@chromium.org, Sep 1 2016 
It will use the accelerator in classical ash (https://cs.chromium.org/chromium/src/ash/accelerators/accelerator_commands_aura.cc?type=cs&q=toggletouchhud&sq=package:chromium&l=18) instead of launching the correct touch hud app.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4a5b6ba306e15416f45d17a599808311d292de6

commit c4a5b6ba306e15416f45d17a599808311d292de6
Author: riajiang <riajiang@chromium.org>
Date: Fri Sep 02 23:47:11 2016

mash: Fix launching touch hud app in mash mode.

Also switching back to listen for move events in touch hud app.

BUG= 643396 
TEST=manual

Review-Url: https://codereview.chromium.org/2296763009
Cr-Commit-Position: refs/heads/master@{#416394}

[modify] https://crrev.com/c4a5b6ba306e15416f45d17a599808311d292de6/ash/mus/BUILD.gn
[modify] https://crrev.com/c4a5b6ba306e15416f45d17a599808311d292de6/ash/mus/DEPS
[modify] https://crrev.com/c4a5b6ba306e15416f45d17a599808311d292de6/ash/mus/accelerators/accelerator_controller_delegate_mus.cc
[modify] https://crrev.com/c4a5b6ba306e15416f45d17a599808311d292de6/ash/mus/accelerators/accelerator_controller_delegate_mus.h
[modify] https://crrev.com/c4a5b6ba306e15416f45d17a599808311d292de6/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/c4a5b6ba306e15416f45d17a599808311d292de6/ash/mus/manifest.json
[modify] https://crrev.com/c4a5b6ba306e15416f45d17a599808311d292de6/ash/touch_hud/mus/touch_hud_application.cc
[modify] https://crrev.com/c4a5b6ba306e15416f45d17a599808311d292de6/chrome/app/mojo/chrome_manifest.json
[modify] https://crrev.com/c4a5b6ba306e15416f45d17a599808311d292de6/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/c4a5b6ba306e15416f45d17a599808311d292de6/chrome/browser/ui/DEPS
[modify] https://crrev.com/c4a5b6ba306e15416f45d17a599808311d292de6/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/c4a5b6ba306e15416f45d17a599808311d292de6/mash/BUILD.gn
[modify] https://crrev.com/c4a5b6ba306e15416f45d17a599808311d292de6/mash/app_driver/BUILD.gn
[modify] https://crrev.com/c4a5b6ba306e15416f45d17a599808311d292de6/mash/app_driver/app_driver.cc

Comment 2 by riajiang@chromium.org, Sep 3 2016

Status: Fixed (was: Started)
►

Sign in to add a comment