Issue 643393 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	nparker@chromium.org
Closed:	Sep 2016
Cc:	skare@chromium.org isherman@chromium.org asvitk...@chromium.org █ rkaplow@chromium.org
Components:	Internals>Metrics
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	3
Type:	Bug
merge-merged-2840

Create test hook for IsMetricsAndCrashReportingEnabled()

Project Member Reported by nparker@chromium.org, Sep 1 2016

Issue description

Make a test hook so we can mock the return code of ChromeMetricsServiceAccessor::IsMetricsAndCrashReportingEnabled().

Otherwise, tests are forced to set the kMetricsReportingEnabled pref, which delves into the implementation details and may not work on all platforms. Replace usage of that pref in tests with the new hook.

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8548bedfaf6c4a54b37de8f01821dff63544b85c

commit 8548bedfaf6c4a54b37de8f01821dff63544b85c
Author: nparker <nparker@chromium.org>
Date: Tue Sep 06 17:52:18 2016

Only report PasswordState in Sync for UMA+non-custom passphrase users.

BUG=641421, 643393 

Review-Url: https://codereview.chromium.org/2302823003
Cr-Commit-Position: refs/heads/master@{#416659}

[modify] https://crrev.com/8548bedfaf6c4a54b37de8f01821dff63544b85c/chrome/browser/metrics/chrome_metrics_service_accessor.cc
[modify] https://crrev.com/8548bedfaf6c4a54b37de8f01821dff63544b85c/chrome/browser/metrics/chrome_metrics_service_accessor.h
[modify] https://crrev.com/8548bedfaf6c4a54b37de8f01821dff63544b85c/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/8548bedfaf6c4a54b37de8f01821dff63544b85c/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/8548bedfaf6c4a54b37de8f01821dff63544b85c/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Comment 2 by nparker@chromium.org, Sep 6 2016

Status: Fixed (was: Assigned)

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 7 2016

Labels: merge-merged-2840

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67

commit 91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67
Author: Nathan Parker <nparker@chromium.org>
Date: Wed Sep 07 22:26:33 2016

[Merge M54] Only report PasswordState in Sync for UMA+non-custom passphrase users.

BUG=641421, 643393 

Review-Url: https://codereview.chromium.org/2302823003
Cr-Commit-Position: refs/heads/master@{#416659}
(cherry picked from commit 8548bedfaf6c4a54b37de8f01821dff63544b85c)

Review URL: https://codereview.chromium.org/2317163003 .

Cr-Commit-Position: refs/branch-heads/2840@{#221}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67/chrome/browser/metrics/chrome_metrics_service_accessor.cc
[modify] https://crrev.com/91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67/chrome/browser/metrics/chrome_metrics_service_accessor.h
[modify] https://crrev.com/91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67

commit 91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67
Author: Nathan Parker <nparker@chromium.org>
Date: Wed Sep 07 22:26:33 2016

[Merge M54] Only report PasswordState in Sync for UMA+non-custom passphrase users.

BUG=641421, 643393 

Review-Url: https://codereview.chromium.org/2302823003
Cr-Commit-Position: refs/heads/master@{#416659}
(cherry picked from commit 8548bedfaf6c4a54b37de8f01821dff63544b85c)

Review URL: https://codereview.chromium.org/2317163003 .

Cr-Commit-Position: refs/branch-heads/2840@{#221}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67/chrome/browser/metrics/chrome_metrics_service_accessor.cc
[modify] https://crrev.com/91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67/chrome/browser/metrics/chrome_metrics_service_accessor.h
[modify] https://crrev.com/91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/91f04d2af1f09e4ed1ee0dba9298e5e26ca1ac67/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

►

Issue 643393 link

Issue metadata

Create test hook for IsMetricsAndCrashReportingEnabled()

Issue description

Comment 1 by bugdroid1@chromium.org, Sep 6 2016

Comment 1 Deleted

Comment 2 by nparker@chromium.org, Sep 6 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Sep 7 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Oct 27 2016

Comment 4 Deleted

Sign in to add a comment