New issue
Advanced search Search tips

Issue 643368 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Convert Ozone GL implementations to use the new GLOzone API

Project Member Reported by kylec...@chromium.org, Sep 1 2016

Issue description

Convert Ozone platforms so they use GLOZone to initialize and create contexts/surfaces for GL.
 
Summary: Convert Ozone GL implementations to use the new GLOzone API (was: Convert Ozone GL implementatinos to use the new GLOzone API)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f459b4e2ec95e4356140c20a40641cf31a68f9c

commit 6f459b4e2ec95e4356140c20a40641cf31a68f9c
Author: kylechar <kylechar@chromium.org>
Date: Thu Sep 15 13:44:50 2016

Convert Ozone GBM to use GLOzone.

Add GLOzoneEGLGbm and remove old API calls.

BUG= 643368 

Review-Url: https://codereview.chromium.org/2327813002
Cr-Commit-Position: refs/heads/master@{#418857}

[modify] https://crrev.com/6f459b4e2ec95e4356140c20a40641cf31a68f9c/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
[modify] https://crrev.com/6f459b4e2ec95e4356140c20a40641cf31a68f9c/ui/ozone/platform/drm/gpu/gbm_surface_factory.h

For the record, the ozoone/wayland conversion happened here: https://codereview.chromium.org/2313353003/ (by fwang@igalia.com)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb7035ba2f770b01a1f864e8653bbcf9446c474e

commit cb7035ba2f770b01a1f864e8653bbcf9446c474e
Author: kylechar <kylechar@chromium.org>
Date: Thu Mar 02 17:50:08 2017

Remove deprecated SurfaceFactoryOzone methods.

Everything has been switched over to GLOzone and the deprecated method
aren't used anymore. Remove the callers from gl_factory_ozone.cc and
gl_initializer_ozone.cc and remove the methods from SurfaceFactoryOzone.

BUG= 643368 

Review-Url: https://codereview.chromium.org/2723613003
Cr-Commit-Position: refs/heads/master@{#454301}

[modify] https://crrev.com/cb7035ba2f770b01a1f864e8653bbcf9446c474e/ui/gl/init/gl_factory_ozone.cc
[modify] https://crrev.com/cb7035ba2f770b01a1f864e8653bbcf9446c474e/ui/gl/init/gl_initializer_ozone.cc
[modify] https://crrev.com/cb7035ba2f770b01a1f864e8653bbcf9446c474e/ui/ozone/public/surface_factory_ozone.cc
[modify] https://crrev.com/cb7035ba2f770b01a1f864e8653bbcf9446c474e/ui/ozone/public/surface_factory_ozone.h

Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3

commit 2cb74b7eae8939042b92edd1fc277b6ab61f2fc3
Author: kylechar <kylechar@chromium.org>
Date: Fri Mar 03 21:30:51 2017

Convert Ozone GL OSMesa implementation.

Convert Ozone GL code for OSMesa to use the GLOzone interface. This
simplifies the initialization code in ui/gl/ and lets every Ozone
platform fully define the GL implementations that are available.

BUG= 643368 

Review-Url: https://codereview.chromium.org/2731733002
Cr-Commit-Position: refs/heads/master@{#454681}

[modify] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/gl/init/gl_factory_ozone.cc
[modify] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/gl/init/gl_initializer_ozone.cc
[modify] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/ozone/common/BUILD.gn
[add] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/ozone/common/gl_ozone_osmesa.cc
[add] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/ozone/common/gl_ozone_osmesa.h
[modify] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/ozone/platform/cast/surface_factory_cast.cc
[modify] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/ozone/platform/cast/surface_factory_cast.h
[modify] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
[modify] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/ozone/platform/drm/gpu/gbm_surface_factory.h
[modify] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/ozone/platform/headless/headless_surface_factory.cc
[modify] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/ozone/platform/headless/headless_surface_factory.h
[modify] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/ozone/platform/wayland/wayland_surface_factory.cc
[modify] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/ozone/platform/wayland/wayland_surface_factory.h
[modify] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/ozone/platform/x11/x11_surface_factory.cc
[modify] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/ozone/platform/x11/x11_surface_factory.h
[modify] https://crrev.com/2cb74b7eae8939042b92edd1fc277b6ab61f2fc3/ui/ozone/public/surface_factory_ozone.cc

Status: Fixed (was: Started)

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment