New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 643367 link

Starred by 1 user
Status: Verified
Owner:
r...@chromium.org
Closed: Sep 2016
Cc:
snanda@chromium.org
█ keta...@chromium.org
r...@chromium.org
█ mcchou@chromium.org
puthik@chromium.org
█ bhthompson@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 643445



Sign in to add a comment

Android can't make ARC++ device BT discoverable

Project Member Reported by puthik@chromium.org, Sep 1 2016 
How to reproduce
- Open CTS Verifier app on minnie
- Open Bluetooth -> Insecure Server test  (Or Secure server test)
- Tap Make Discoverable Button

Expected result:
Pixel C can see minnie in Insecure Client Test

Actual result:
Pixel C can't see minnie.

Note:
Minnie bluetoothctl shows that it is not discoverable.
If we toggle that manually, the CTS Verifier test will pass.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd2bc7fb594c0d299649b3416055014e3c402107

commit fd2bc7fb594c0d299649b3416055014e3c402107
Author: puthik <puthik@chromium.org>
Date: Thu Sep 01 21:42:28 2016

arc: bluetooth: Implement set discoverable state

This CL handles request from Android to set discoverable timeout.
As Android API for this is set the discoverable timeout but the
Chrome API is set state on or off. ArcBluetoothBridge need to
maintain a new timer class to turn the discoverable state off
when the timer runs out.

BUG= 643367 ,b:31180714
TEST=CTS Verifier app can make device discoverable for 30 seconds.
     Verified via bluetoothctl tool

Review-Url: https://codereview.chromium.org/2297903002
Cr-Commit-Position: refs/heads/master@{#416066}

[modify] https://crrev.com/fd2bc7fb594c0d299649b3416055014e3c402107/components/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/fd2bc7fb594c0d299649b3416055014e3c402107/components/arc/bluetooth/arc_bluetooth_bridge.h

Comment 2 by mcchou@chromium.org, Sep 1 2016

Blocking: 643445

Comment 3 by puthik@chromium.org, Sep 7 2016

Cc: -r...@chromium.org st...@chromium.org puthik@chromium.org
Labels: Merge-Request-53
Owner: keta...@chromium.org
Ask for M53 merge for CTS-Verifier

Comment 4 by dimu@chromium.org, Sep 7 2016

Labels: -Merge-Request-53 Merge-Review-53 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M53), manual review required.

Comment 5 by puthik@chromium.org, Sep 7 2016

Cc: keta...@chromium.org
Owner: bhthompson@chromium.org
Ask Bernie for manual review.

This patch only touch the component/arc.

Comment 6 by bhthompson@google.com, Sep 7 2016

Labels: -Hotlist-Merge-review -Merge-Review-53 Merge-Approved-53
This appears to be ARC specific, and is a blocker for stable for ARC, so we should land this.

Comment 7 by puthik@chromium.org, Sep 7 2016

Cc: bhthompson@chromium.org
Owner: st...@chromium.org
Assign to steel for merge
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 7 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8abb1b7291cc50ab063e94ef7e72aece46b822b

commit c8abb1b7291cc50ab063e94ef7e72aece46b822b
Author: Rahul Chaturvedi <rkc@google.com>
Date: Wed Sep 07 23:48:50 2016

arc: bluetooth: Implement set discoverable state

This CL handles request from Android to set discoverable timeout.
As Android API for this is set the discoverable timeout but the
Chrome API is set state on or off. ArcBluetoothBridge need to
maintain a new timer class to turn the discoverable state off
when the timer runs out.

BUG= 643367 ,b:31180714
TEST=CTS Verifier app can make device discoverable for 30 seconds.
     Verified via bluetoothctl tool

Review-Url: https://codereview.chromium.org/2297903002
Cr-Commit-Position: refs/heads/master@{#416066}
(cherry picked from commit fd2bc7fb594c0d299649b3416055014e3c402107)

Review URL: https://codereview.chromium.org/2316353003 .

Cr-Commit-Position: refs/branch-heads/2785@{#847}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/c8abb1b7291cc50ab063e94ef7e72aece46b822b/components/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/c8abb1b7291cc50ab063e94ef7e72aece46b822b/components/arc/bluetooth/arc_bluetooth_bridge.h

Comment 9 by st...@chromium.org, Sep 7 2016

Status: Fixed (was: Started)

Comment 10 by puthik@chromium.org, Sep 8 2016

Labels: M-54 Merge-Request-54
Status: Started (was: Fixed)
Reopen. We also need to merge this to M54
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e89cbdd5e7c2abf0f82153c652fa0a384d5536c7

commit e89cbdd5e7c2abf0f82153c652fa0a384d5536c7
Author: Rahul Chaturvedi <rkc@google.com>
Date: Thu Sep 08 20:13:27 2016

arc: bluetooth: Implement set discoverable state

This CL handles request from Android to set discoverable timeout.
As Android API for this is set the discoverable timeout but the
Chrome API is set state on or off. ArcBluetoothBridge need to
maintain a new timer class to turn the discoverable state off
when the timer runs out.

BUG= 643367 ,b:31180714
TEST=CTS Verifier app can make device discoverable for 30 seconds.
     Verified via bluetoothctl tool

Review-Url: https://codereview.chromium.org/2297903002
Cr-Commit-Position: refs/heads/master@{#416066}
(cherry picked from commit fd2bc7fb594c0d299649b3416055014e3c402107)

Review URL: https://codereview.chromium.org/2324463004 .

Cr-Commit-Position: refs/branch-heads/2840@{#245}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/e89cbdd5e7c2abf0f82153c652fa0a384d5536c7/components/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/e89cbdd5e7c2abf0f82153c652fa0a384d5536c7/components/arc/bluetooth/arc_bluetooth_bridge.h

Comment 12 by st...@chromium.org, Sep 8 2016

Status: Fixed (was: Started)

Comment 13 by puthik@chromium.org, Sep 8 2016

Labels: -Merge-Request-54

Comment 14 by kathrelk...@chromium.org, Sep 28 2016

Status: Verified (was: Fixed)
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e89cbdd5e7c2abf0f82153c652fa0a384d5536c7

commit e89cbdd5e7c2abf0f82153c652fa0a384d5536c7
Author: Rahul Chaturvedi <rkc@google.com>
Date: Thu Sep 08 20:13:27 2016

arc: bluetooth: Implement set discoverable state

This CL handles request from Android to set discoverable timeout.
As Android API for this is set the discoverable timeout but the
Chrome API is set state on or off. ArcBluetoothBridge need to
maintain a new timer class to turn the discoverable state off
when the timer runs out.

BUG= 643367 ,b:31180714
TEST=CTS Verifier app can make device discoverable for 30 seconds.
     Verified via bluetoothctl tool

Review-Url: https://codereview.chromium.org/2297903002
Cr-Commit-Position: refs/heads/master@{#416066}
(cherry picked from commit fd2bc7fb594c0d299649b3416055014e3c402107)

Review URL: https://codereview.chromium.org/2324463004 .

Cr-Commit-Position: refs/branch-heads/2840@{#245}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/e89cbdd5e7c2abf0f82153c652fa0a384d5536c7/components/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/e89cbdd5e7c2abf0f82153c652fa0a384d5536c7/components/arc/bluetooth/arc_bluetooth_bridge.h

Comment 16 by st...@chromium.org, Mar 3 2017

Cc: r...@chromium.org

Comment 17 by st...@chromium.org, Mar 3 2017

Cc: -st...@chromium.org

Comment 18 by st...@chromium.org, Mar 3 2017

Owner: r...@chromium.org
►

Sign in to add a comment