New issue
Advanced search Search tips

Issue 643366 link

Starred by 2 users
Status: Fixed
Owner:
mea...@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug
Team-Security-UX

Blocking:
issue 488673



Sign in to add a comment

SSLBlockingPage and BadClockBlockingPage each have two ChromeControllerClients

Project Member Reported by mea...@chromium.org, Sep 1 2016 
Both of these classes have a controller_ member and are derived from SecurityInterstitialPage. SecurityInterstitialPage also creates its own ChromeControllerClient, so both classes end up with two ChromeControllerClient instances.

It seems like exposing SecurityInterstitialPage's controller as a protected method and using it in the derived classes should work.

Comment 1 by mea...@chromium.org, Sep 1 2016

Status: Started (was: Assigned)

Comment 2 by raymes@chromium.org, Sep 6 2016

Labels: Interstitials
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9de01454fe7e379925b2bb1100e9b14c5cad535a

commit 9de01454fe7e379925b2bb1100e9b14c5cad535a
Author: meacer <meacer@chromium.org>
Date: Fri Sep 09 22:53:50 2016

Use controller from SecurityInterstitialPage in derived classes

BUG= 643366 

Review-Url: https://codereview.chromium.org/2298613007
Cr-Commit-Position: refs/heads/master@{#417748}

[modify] https://crrev.com/9de01454fe7e379925b2bb1100e9b14c5cad535a/chrome/browser/interstitials/security_interstitial_page.cc
[modify] https://crrev.com/9de01454fe7e379925b2bb1100e9b14c5cad535a/chrome/browser/interstitials/security_interstitial_page.h
[modify] https://crrev.com/9de01454fe7e379925b2bb1100e9b14c5cad535a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
[modify] https://crrev.com/9de01454fe7e379925b2bb1100e9b14c5cad535a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
[modify] https://crrev.com/9de01454fe7e379925b2bb1100e9b14c5cad535a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
[modify] https://crrev.com/9de01454fe7e379925b2bb1100e9b14c5cad535a/chrome/browser/ssl/bad_clock_blocking_page.cc
[modify] https://crrev.com/9de01454fe7e379925b2bb1100e9b14c5cad535a/chrome/browser/ssl/bad_clock_blocking_page.h
[modify] https://crrev.com/9de01454fe7e379925b2bb1100e9b14c5cad535a/chrome/browser/ssl/captive_portal_blocking_page.h
[modify] https://crrev.com/9de01454fe7e379925b2bb1100e9b14c5cad535a/chrome/browser/ssl/ssl_blocking_page.cc
[modify] https://crrev.com/9de01454fe7e379925b2bb1100e9b14c5cad535a/chrome/browser/ssl/ssl_blocking_page.h

Comment 5 by mea...@chromium.org, Sep 30 2016

Status: Fixed (was: Started)

Comment 6 by lgar...@chromium.org, Nov 22 2016

Components: -Security>UX UI>Browser>Interstitials
►

Sign in to add a comment