This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Hello!

I would like to take on this bug. I was digging into the code and I wanted to propose a simple solution:

We can wrap template_url_ inside a unique_ptr on EditSearchEngineController, this way we make sure to be clear that this class currently owns the reference to the pointer. Then whenever template_url_ is passed as a parameter we just get the raw pointer and pass it to the function.

This would work except for this line of code: https://cs.chromium.org/chromium/src/chrome/browser/ui/search_engines/edit_search_engine_controller.cc?sq=package:chromium&l=108

Here we can see that the ownership of template_url_ is being transfer, so we can make use of std::move to transfer the ownership and also document that the function AcceptAddOrEdit transfers the ownership of template_url_

If my memory serves, the problem is that if the controller owns this pointer, that only works for adds, not edits.  For adds, it makes sense that we construct this, then hand it off to the template URL service.  For edits, we can't own the pointer, because the template URL service already does.  So either we can't use one variable to hold both of these, or we shouldn't use one "controller" object to deal with both adding and editing, or something.

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot