Here's an example. And no, it's not "OK".

Deleted: alert.png 165 KB

	alert.png 165 KB View Download

Here's the Windows version for comparison.

I forgot to mention in the bug report that on OS X, pressing Escape doesn't work either (as a substitute for clicking OK).

Deleted: alert.png 9.1 KB

	alert.png 9.1 KB View Download

+some views folks because they are familiar with dialogs.  Will macviews change the way we show these alert dialogs?

#4: not in the near future.

For reference, Safari calls the button "Close" instead of "Ok" and has no X icon.

shrike, what do you think we should do here?

Just a note that even though Safari has no "x' icon within the alert pop-up itself, there are multiple other ways to close the alert box in Safari without having to click its button:
 * Press Esc
 * Click the little 'x' to close the tab, which makes the entire web page tab plus its alert box disappear at the same time (my favourite method, if the alert is at all suspicious or intrusive)
 * Press Command-W, which does the same thing

All of these work in Safari; none work in Chrome.

Regarding the last two options, see the comment at the end of my bug report.

There are two issues mentioned in this bug: the inability to close the dialog without clicking an OK button, and being able to close a tab that has a modal dialog. The bug title refers to the former issue.  If closing a tab that has a modal dialog is a concern, that should be filed in a separate bug.

Long term, avi@'s working on changing how these dialogs work in the browser, which will solve this problem.

Short term, we could consider renaming the OK button to Close. I'm not sure how I feel about making Esc dismiss the dialog as well as Return.

#7: renaming the OK button to Close sounds good to me. I'll put a CL up.

+cc felt

Actually, I'm going to ask security enamel, since this is sort of a security bug (?), and get their opinion on what we should do with this button.

felt@, what do you think we should do with this button text? Should we leave it as "Ok", change it to "Close" (this is what Safari does), change it to something else?

Changing it is not difficult: just modifications to JavaScriptAppModalDialogCocoa::JavaScriptAppModalDialogCocoa() and JavaScriptAppModalDialogViews::GetDialogButtonLabel().

+cc emilyschechter, avi

This will be a nice thing to have changed. I think we should either change it to "Close" or add an "x". I won't pretend to understand the nuances of Mac design philosophy so adding in product and UI people in case they have an opinion.

I agree with changing it to close (though I am neither a product or UI person).

+rpop for desktop -- do you know if there should be X's on mac dialogs?

Modal dialogs on the Mac (of which this is one) do not have X close buttons.

Modal dialogs are NSAlerts. Changing "OK" to "Close" is wrong and is a web-facing change.

Clicking the [X] is _identical_ to clicking OK.

This bug reads to me as WAI; what are people agreeing to?

FYI, Safari doesn't have this problem because they've switched to custom views for alerts with dismissal-on-closure. I'm working on changing Chrome to do that too.

I just spoke to avi@ - he is not suggesting in c#14 that we should add an X button to the Mac dialog. He was pointing out that in Views there is a close button and an OK button, and that there is no difference between clicking the close button and clicking the OK button.

He is skeptical of the value of changing the button name from OK to Close, and says that this is a web-facing change and needs to be run by UX.

I agree it should be run by UX

My argument in favor of changing "OK" to "Close" (or adding an "X") is that the behavior of "OK" is unclear. Are you accepting whatever is in the dialog...? What does "OK" mean?

My argument against is that in a dialog, "OK" means acceptance of what it says. If we put verbs in the buttons, users are going to expect that action.

For example, take the dialog:

> Save your work? [Cancel] [Save]

then clicking the verb button ("save") _does_ something.

My fear is that if we have a dialog like

> Website says blah blah [Close]

that the user may be even more scared, because they are being forced into taking an action with no way out. At least "OK" is "meh, ok" whereas "Close" is "oh no, I'm being forced into closing this".

Also, it's not clear what "Close" would even mean as a button action. _We_ know that "close" would mean closing only of the alert box, but given that verbs in alert boxes always mean taking action on an item _outside_ the alert box (e.g. the save alert box, the onbeforeunload alert box), we'd be implying that something else would be closing, and again, causing user distress over being forced to close something.

So I'm definitely a no here. But we need to bring UX in.

+hwi@ is likely the right point person for this since she has the best view of the Harmony interaction design right now.

The confusing UI here caused https://crbug.com/644961, also.

I think fixing this has to be part of avi@'s JS modal rework. It's pretty clear that changing the text of the button isn't going to make sense by itself, and we need to redesign the idea of an alert dialog to make it very clear what the actual options are.

Sending this one over to avi@ for incorporation in their modal rework.

I'm going to dup this into my work.