New issue
Advanced search Search tips

Issue 643345 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Parse emails in Tree is closed notice and display as username + mailto link

Project Member Reported by zhangtiff@google.com, Sep 1 2016

Issue description

Buildbot often posts tree is closed notices with long lists of users' emails. ie: 

Tree is closed (Automatic: "compile" on http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/13369 "Google Chrome Linux x64" from 4699ae91a149ba076870ba65795228e3f53f3d11: agrieve@chromium.org,catapult-deps-roller@chromium.org,dalecurtis@chromium.org,hans@chromium.org,jbroman@chromium.org,kojii@chromium.org,manzagop@chromium.org,mattreynolds@chromium.org,pdfium-deps-roller@chromium.org,pfeldman@chromium.org,pwnall@chromium.org,qiankun.miao@intel.com,recipe-r… by buildbot on 2016-09-01 19:32:41.604970 GMT (More)

This is long and unreadable (takes up like 4 lines on the notice) On the status app they display this text as username links, and I think we should do the same to make it less garbled looking. 
 
Status: Available (was: Untriaged)
(Making Available, since it's been triaged as Pri-2)

SOM should use a json api from chromium-status. Someone should either hook that up, or add it if it's not there (code https://cs.chromium.org/chromium/infra/appengine/chromium_status/appengine_module/chromium_status/main.py).
Owner: ----
Currently it uses this API:  https://chromium-status.appspot.com/current?format=json 

But in messages like the one I posted, this part is all plaintext in the message field: 

Tree is closed (Automatic: "compile" on http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/13369 "Google Chrome Linux x64" from 4699ae91a149ba076870ba65795228e3f53f3d11: agrieve@chromium.org,catapult-deps-roller@chromium.org,dalecurtis@chromium.org,hans@chromium.org,jbroman@chromium.org,kojii@chromium.org,manzagop@chromium.org,mattreynolds@chromium.org,pdfium-deps-roller@chromium.org,pfeldman@chromium.org,pwnall@chromium.org,qiankun.miao@intel.com,recipe-r…

On the status site, this message shows up like this: https://screenshot.googleplex.com/zEj1rzNnFsx 

I'm not sure if they parse the emails from the plaintext and change how they're displayed or if they actually store the information in a more descriptive format than their API gives. 
Labels: Type-Bug
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 2 2016

Labels: Hotlist-Google
Labels: -Milestone-SoMNG-FollowUp Milestone-SoMNGFollowUp
Owner: zhangtiff@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment