Example: wtf/Vector.h:
We rewrite |m_size| into |size_|, but comments referring to the field keep saying |m_size|.
This is probably less important than making sure things compile and behave the same after the rename, but we probably still want to explicitly track this issue / make some kind of a decision here.
True. The rewrite tool dumps a list of symbols it renamed. We could apply them with a regex after and look at the diff to see what it does, the # of changes should be muuuch smaller and be possible to human-review.
Cc: nasko@chromium.org Status: Available (was: Untriaged)
When automating rewriting of comments (to follow renaming of identifiers elsewhere), we should be aware of the following:
- We should avoid rewriting free-form English words - we should only rewrite actual identifiers. Maybe this can be done via a set of heuristics:
- Rewrite anything that begings with m_* OR s_*
- Rewrite anything that is PascalCased, camelCased, hacker_cased
- Rewrite anything that is followed by "(" character
- We should avoid rewriting identifiers outside of Blink (i.e. in Skia). Maybe just rewrite C++ comments under third_party/WebKit?
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.
Sorry for the inconvenience if the bug really should have been left as Available.
For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Comment 1 by danakj@chromium.org
, Sep 1 2016