New issue
Advanced search Search tips

Issue 643309 link

Starred by 1 user
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Jul 2017
Cc:
tbuck...@chromium.org
bettes@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[MD-Settings] Style issues with "Advanced" link

Project Member Reported by hcarmona@chromium.org, Sep 1 2016 
Mocks show a ripple on the "advanced" button (go/wiugd)
From chat w/ bettes@: font weight should also be 500.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/305ffc4f4518e097789f478cad137100fd938d5a

commit 305ffc4f4518e097789f478cad137100fd938d5a
Author: hcarmona <hcarmona@chromium.org>
Date: Sat Sep 03 03:41:16 2016

[MD-Settings] Make the Advanced button into an actual button.

This change enables keyboard focus, as well as making the button show
as a button on screen readers.

No UI change, except that the button has a ripple now. The ripple was
missing.

BUG= 626879 , 643309 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2305973002
Cr-Commit-Position: refs/heads/master@{#416440}

[modify] https://crrev.com/305ffc4f4518e097789f478cad137100fd938d5a/chrome/browser/resources/settings/settings_main/settings_main.html

Comment 2 by hcarmona@chromium.org, Jul 6 2017

Status: Fixed (was: Assigned)
Forgot to mark this as fixed.
►

Sign in to add a comment