Remove unneeded PLT histograms for data reduction proxy |
|||
Issue descriptionHere is a list of candidates to remove: PLT.NT_DomainLookup_DataReductionProxy PLT.NT_Connect_DataReductionProxy PLT.NT_DomLoading_DataReductionProxy PLT.NT_DomInteractive_DataReductionProxy PLT.NT_DomContentLoaded_DataReductionProxy PLT.NT_DomainLookup_HTTPS_DataReductionProxy PLT.NT_Connect_HTTPS_DataReductionProxy PLT.NT_DomLoading_HTTPS_DataReductionProxy PLT.NT_DomInteractive_HTTPS_DataReductionProxy PLT.NT_DomContentLoaded_HTTPS_DataReductionProxy PLT.PT_BeginToFinishDoc_HTTPS_DataReductionProxy PLT.PT_CommitToFinishDoc_HTTPS_DataReductionProxy PLT.PT_RequestToFinishDoc_HTTPS_DataReductionProxy PLT.PT_BeginToFinishDoc_DataReductionProxy PLT.PT_CommitToFinishDoc_DataReductionProxy PLT.PT_RequestToFinishDoc_DataReductionProxy PLT.PT_BeginToFinish_HTTPS_DataReductionProxy PLT.PT_CommitToFinish_HTTPS_DataReductionProxy PLT.PT_RequestToFinish_HTTPS_DataReductionProxy PLT.PT_StartToFinish_HTTPS_DataReductionProxy PLT.PT_BeginToFinish_HTTPS_DataReductionProxy_AutoLoFiOn PLT.PT_CommitToFinish_HTTPS_DataReductionProxy_AutoLoFiOn PLT.PT_RequestToFinish_HTTPS_DataReductionProxy_AutoLoFiOn PLT.PT_StartToFinish_HTTPS_DataReductionProxy_AutoLoFiOn PLT.BeginToFirstPaint_HTTPS_DataReductionProxy_AutoLoFiOn PLT.PT_BeginToFinish_HTTPS_DataReductionProxy_AutoLoFiOff PLT.PT_CommitToFinish_HTTPS_DataReductionProxy_AutoLoFiOff PLT.PT_RequestToFinish_HTTPS_DataReductionProxy_AutoLoFiOff PLT.PT_StartToFinish_HTTPS_DataReductionProxy_AutoLoFiOff PLT.BeginToFirstPaint_HTTPS_DataReductionProxy_AutoLoFiOff PLT.PT_BeginToFinish_DataReductionProxy PLT.PT_CommitToFinish_DataReductionProxy PLT.PT_RequestToFinish_DataReductionProxy PLT.PT_StartToFinish_DataReductionProxy PLT.PT_BeginToFinish_DataReductionProxy_AutoLoFiOn PLT.PT_CommitToFinish_DataReductionProxy_AutoLoFiOn PLT.PT_RequestToFinish_DataReductionProxy_AutoLoFiOn PLT.PT_StartToFinish_DataReductionProxy_AutoLoFiOn PLT.BeginToFirstPaint_DataReductionProxy_AutoLoFiOn PLT.PT_BeginToFinish_DataReductionProxy_AutoLoFiOff PLT.PT_CommitToFinish_DataReductionProxy_AutoLoFiOff PLT.PT_RequestToFinish_DataReductionProxy_AutoLoFiOff PLT.PT_StartToFinish_DataReductionProxy_AutoLoFiOff PLT.BeginToFirstPaint_DataReductionProxy_AutoLoFiOff PLT.PT_FinishDocToFinish_DataReductionProxy PLT.NT_LoadEvent_DataReductionProxy PLT.PT_FinishDocToFinish_HTTPS_DataReductionProxy PLT.NT_LoadEvent_HTTPS_DataReductionProxy PLT.PT_FinishDocToFinish_HTTPS_DataReductionProxy PLT.PT_FinishDocToFinish_DataReductionProxy PLT.PT_RequestToDomContentLoaded_HTTPS_DataReductionProxy PLT.PT_RequestToDomContentLoaded_HTTPS_DataReductionProxy_AutoLoFiOn PLT.PT_RequestToDomContentLoaded_HTTPS_DataReductionProxy_AutoLoFiOff PLT.PT_RequestToDomContentLoaded_DataReductionProxy PLT.PT_RequestToDomContentLoaded_DataReductionProxy_AutoLoFiOn PLT.PT_RequestToDomContentLoaded_DataReductionProxy_AutoLoFiOff PLT.PT_BeginToCommit_HTTPS_DataReductionProxy PLT.PT_RequestToStart_HTTPS_DataReductionProxy PLT.PT_StartToCommit_HTTPS_DataReductionProxy PLT.PT_RequestToCommit_HTTPS_DataReductionProxy PLT.PT_BeginToCommit_DataReductionProxy PLT.PT_RequestToStart_DataReductionProxy PLT.PT_StartToCommit_DataReductionProxy PLT.PT_RequestToCommit_DataReductionProxy PLT.BeginToFinishDoc_SpdyProxy PLT.BeginToFinish_SpdyProxy
,
Sep 6 2016
ryansturm: Thanks for taking this.
,
Sep 7 2016
leonhsl: Since you started https://codereview.chromium.org/2063683002/, majority of the histograms in page_load_histograms.cc have been marked as obsolete (https://codereview.chromium.org/2199933002/). That means we will soon delete all DataReductionProxy (DRP) code from page_load_histograms.cc, and the IPC call from the renderer to the browser. This very likely means that we do not need to migrate DRP IPC messages to Mojo interface. May be it will be better for you to hold off that CL for a while. My apologies for this late notification. The plan to obsolete the histograms was not on table when I first reviewed your CL.
,
Sep 8 2016
Hi, tbansal, got it and thanks a lot for the information sharing. Situation changed so we'd better just adjust with that. Thanks again for your kindly help on my CL ;-)
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a43953b70da976a0c565150cd938fa1b5d42a0c2 commit a43953b70da976a0c565150cd938fa1b5d42a0c2 Author: ryansturm <ryansturm@chromium.org> Date: Thu Sep 08 17:57:59 2016 Removing and deprecating PLT DataReductionProxy UMA DataReductionProxy has moved to reporting PLT via PageLoad.* and no longer needs the renderer based metrics. While the browser based metrics do not cover all of the use cases, the new metrics are sufficient for the analysis DRP needs moving forward. This also removes the DRP IPC completely. BUG= 643307 Review-Url: https://codereview.chromium.org/2314163003 Cr-Commit-Position: refs/heads/master@{#417337} [modify] https://crrev.com/a43953b70da976a0c565150cd938fa1b5d42a0c2/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/a43953b70da976a0c565150cd938fa1b5d42a0c2/chrome/common/BUILD.gn [modify] https://crrev.com/a43953b70da976a0c565150cd938fa1b5d42a0c2/chrome/common/DEPS [modify] https://crrev.com/a43953b70da976a0c565150cd938fa1b5d42a0c2/chrome/common/chrome_content_client.cc [modify] https://crrev.com/a43953b70da976a0c565150cd938fa1b5d42a0c2/chrome/common/chrome_content_client.h [modify] https://crrev.com/a43953b70da976a0c565150cd938fa1b5d42a0c2/chrome/renderer/BUILD.gn [modify] https://crrev.com/a43953b70da976a0c565150cd938fa1b5d42a0c2/chrome/renderer/DEPS [modify] https://crrev.com/a43953b70da976a0c565150cd938fa1b5d42a0c2/chrome/renderer/page_load_histograms.cc [modify] https://crrev.com/a43953b70da976a0c565150cd938fa1b5d42a0c2/components/data_reduction_proxy/content/browser/BUILD.gn [modify] https://crrev.com/a43953b70da976a0c565150cd938fa1b5d42a0c2/components/data_reduction_proxy/content/browser/DEPS [delete] https://crrev.com/e13510e5938155d4eb7b8a742919a11aa7f8556c/components/data_reduction_proxy/content/browser/data_reduction_proxy_message_filter.cc [delete] https://crrev.com/e13510e5938155d4eb7b8a742919a11aa7f8556c/components/data_reduction_proxy/content/browser/data_reduction_proxy_message_filter.h [delete] https://crrev.com/e13510e5938155d4eb7b8a742919a11aa7f8556c/components/data_reduction_proxy/content/browser/data_reduction_proxy_message_filter_unittest.cc [delete] https://crrev.com/e13510e5938155d4eb7b8a742919a11aa7f8556c/components/data_reduction_proxy/content/common/BUILD.gn [delete] https://crrev.com/e13510e5938155d4eb7b8a742919a11aa7f8556c/components/data_reduction_proxy/content/common/DEPS [delete] https://crrev.com/e13510e5938155d4eb7b8a742919a11aa7f8556c/components/data_reduction_proxy/content/common/data_reduction_proxy_messages.cc [delete] https://crrev.com/e13510e5938155d4eb7b8a742919a11aa7f8556c/components/data_reduction_proxy/content/common/data_reduction_proxy_messages.h [modify] https://crrev.com/a43953b70da976a0c565150cd938fa1b5d42a0c2/tools/metrics/histograms/histograms.xml
,
Sep 8 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ryansturm@chromium.org
, Sep 6 2016Status: Started (was: Assigned)