"New Printer on your network" notification doesn't go away when clicking "Don't show this again" option
Reported by
tehgor...@gmail.com,
Sep 1 2016
|
|||
Issue description
Chrome Version : 52.0.2743.116
OS Version: OS X 10.11.6
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:
What steps will reproduce the problem?
1. Install a new printer on your LAN (it was an HP Envy 4520 in this case, but it's specifically HP's "ePrint" functionality that is relevant here, apparently).
2. Launch Chrome on the Mac
3. See Chrome pop up a notification about the new printer re: Google Cloud Print
4. Click "Don't show this again" in notification
5. Notice that UI does not appear to respond to this click (notification remains, etc).
What is the expected result?
Notification should go away.
What happens instead of that?
Notification stays put.
Please provide any additional information below. Attach a screenshot if
possible.
UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36
In Chrome's advanced settings, "show notifications when new printers are detected on the network" is unchecked, which I presume means that "Don't show this again" did properly toggle the setting and then simply failed to removed the notification. Notification went away when I clicked the window's 'x' to close it.
While we're talking: it seems not okay for my web browser to sniff my LAN for new printers in order to advertise a Google service. Beyond turning off the notifications, it doesn't appear that one can fully turn this off in the settings.
Instead of fixing this UI bug, I'd encourage you to remove this functionality from Chrome, or at least make it opt-in in some form.
Thanks for your time!
--ryan.
,
Sep 2 2016
Doesn't seem Mac-specific. Can we call PrivetRemoveNotification() from PrivetNotificationDelegate::ButtonClick()? If you look at DownloadItemNotification::OnNotificationButtonClick(), for example, that notification manually dismisses itself when a button is clicked.
,
Sep 2 2016
- Happy to fix the UI issue. - One issue per bug report please. If you feel strongly about the "While we're talking:" bits, file another bug report.
,
Sep 3 2016
I'll file a separate bug with a less hostile tone for my "while we're talking" section; there are probably ways to alleviate the concern without actually shutting off the functionality. It sounds like you are all on top of the UI issue, though, so thanks for your attention! --ryan.
,
Sep 3 2016
Please reply with the new bug number once you do. Well, if you ever wonder why the chrome binary is 100 MB... you should see the kitchen sink. It's beautiful! ;-)
,
Sep 3 2016
(the separate bug is https://bugs.chromium.org/p/chromium/issues/detail?id=643883 if anyone here happens to be interested in it.)
,
Oct 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84a0c256d7371bf0bd495f6d3ac3d0157e61fa44 commit 84a0c256d7371bf0bd495f6d3ac3d0157e61fa44 Author: thestig <thestig@chromium.org> Date: Wed Oct 26 16:59:13 2016 Close privet printer notifications when clicked. BUG= 643268 Review-Url: https://codereview.chromium.org/2446043002 Cr-Commit-Position: refs/heads/master@{#427720} [modify] https://crrev.com/84a0c256d7371bf0bd495f6d3ac3d0157e61fa44/chrome/browser/printing/cloud_print/privet_notifications.cc [modify] https://crrev.com/84a0c256d7371bf0bd495f6d3ac3d0157e61fa44/chrome/browser/printing/cloud_print/privet_notifications.h [modify] https://crrev.com/84a0c256d7371bf0bd495f6d3ac3d0157e61fa44/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc
,
Oct 26 2016
,
Jan 29 2018
It's back again -- just started happening on macOS Sierra (10.12.6) - |
|||
►
Sign in to add a comment |
|||
Comment 1 by mmenke@chromium.org
, Sep 1 2016