New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643257 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Unable to link to tests from sheriff-o-matic

Project Member Reported by martiniss@chromium.org, Sep 1 2016

Issue description

Sheriff-o-matic displays the tests which fail for a given test suite in the SOM UI. For example (from https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/3932), for the cc_unittests suite with these test failures:
OcclusionTrackerTestUnoccludedSurfaceQueryImplThreadOpaqueLayers.RunTest
SurfaceAggregatorValidSurfaceTest.OpacityCopied
LayerTreeImplTest.HitTestingSameSortingContextChildWins
ScaledScrollbarLayerTestResourceCreation.ScaledResourceUpload
TreeSynchronizerTest.SyncMaskReplicaAndReplicaMaskLayers
RasterSourceTest.AnalyzeIsSolidUnscaled
SchedulerTest.SynchronousCompositorPrepareTilesOnDraw
 
SOM displays all the above test in the UI. It has links to the test results server, as well as to code search.

The codesearch links are just blindly constructed with the entirety of the test in the search query; e.g., for SurfaceManagerOrderingParamTestInstantiation/SurfaceManagerOrderingParamTest.Ordering/6 we give the URL https://cs.chromium.org/search/?q=SurfaceManagerOrderingParamTestInstantiation/SurfaceManagerOrderingParamTest.Ordering/6

This URL doesn't work at all, because of the way the test is constructed in the C++ code. In fact, to find this test at all, you have to just search for "SurfaceManagerOrderingParamTestInstantiation".

Ideally, SOM would be able to link to the exact line declaring the test which failed. I don't know how hard this would be, or how standardized the test names are, and I have the impression there are some C++ templating/parameterization features being used which would make this hard.

I'm not sure what the next steps to fully solve this problem are; from the sheriff-o-matic side, if I see something in the form foo.bar/1, SOM will link to codesearch with "foo bar" as the query. 
 
Labels: Milestone-PostSoMNG
Labels: -Milestone-PostSoMNG Milestone-UX
Cc: zhangtiff@chromium.org
Owner: ----
Status: Fixed (was: Started)
I'm not sure if I actually made this work, or not....

Based on a cursory glance at SOM right now, I think it does. Marking as fixed.

Sign in to add a comment