New issue
Advanced search Search tips

Issue 643237 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 568949



Sign in to add a comment

v8 coverage trybot can't deal with dependant CLs

Project Member Reported by jochen@chromium.org, Sep 1 2016

Issue description

Blocking: 568949
Cc: -machenb...@chromium.org
Labels: Pri-2 Type-Feature
Owner: machenb...@chromium.org
Status: Assigned (was: Untriaged)
It can't. I never got to providing logic for that.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ca02f065486627347da49805bd2638bedf5bea34

commit ca02f065486627347da49805bd2638bedf5bea34
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Apr 07 08:03:51 2017

V8: Make sanitizer-coverage bot gerrit aware

This calculates the correct patch base for gerrit patches, including dependent patches.

This also uploads the data to a separate Google Storage location.

Bug:  685318 , 643237
Change-Id: Id9c563698c50d67d7e5d780adef61c42a3079f6a
Reviewed-on: https://chromium-review.googlesource.com/469650
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Emma Soederberg <emso@google.com>

[modify] https://crrev.com/ca02f065486627347da49805bd2638bedf5bea34/scripts/slave/recipe_modules/v8/api.py
[modify] https://crrev.com/ca02f065486627347da49805bd2638bedf5bea34/scripts/slave/recipe_modules/v8/test_api.py
[modify] https://crrev.com/ca02f065486627347da49805bd2638bedf5bea34/scripts/slave/recipe_modules/v8/testing.py
[modify] https://crrev.com/ca02f065486627347da49805bd2638bedf5bea34/scripts/slave/recipes/v8.py
[add] https://crrev.com/ca02f065486627347da49805bd2638bedf5bea34/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel_gerrit.json
[modify] https://crrev.com/ca02f065486627347da49805bd2638bedf5bea34/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_gerrit.json

Sign in to add a comment