New issue
Advanced search Search tips

Issue 643235 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

New Clang warning -Winstantiation-after-specialization

Project Member Reported by h...@chromium.org, Sep 1 2016

Issue description

After Clang r280308:

FAILED: obj/media/media/decoder_stream_traits.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/media/media/decoder_stream_traits.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=280367 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_PULSEAUDIO -DDLOPEN_PULSEAUDIO -DMEDIA_IMPLEMENTATION -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DBORINGSSL_SHARED_LIBRARY -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -I../../media -I../.. -Igen -I../../third_party/libwebm/source -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/khronos -I../../gpu -I../../third_party/opus/src/include -I../../third_party/ffmpeg/chromium/config/Chromium/linux/x64 -I../../third_party/ffmpeg -I../../third_party/libvpx/source/libvpx -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/nss -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/nspr -I../../third_party/boringssl/src/include -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/mesa/src/include -I../../third_party/libyuv -I../../third_party/libyuv/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/b/c/b/ClangToTLinux/src=. -pthread -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -O2 -fno-ident -fdata-sections -ffunction-sections -g2 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wno-unused-function -Wno-header-guard -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c ../../media/filters/decoder_stream_traits.cc -o obj/media/media/decoder_stream_traits.o
../../media/filters/decoder_stream_traits.cc:106:16: error: explicit instantiation of 'DecoderStreamTraits<media::DemuxerStream::Type::VIDEO>' that occurs after an explicit specialization has no effect [-Werror,-Winstantiation-after-specialization]
template class DecoderStreamTraits<DemuxerStream::VIDEO>;
               ^
../../media/filters/decoder_stream_traits.h:63:20: note: previous template specialization is here
class MEDIA_EXPORT DecoderStreamTraits<DemuxerStream::VIDEO> {
                   ^
../../media/filters/decoder_stream_traits.cc:107:16: error: explicit instantiation of 'DecoderStreamTraits<media::DemuxerStream::Type::AUDIO>' that occurs after an explicit specialization has no effect [-Werror,-Winstantiation-after-specialization]
template class DecoderStreamTraits<DemuxerStream::AUDIO>;
               ^
../../media/filters/decoder_stream_traits.h:29:20: note: previous template specialization is here
class MEDIA_EXPORT DecoderStreamTraits<DemuxerStream::AUDIO> {
 

Comment 1 by h...@chromium.org, Sep 1 2016

If it's just these two, maybe the quickest thing is just to fix them. I'll sync up.

Comment 2 by h...@chromium.org, Sep 1 2016

Status: Started (was: Available)
https://codereview.chromium.org/2305683002/
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36676ab3858596d6fa27ffeddd6055f44a8b38cd

commit 36676ab3858596d6fa27ffeddd6055f44a8b38cd
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Sep 01 18:11:30 2016

DecoderStreamTraits: remove redundant explicit instantiation definitions

The template was already explicitly specialized with these types in the
header, so the instantiations here have no effect, and recent Clang
versions warn about it.

BUG= 643235 
R=thakis@chromium.org
TBR=chcunningham

Review URL: https://codereview.chromium.org/2305683002 .

Cr-Commit-Position: refs/heads/master@{#415999}

[modify] https://crrev.com/36676ab3858596d6fa27ffeddd6055f44a8b38cd/media/filters/decoder_stream_traits.cc

Comment 4 by h...@chromium.org, Sep 1 2016

Status: Fixed (was: Started)
I completed a full build on Linux with the patch above. Let's mark this fixed optimistically.

Sign in to add a comment