New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643232 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 583155



Sign in to add a comment

Add section for Artifex Copyright to chrome://os-credits page

Project Member Reported by weifangsun@chromium.org, Sep 1 2016

Issue description

As part of the Ghostscript license with Artifex, we need to add the below copyright string to the chrome://credits page -


Portions Copyright (c) 1993/2016 Artifex Software Inc.
This software is based in part on the work of the Independent JPEG Group.
Portions Copyright (c) 2001 URW++
Portions Copyright (c) 2005 LuraTech Imaging GmbH.
All Rights Reserved.
 
Components: Internals>Printing>CUPS

Comment 2 by adlr@chromium.org, Sep 1 2016

Cc: -adlr@chromium.org weifangsun@chromium.org
Owner: adlr@chromium.org
I'll take this
Cc: adlr@chromium.org
Owner: x...@chromium.org
Re-assigning to Daisy as Adlr is going OOO.
Owner: ----

Comment 5 by adlr@chromium.org, Sep 16 2016

This should happen for Chrome OS, but not Chromium OS.

Comment 6 by adlr@chromium.org, Sep 16 2016

Also, url is actually chrome://os-credits

Comment 7 by adlr@chromium.org, Sep 16 2016

Btw, the licenses are generated by (cros checkout root)/chromite/licensing/licenses

One option is to hack the ebuild to give different license text on Chrome OS builds. Another option is to edit that script to have an override for Ghostscript, which again only applies to Chrome OS builds.
Owner: justincarlson@chromium.org
Summary: Add section for Artifex Copyright to chrome://os-credits page (was: Add section for Artifex Copyright to chrome://credits page)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e7b304377934d86c2cddfd37e3f56498fa1a8b82

commit e7b304377934d86c2cddfd37e3f56498fa1a8b82
Author: Justin Carlson <justincarlson@chromium.org>
Date: Fri Sep 30 19:39:35 2016

Update ghostscript-gpl license.

Now we supply the artifex commercial license when building ChromeOS, but
use the OSS licenses when we're building an OSS release.

Revbump ghostscript ebuild because presubmit isn't happy otherwise.

BUG= chromium:643232 
TEST="./licenses --debug --board x86-alex -p
app-text/ghostscript-gpl-9.19-r5 --generate -o test.html" shows the
appropriate licenses depending on whether or not the package was built
with the 'internal' USE flag.

Change-Id: I7afa59160733385a4b7486b081df2d4ed03d2bb1
Reviewed-on: https://chromium-review.googlesource.com/391161
Commit-Ready: Justin Carlson <justincarlson@chromium.org>
Tested-by: Justin Carlson <justincarlson@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e7b304377934d86c2cddfd37e3f56498fa1a8b82/app-text/ghostscript-gpl/ghostscript-gpl-9.19.ebuild
[add] https://crrev.com/e7b304377934d86c2cddfd37e3f56498fa1a8b82/licenses/LICENSE.artifex_commercial
[modify] https://crrev.com/e7b304377934d86c2cddfd37e3f56498fa1a8b82/profiles/license_groups
[rename] https://crrev.com/e7b304377934d86c2cddfd37e3f56498fa1a8b82/app-text/ghostscript-gpl/ghostscript-gpl-9.19-r6.ebuild

Comment 11 by adlr@chromium.org, Oct 7 2016

done?
Unless I've missed something, yes.
Status: Fixed (was: Assigned)

Comment 14 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 15 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 16 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 17 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 19 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment