New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643223 link

Starred by 3 users

DisplayLink docks may not display properly on 2560x1440 DP displays

Project Member Reported by bhthompson@google.com, Sep 1 2016

Issue description

DisplayLink docks may not display properly on 2560x1440 DP displays

 
This bug is to serve as a merge request point. Since we just branched R54, we should be able to merge this fix back.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 2 2016

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/f6751cbd9b2c68c7e3b5e5fa5be5878bfceb15f1

commit f6751cbd9b2c68c7e3b5e5fa5be5878bfceb15f1
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Fri Aug 26 11:46:51 2016

drm/evdi: Force restore mode setting when connection is established

When userspace application is disconnecting from evdi device then
it forgets used mode. However from drm point of view
mode has not changed. When application reconnects the
crtc mode_set function is not called so application is not notified
about current mode.

Invoking drm_helper_resume_force_mode will trigger evdi_crtc_mode_set
which will effect in proper configuration.

BUG= chromium:643223 
TEST=Build and tested on cyan

Change-Id: I684f0069fc4a361cce503390254d9bc339dc00ba
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/378957
Commit-Ready: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/f6751cbd9b2c68c7e3b5e5fa5be5878bfceb15f1/drivers/gpu/drm/evdi/evdi_painter.c

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 2 2016

Labels: merge-merged-chromeos-3.10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ceb8d49d0c9e9be8f01c7d1ff6d6e14dd935bb04

commit ceb8d49d0c9e9be8f01c7d1ff6d6e14dd935bb04
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Fri Aug 26 11:46:51 2016

drm/evdi: Force restore mode setting when connection is established

When userspace application is disconnecting from evdi device then
it forgets used mode. However from drm point of view
mode has not changed. When application reconnects the
crtc mode_set function is not called so application is not notified
about current mode.

Invoking drm_helper_resume_force_mode will trigger evdi_crtc_mode_set
which will effect in proper configuration.

BUG= chromium:643223 
TEST=Build and tested on quawks

Change-Id: I684f0069fc4a361cce503390254d9bc339dc00ba
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/378996
Commit-Ready: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[modify] https://crrev.com/ceb8d49d0c9e9be8f01c7d1ff6d6e14dd935bb04/drivers/gpu/drm/evdi/evdi_painter.c

Project Member

Comment 4 by sheriffbot@chromium.org, Sep 2 2016

Labels: Hotlist-Google
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 2 2016

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/8d79896a8508d6b516c6857c8eeb975d6977d8b8

commit 8d79896a8508d6b516c6857c8eeb975d6977d8b8
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Fri Aug 26 11:46:51 2016

drm/evdi: Force restore mode setting when connection is established

When userspace application is disconnecting from evdi device then
it forgets used mode. However from drm point of view
mode has not changed. When application reconnects the
crtc mode_set function is not called so application is not notified
about current mode.

Invoking drm_helper_resume_force_mode will trigger evdi_crtc_mode_set
which will effect in proper configuration.

BUG= chromium:643223 
TEST=Build and tested on lulu

Change-Id: I684f0069fc4a361cce503390254d9bc339dc00ba
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/379057
Commit-Ready: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[modify] https://crrev.com/8d79896a8508d6b516c6857c8eeb975d6977d8b8/drivers/gpu/drm/evdi/evdi_painter.c

Labels: Merge-Request-54

Comment 7 by dimu@chromium.org, Sep 3 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Owner: bhthompson@google.com
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 6 2016

Labels: merge-merged-release-R54-8743.B-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/a53cd2c69ed58a357faeeb8aa0795787fca4efae

commit a53cd2c69ed58a357faeeb8aa0795787fca4efae
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Fri Aug 26 11:46:51 2016

drm/evdi: Force restore mode setting when connection is established

When userspace application is disconnecting from evdi device then
it forgets used mode. However from drm point of view
mode has not changed. When application reconnects the
crtc mode_set function is not called so application is not notified
about current mode.

Invoking drm_helper_resume_force_mode will trigger evdi_crtc_mode_set
which will effect in proper configuration.

BUG= chromium:643223 
TEST=Build and tested on lulu

Change-Id: I684f0069fc4a361cce503390254d9bc339dc00ba
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/379057
Commit-Ready: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
(cherry picked from commit 8d79896a8508d6b516c6857c8eeb975d6977d8b8)
Reviewed-on: https://chromium-review.googlesource.com/381081
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/a53cd2c69ed58a357faeeb8aa0795787fca4efae/drivers/gpu/drm/evdi/evdi_painter.c

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 6 2016

Labels: merge-merged-release-R54-8743.B-chromeos-3.10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/f18f274c830f79a75e647e7fe6fb1164356271dc

commit f18f274c830f79a75e647e7fe6fb1164356271dc
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Fri Aug 26 11:46:51 2016

drm/evdi: Force restore mode setting when connection is established

When userspace application is disconnecting from evdi device then
it forgets used mode. However from drm point of view
mode has not changed. When application reconnects the
crtc mode_set function is not called so application is not notified
about current mode.

Invoking drm_helper_resume_force_mode will trigger evdi_crtc_mode_set
which will effect in proper configuration.

BUG= chromium:643223 
TEST=Build and tested on quawks

Change-Id: I684f0069fc4a361cce503390254d9bc339dc00ba
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/378996
Commit-Ready: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
(cherry picked from commit ceb8d49d0c9e9be8f01c7d1ff6d6e14dd935bb04)
Reviewed-on: https://chromium-review.googlesource.com/381080
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/f18f274c830f79a75e647e7fe6fb1164356271dc/drivers/gpu/drm/evdi/evdi_painter.c

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 6 2016

Labels: merge-merged-release-R54-8743.B-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/37cb5b3bee9b5c85220b2ed83db48ed0e6898812

commit 37cb5b3bee9b5c85220b2ed83db48ed0e6898812
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Fri Aug 26 11:46:51 2016

drm/evdi: Force restore mode setting when connection is established

When userspace application is disconnecting from evdi device then
it forgets used mode. However from drm point of view
mode has not changed. When application reconnects the
crtc mode_set function is not called so application is not notified
about current mode.

Invoking drm_helper_resume_force_mode will trigger evdi_crtc_mode_set
which will effect in proper configuration.

BUG= chromium:643223 
TEST=Build and tested on cyan

Change-Id: I684f0069fc4a361cce503390254d9bc339dc00ba
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/378957
Commit-Ready: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
(cherry picked from commit f6751cbd9b2c68c7e3b5e5fa5be5878bfceb15f1)
Reviewed-on: https://chromium-review.googlesource.com/381082
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/37cb5b3bee9b5c85220b2ed83db48ed0e6898812/drivers/gpu/drm/evdi/evdi_painter.c

Project Member

Comment 11 by sheriffbot@chromium.org, Sep 7 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-54
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 9 2016

Labels: merge-merged-chromeos-3.8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/a5874ccb443aa03d7840223fb6292e0ccd1bdeb2

commit a5874ccb443aa03d7840223fb6292e0ccd1bdeb2
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Fri Aug 26 11:46:51 2016

drm/evdi: Force restore mode setting when connection is established

When userspace application is disconnecting from evdi device then
it forgets used mode. However from drm point of view
mode has not changed. When application reconnects the
crtc mode_set function is not called so application is not notified
about current mode.

Invoking drm_helper_resume_force_mode will trigger evdi_crtc_mode_set
which will effect in proper configuration.

BUG= chromium:643223 
TEST=Build and tested on link

Change-Id: I9f67937402bf758aca4157892667035af15e36b4
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/378916
Commit-Ready: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Dawid Kurek <dawid.kurek@displaylink.com>
Reviewed-by: Łukasz Spintzyk <lukasz.spintzyk@displaylink.com>

[modify] https://crrev.com/a5874ccb443aa03d7840223fb6292e0ccd1bdeb2/drivers/gpu/drm/evdi/evdi_painter.c

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 9 2016

Labels: merge-merged-release-R54-8743.B-chromeos-3.8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/7f3cfab1aaad95632612e7e99e7067987be752bc

commit 7f3cfab1aaad95632612e7e99e7067987be752bc
Author: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Date: Fri Aug 26 11:46:51 2016

drm/evdi: Force restore mode setting when connection is established

When userspace application is disconnecting from evdi device then
it forgets used mode. However from drm point of view
mode has not changed. When application reconnects the
crtc mode_set function is not called so application is not notified
about current mode.

Invoking drm_helper_resume_force_mode will trigger evdi_crtc_mode_set
which will effect in proper configuration.

BUG= chromium:643223 
TEST=Build and tested on link

Change-Id: I9f67937402bf758aca4157892667035af15e36b4
Signed-off-by: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Reviewed-on: https://chromium-review.googlesource.com/381593
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/7f3cfab1aaad95632612e7e99e7067987be752bc/drivers/gpu/drm/evdi/evdi_painter.c

Status: Fixed (was: Untriaged)

Comment 16 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 17 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 18 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 20 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment