Fix ARC lowmemory management regression |
||||||
Issue descriptionThis is the public version of b/30193036. ARC lowmemory management broke after the introduction of user namespaces, and was fixed by https://codereview.chromium.org/2247433002 . We need to merge that in M-54.
,
Sep 1 2016
Btw, for the merge requirements: This particular change was merged in https://crrev.com/2af9aaceb40213973d0c989de413d0505afefbce and has been live in at least one canary (CrOS 8748.0.0, Chrome 55.0.2841.0) https://chromium.googlesource.com/chromium/src/+log/54.0.2837.0..55.0.2841.0?pretty=fuller&n=10000
,
Sep 1 2016
,
Sep 2 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce6382cfe05ce556f5d1f592dee6875e87a7d343 commit ce6382cfe05ce556f5d1f592dee6875e87a7d343 Author: Luis Hector Chavez <lhchavez@google.com> Date: Fri Sep 02 15:17:52 2016 [Merge to M54] TabManager: Set OOM scores via a new debugd interface on ChromeOS. Setting OOM scores generally requires root permission. In the past it's done 1. For Chrome processes: via a SUID binary chrome-sandbox. 2. For Andorid processes: Send scores to Android via IPC. Android handles the rest. Now a new method is added to debugd dbus interface on ChromeOS to handle OOM score settings. https://chromium-review.googlesource.com/#/c/366154/ So we can set OOM score settings in the unified way on ChromeOS. BUG= 643212 BUG=b:30193036 TEST=minnie Review-Url: https://codereview.chromium.org/2247433002 Cr-Commit-Position: refs/heads/master@{#414693} (cherry picked from commit 2af9aaceb40213973d0c989de413d0505afefbce) TBR=stevenjb,hashimoto,georgesak Review URL: https://codereview.chromium.org/2304173002 . Cr-Commit-Position: refs/branch-heads/2840@{#123} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/ce6382cfe05ce556f5d1f592dee6875e87a7d343/chrome/browser/memory/tab_manager_delegate_chromeos.cc [modify] https://crrev.com/ce6382cfe05ce556f5d1f592dee6875e87a7d343/chrome/browser/memory/tab_manager_delegate_chromeos.h [modify] https://crrev.com/ce6382cfe05ce556f5d1f592dee6875e87a7d343/chrome/browser/memory/tab_manager_delegate_chromeos_unittest.cc [modify] https://crrev.com/ce6382cfe05ce556f5d1f592dee6875e87a7d343/chromeos/dbus/debug_daemon_client.cc [modify] https://crrev.com/ce6382cfe05ce556f5d1f592dee6875e87a7d343/chromeos/dbus/debug_daemon_client.h [modify] https://crrev.com/ce6382cfe05ce556f5d1f592dee6875e87a7d343/chromeos/dbus/fake_debug_daemon_client.cc [modify] https://crrev.com/ce6382cfe05ce556f5d1f592dee6875e87a7d343/chromeos/dbus/fake_debug_daemon_client.h
,
Sep 2 2016
,
Oct 18 2016
Will test and comment on the internal bug
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce6382cfe05ce556f5d1f592dee6875e87a7d343 commit ce6382cfe05ce556f5d1f592dee6875e87a7d343 Author: Luis Hector Chavez <lhchavez@google.com> Date: Fri Sep 02 15:17:52 2016 [Merge to M54] TabManager: Set OOM scores via a new debugd interface on ChromeOS. Setting OOM scores generally requires root permission. In the past it's done 1. For Chrome processes: via a SUID binary chrome-sandbox. 2. For Andorid processes: Send scores to Android via IPC. Android handles the rest. Now a new method is added to debugd dbus interface on ChromeOS to handle OOM score settings. https://chromium-review.googlesource.com/#/c/366154/ So we can set OOM score settings in the unified way on ChromeOS. BUG= 643212 BUG=b:30193036 TEST=minnie Review-Url: https://codereview.chromium.org/2247433002 Cr-Commit-Position: refs/heads/master@{#414693} (cherry picked from commit 2af9aaceb40213973d0c989de413d0505afefbce) TBR=stevenjb,hashimoto,georgesak Review URL: https://codereview.chromium.org/2304173002 . Cr-Commit-Position: refs/branch-heads/2840@{#123} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/ce6382cfe05ce556f5d1f592dee6875e87a7d343/chrome/browser/memory/tab_manager_delegate_chromeos.cc [modify] https://crrev.com/ce6382cfe05ce556f5d1f592dee6875e87a7d343/chrome/browser/memory/tab_manager_delegate_chromeos.h [modify] https://crrev.com/ce6382cfe05ce556f5d1f592dee6875e87a7d343/chrome/browser/memory/tab_manager_delegate_chromeos_unittest.cc [modify] https://crrev.com/ce6382cfe05ce556f5d1f592dee6875e87a7d343/chromeos/dbus/debug_daemon_client.cc [modify] https://crrev.com/ce6382cfe05ce556f5d1f592dee6875e87a7d343/chromeos/dbus/debug_daemon_client.h [modify] https://crrev.com/ce6382cfe05ce556f5d1f592dee6875e87a7d343/chromeos/dbus/fake_debug_daemon_client.cc [modify] https://crrev.com/ce6382cfe05ce556f5d1f592dee6875e87a7d343/chromeos/dbus/fake_debug_daemon_client.h |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bhthompson@google.com
, Sep 1 2016