New issue
Advanced search Search tips

Issue 643199 link

Starred by 2 users
Status: Duplicate
Merged: issue 643282
Owner:
khushals...@chromium.org
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Flaky tests on Android bots in content_browsertests

Project Member Reported by mvanouwe...@chromium.org, Sep 1 2016 
The following tests (and probably others) became flaky in the past 24 hours or so:

BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored
DownloadContentTest.ResumeRestoredDownload_ShortFile
DownloadContentTest.ResumeRestoredDownload_EtagMismatch
DragDownloadFileTest.DragDownloadFileTest_Complete
DragDownloadFileTest.DragDownloadFileTest_NetError
TracingControllerTest.NotWhitelistedMetadataStripped
UtilityProcessMojoClientBrowserTest.CallService
UtilityProcessMojoClientBrowserTest.ConnectionError
UtilityProcessHostImplBrowserTest.LaunchProcess


The common issue seems to be a DCHECK:
[FATAL:context_provider_factory_impl_android.cc(181)] Check failed: !in_shutdown_. The factory is shutting down, can't handle new requests

The DCHECK was introduced in https://codereview.chromium.org/2250473005

Comment 1 by kbr@chromium.org, Sep 1 2016

Labels: -Pri-2 Pri-1
Mergedinto: 643282
Status: Duplicate (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f279cb2138fcfc9eddd37d99440c55bbb783f8b3

commit f279cb2138fcfc9eddd37d99440c55bbb783f8b3
Author: khushalsagar <khushalsagar@chromium.org>
Date: Thu Sep 01 21:34:17 2016

Revert "Revert of content: Fix Context creation logic in ContextProviderFactoryImpl. (patchset #10 id:180001 of https://codereview.chromium.org/2250473005/ )"

This reverts commit 258820db7532d4c411c2000c0907c6cb35399c03.

TBR = dtrainor
BUG= 643199 ,  643282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2297273004
Cr-Commit-Position: refs/heads/master@{#416062}

[modify] https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3/content/browser/browser_main_loop.cc
[modify] https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3/content/browser/renderer_host/context_provider_factory_impl_android.cc
[modify] https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3/content/browser/renderer_host/context_provider_factory_impl_android.h
[modify] https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3/content/content_tests.gypi
[modify] https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3/content/public/test/test_renderer_host.cc
[modify] https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3/content/public/test/test_renderer_host.h
[add] https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3/content/test/mock_gpu_channel_establish_factory.cc
[add] https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3/content/test/mock_gpu_channel_establish_factory.h
[modify] https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3/content/test/test_render_view_host.cc
[modify] https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3/ui/android/context_provider_factory.h
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138

commit 53e4ec7811a9d9ed46e1d4e13acfc49134b8b138
Author: khushalsagar <khushalsagar@chromium.org>
Date: Fri Sep 02 01:22:57 2016

Revert of Revert "Revert of content: Fix Context creation logic in ContextProviderFactoryImpl. (patchset #10 … (patchset #2 id:20001 of https://codereview.chromium.org/2297273004/ )

Reason for revert:
The test is still failing.

Original issue's description:
> Revert "Revert of content: Fix Context creation logic in ContextProviderFactoryImpl. (patchset #10 id:180001 of https://codereview.chromium.org/2250473005/ )"
>
> This reverts commit 258820db7532d4c411c2000c0907c6cb35399c03.
>
> TBR = dtrainor
> BUG= 643199 ,  643282 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3
> Cr-Commit-Position: refs/heads/master@{#416062}

TBR=piman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 643199 ,  643282 

Review-Url: https://codereview.chromium.org/2299333003
Cr-Commit-Position: refs/heads/master@{#416154}

[modify] https://crrev.com/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138/content/browser/browser_main_loop.cc
[modify] https://crrev.com/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138/content/browser/renderer_host/context_provider_factory_impl_android.cc
[modify] https://crrev.com/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138/content/browser/renderer_host/context_provider_factory_impl_android.h
[modify] https://crrev.com/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138/content/content_tests.gypi
[modify] https://crrev.com/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138/content/public/test/test_renderer_host.cc
[modify] https://crrev.com/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138/content/public/test/test_renderer_host.h
[delete] https://crrev.com/a56017921d536b91426ad9ec7b5be9207c6eac6c/content/test/mock_gpu_channel_establish_factory.cc
[delete] https://crrev.com/a56017921d536b91426ad9ec7b5be9207c6eac6c/content/test/mock_gpu_channel_establish_factory.h
[modify] https://crrev.com/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138/content/test/test_render_view_host.cc
[modify] https://crrev.com/53e4ec7811a9d9ed46e1d4e13acfc49134b8b138/ui/android/context_provider_factory.h

Comment 4 by agrieve@chromium.org, Sep 2 2016 

Issue 643491 has been merged into this issue.
►

Sign in to add a comment