New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643194 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

id >= firstCSSProperty && id <= lastUnresolvedCSSProperty

Project Member Reported by ClusterFuzz, Sep 1 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5967172285497344

Fuzzer: attekett_dom_fuzzer
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  id >= firstCSSProperty && id <= lastUnresolvedCSSProperty
  blink::getPropertyName
  blink::V8CSSStyleDeclaration::namedPropertySetterCustom
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_chrome&range=415049:415582

Minimized Testcase (0.13 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv94w4yl_KEFXXuoe-Qpzv2i6K6G5GR0dMwnHyf83sI7LlLOGpnHJ-r07_JQCsJz2oZqrIiN5ghU2yo_R9ng8Sqq8fpAKY4U2PjkFVZYV8XzHydX8wm3aMvUEVIY70TzjFg1OMqBsSKzw_K7X3nMw1AMUxtt3tA?testcase_id=5967172285497344
   bug 399941 .html<script> 
var test6=document.body.appendChild(document.createElement("param"))
test6.style['--tab-color']='';
</script>


Issue manually filed by: msrchandra

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Tools>Test>FindIt>NoResult
Labels: -Type-Bug findit-wrong Te-Logged Type-Bug-Regression
Owner: meade@chromium.org
Status: Assigned (was: Untriaged)
Unable to find the suspect using CL and find it.
Using Code Search for the file "V8CSSStyleDeclarationCustom.cpp" assigning it to the concern owner.

@meade -- -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to the concern owner.
Thank You.

Comment 2 by meade@chromium.org, Sep 2 2016

Cc: meade@chromium.org
Owner: timloh@chromium.org
Hey Tim, you've been working on custom property stuff recently, any ideas on what could be causing this?

There's a suspicious // TODO(leviw): This API doesn't support custom properties. here too.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp?q=V8CSSStyleDeclarationCustom&sq=package:chromium&l=220
I probably broke it in https://codereview.chromium.org/2288633002, will have a look shortly.
 Issue 642821  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dcfd301c47f8510004c295f14f348fd601e2c4e

commit 0dcfd301c47f8510004c295f14f348fd601e2c4e
Author: timloh <timloh@chromium.org>
Date: Mon Sep 05 06:06:17 2016

Fix assertion when trying to set custom properties as named properties

This patch fixes a bug where trying to access a custom property as a
named property causes an assertion (e.g. e.style['--foo'] = 'a').
None of the named-property handling code on CSSStyleDeclaration should
support custom properties (we should actually use attributes instead of
named properties, crbug.com/628785, but that's another issue).

The added test already passes in Firefox.

BUG= 643194 

Review-Url: https://codereview.chromium.org/2308373002
Cr-Commit-Position: refs/heads/master@{#416502}

[add] https://crrev.com/0dcfd301c47f8510004c295f14f348fd601e2c4e/third_party/WebKit/LayoutTests/fast/css/variables/accessing-variable-as-named-property.html
[modify] https://crrev.com/0dcfd301c47f8510004c295f14f348fd601e2c4e/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

Project Member

Comment 6 by sheriffbot@chromium.org, Sep 5 2016

Labels: reward-topanel
The older reward-topanel  issue 642821  has been merged into this one. Please manually review this issue to see if the duplicate is potentially eligible for a reward.


Cc: mummare...@chromium.org timloh@chromium.org
 Issue 643829  has been merged into this issue.
Project Member

Comment 8 by ClusterFuzz, Sep 6 2016

ClusterFuzz has detected this issue as fixed in range 416466:416526.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5967172285497344

Fuzzer: attekett_dom_fuzzer
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  id >= firstCSSProperty && id <= lastUnresolvedCSSProperty
  blink::getPropertyName
  blink::V8CSSStyleDeclaration::namedPropertySetterCustom
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_chrome&range=415049:415582
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_chrome&range=416466:416526

Minimized Testcase (0.13 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv94w4yl_KEFXXuoe-Qpzv2i6K6G5GR0dMwnHyf83sI7LlLOGpnHJ-r07_JQCsJz2oZqrIiN5ghU2yo_R9ng8Sqq8fpAKY4U2PjkFVZYV8XzHydX8wm3aMvUEVIY70TzjFg1OMqBsSKzw_K7X3nMw1AMUxtt3tA?testcase_id=5967172285497344
   bug 399941 .html<script> 
var test6=document.body.appendChild(document.createElement("param"))
test6.style['--tab-color']='';
</script>


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Status: Fixed (was: Assigned)
 Issue 644149  has been merged into this issue.
 Issue 643186  has been merged into this issue.
Components: -Tools>Test>FindIt>NoResult
Labels: -reward-topanel
Project Member

Comment 14 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment