Tests failing on N in chrome.browser.notifications due to null largeIcon |
||
Issue descriptionVersion: Tip of tree OS: Android N What steps will reproduce the problem? (1) Run chrome_public_test_apk(_incremental) tests with --test-filter "*org.chromium.chrome.browser.notifications.*" on an N device locally What is the expected output? All tests passing What do you see instead? 6 tests consistently fail: C 142.313s Main [ FAILED ] org.chromium.chrome.browser.notifications.CustomNotificationBuilderTest#testPaintIcons 171 C 142.313s Main [ FAILED ] org.chromium.chrome.browser.notifications.CustomNotificationBuilderTest#testSetAll 83 C 142.313s Main [ FAILED ] org.chromium.chrome.browser.notifications.NotificationPlatformBridgeTest#testDefaultNotificationProperties 70 C 142.313s Main [ FAILED ] org.chromium.chrome.browser.notifications.NotificationPlatformBridgeTest#testShowNotificationWithIcon 195 C 142.313s Main [ FAILED ] org.chromium.chrome.browser.notifications.NotificationPlatformBridgeTest#testShowNotificationWithoutIcon 216 C 142.313s Main [ FAILED ] org.chromium.chrome.browser.notifications.StandardNotificationBuilderTest#testSetAll 92 They all fail because of the same assertion: assertNotNull(notification.largeIcon); johnme@ got the same test failures on a local N device
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edcfa0258d501c3b93e0bbc00dd72f53380940bb commit edcfa0258d501c3b93e0bbc00dd72f53380940bb Author: awdf <awdf@google.com> Date: Tue Sep 06 09:28:12 2016 Fixup tests for Android N in chrome.browser.notifications No longer need to @SuppressLint in any of these files :) BUG= 643182 , 528076 , 501900 Review-Url: https://codereview.chromium.org/2303373002 Cr-Commit-Position: refs/heads/master@{#416611} [modify] https://crrev.com/edcfa0258d501c3b93e0bbc00dd72f53380940bb/chrome/android/java_sources.gni [modify] https://crrev.com/edcfa0258d501c3b93e0bbc00dd72f53380940bb/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilderTest.java [modify] https://crrev.com/edcfa0258d501c3b93e0bbc00dd72f53380940bb/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java [add] https://crrev.com/edcfa0258d501c3b93e0bbc00dd72f53380940bb/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationTestUtil.java [modify] https://crrev.com/edcfa0258d501c3b93e0bbc00dd72f53380940bb/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java
,
Sep 7 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by awdf@chromium.org
, Sep 1 2016