Browser watcher functionality should live within the crashpad handler process |
||||
Issue description- As of https://crrev.com/412883 the browser watcher is no longer launched. - It provides useful stability telemetry but should not cost and additional process. The functionality should live within the crashpad handler Details: - could go in chrome_exe_main_win.cc or crash_reporter::RunAsCrashpadHandler() depending on whether functionality needed in setup - the watcher is in a standalone DLL, and all it needs is a thread that calls on an export. It does require a handle to the parent process in order to be non-blocking and free of race. CP doesn't yet pass such a handle, see https://bugs.chromium.org/p/chromium/issues/detail?id=567850
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3fbf2397585ee009dd5c1b5e5f32254e5a5e360c commit 3fbf2397585ee009dd5c1b5e5f32254e5a5e360c Author: manzagop <manzagop@chromium.org> Date: Thu Sep 01 17:58:32 2016 Restore the chrome watcher pending relocation BUG=643176 Review-Url: https://codereview.chromium.org/2306613003 Cr-Commit-Position: refs/heads/master@{#415994} [modify] https://crrev.com/3fbf2397585ee009dd5c1b5e5f32254e5a5e360c/chrome/app/main_dll_loader_win.cc
,
Jun 30 2017
,
Jul 2
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 31
Assigning to brucedawson@ for further triage and assignment. |
||||
►
Sign in to add a comment |
||||
Comment 1 by manzagop@chromium.org
, Sep 1 2016