Recently, we implemented recipe_modules/goma for buildbot. https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/goma/api.py pdfium buildbots are not using goma now. Let me introduce goma module for the buildbots. goma module makes it easy to setup goma related steps. https://build.chromium.org/p/tryserver.client.pdfium/console https://build.chromium.org/p/client.pdfium/console
PDFium builds are usually pretty fast, so we have not bothered with goma, but if you are offering to enable goma, then please do. :)
OK. I'll introduce goma for PDFium buildbots. year, average build time is a few minutes or smaller. goma will improve the slowest compile time. https://build.chromium.org/p/tryserver.client.pdfium/builders/linux/builds/1911
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/c08b45f208a60595ca9f1c0369fca4c0f9cd722f commit c08b45f208a60595ca9f1c0369fca4c0f9cd722f Author: tikuta <tikuta@chromium.org> Date: Mon Sep 26 02:36:58 2016 Enable goma on pdfium buildbots by default. BUG= 643139 Review-Url: https://codereview.chromium.org/2297663007 [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/android.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/drm_win_xfa.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/linux.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/linux_asan.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/linux_no_v8.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/linux_skia.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/linux_xfa.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/linux_xfa_asan.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/mac.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/mac_no_v8.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/mac_skia.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/mac_xfa.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/mac_xfa_rel.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/try-linux_xfa_asan.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/win.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/win_no_v8.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/win_skia.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/win_xfa.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/win_xfa_32.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/win_xfa_clang.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/win_xfa_clang_32.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.expected/win_xfa_rel.json [modify] https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f/scripts/slave/recipes/pdfium.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/f72a0fe4c38128dfbe198505bfb7a87d4953efa6 commit f72a0fe4c38128dfbe198505bfb7a87d4953efa6 Author: tikuta <tikuta@chromium.org> Date: Mon Sep 26 02:51:49 2016 Revert of Enable goma on pdfium buildbots. (patchset #6 id:100001 of https://codereview.chromium.org/2297663007/ ) Reason for revert: https://build.chromium.org/p/client.pdfium/builders/linux/builds/2366 Sorry, I forget to add goma_dir in 'gn gen' step. https://build.chromium.org/p/client.pdfium/builders/linux/builds/2366/steps/gn%20gen/logs/stdio Original issue's description: > Enable goma on pdfium buildbots by default. > > BUG= 643139 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/c08b45f208a60595ca9f1c0369fca4c0f9cd722f TBR=phajdan.jr@chromium.org,dpranke@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 643139 Review-Url: https://codereview.chromium.org/2367253002 [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/android.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/drm_win_xfa.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/linux.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/linux_asan.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/linux_no_v8.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/linux_skia.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/linux_xfa.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/linux_xfa_asan.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/mac.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/mac_no_v8.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/mac_skia.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/mac_xfa.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/mac_xfa_rel.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/try-linux_xfa_asan.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/win.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/win_no_v8.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/win_skia.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/win_xfa.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/win_xfa_32.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/win_xfa_clang.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/win_xfa_clang_32.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.expected/win_xfa_rel.json [modify] https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6/scripts/slave/recipes/pdfium.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26072fbacd7d38e32239437a667eff37250b02b9 commit 26072fbacd7d38e32239437a667eff37250b02b9 Author: recipe-roller <recipe-roller@chromium.org> Date: Mon Sep 26 02:52:18 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f Enable goma on pdfium buildbots by default. (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2365243002 Cr-Commit-Position: refs/heads/master@{#420868} [modify] https://crrev.com/26072fbacd7d38e32239437a667eff37250b02b9/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/bb1ba38840de9941545ae1d20768699da052f077 commit bb1ba38840de9941545ae1d20768699da052f077 Author: recipe-roller <recipe-roller@chromium.org> Date: Mon Sep 26 02:54:57 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/c08b45f208a60595ca9f1c0369fca4c0f9cd722f Enable goma on pdfium buildbots by default. (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2368163002 [modify] https://crrev.com/bb1ba38840de9941545ae1d20768699da052f077/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/19e837a87622b86b42d57abc8956fcba2c749396 commit 19e837a87622b86b42d57abc8956fcba2c749396 Author: recipe-roller <recipe-roller@chromium.org> Date: Mon Sep 26 03:14:47 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6 Revert of Enable goma on pdfium buildbots. (patchset #6 id:100001 of https://codereview.chromium.org/2297663007/ ) (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2367213003 [modify] https://crrev.com/19e837a87622b86b42d57abc8956fcba2c749396/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a89870cd2aa5b801a8befd7900a7f724df71aeb4 commit a89870cd2aa5b801a8befd7900a7f724df71aeb4 Author: recipe-roller <recipe-roller@chromium.org> Date: Mon Sep 26 03:12:02 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/f72a0fe4c38128dfbe198505bfb7a87d4953efa6 Revert of Enable goma on pdfium buildbots. (patchset #6 id:100001 of https://codereview.chromium.org/2297663007/ ) (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2371613002 Cr-Commit-Position: refs/heads/master@{#420869} [modify] https://crrev.com/a89870cd2aa5b801a8befd7900a7f724df71aeb4/infra/config/recipes.cfg
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/95acda08f39263cbbeec4e9e268c37777dd5e1b6 commit 95acda08f39263cbbeec4e9e268c37777dd5e1b6 Author: recipe-roller <recipe-roller@chromium.org> Date: Mon Sep 26 18:54:44 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/df6070deda2483b959814f4af4ed12bc56a708ac commit df6070deda2483b959814f4af4ed12bc56a708ac Author: tikuta <tikuta@chromium.org> Date: Tue Sep 27 02:00:22 2016 Enable goma on pdfium buildbots by default. This CL is reland of https://codereview.chromium.org/2297663007/ fix: set goma_dir in 'gn gen' step. BUG= 643139 Review-Url: https://codereview.chromium.org/2367263002 [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/android.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/drm_win_xfa.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/linux.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/linux_asan.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/linux_no_v8.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/linux_skia.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/linux_xfa.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/linux_xfa_asan.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/mac.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/mac_no_v8.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/mac_skia.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/mac_xfa.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/mac_xfa_rel.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/try-linux_xfa_asan.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/win.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/win_no_v8.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/win_skia.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/win_xfa.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/win_xfa_32.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/win_xfa_clang.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/win_xfa_clang_32.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.expected/win_xfa_rel.json [modify] https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac/scripts/slave/recipes/pdfium.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/f9bc842ac20cb770cb17f9766f7eb9b7d4727072 commit f9bc842ac20cb770cb17f9766f7eb9b7d4727072 Author: recipe-roller <recipe-roller@chromium.org> Date: Tue Sep 27 02:04:54 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/4529c1ecb1657922abb3112dd989ccfafb951e3a commit 4529c1ecb1657922abb3112dd989ccfafb951e3a Author: recipe-roller <recipe-roller@chromium.org> Date: Tue Sep 27 02:19:05 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac Enable goma on pdfium buildbots by default. (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2371063002 [modify] https://crrev.com/4529c1ecb1657922abb3112dd989ccfafb951e3a/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06e8f8d3ea3e125abecf04a0d1041947e774e2e3 commit 06e8f8d3ea3e125abecf04a0d1041947e774e2e3 Author: recipe-roller <recipe-roller@chromium.org> Date: Tue Sep 27 02:32:59 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/df6070deda2483b959814f4af4ed12bc56a708ac Enable goma on pdfium buildbots by default. (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2370163002 Cr-Commit-Position: refs/heads/master@{#421083} [modify] https://crrev.com/06e8f8d3ea3e125abecf04a0d1041947e774e2e3/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/3e51f3b4787dcc251a4d751572e1c1fd234e874a commit 3e51f3b4787dcc251a4d751572e1c1fd234e874a Author: tikuta <tikuta@chromium.org> Date: Tue Sep 27 02:42:35 2016 Revert of Enable goma on pdfium buildbots by default. (patchset #1 id:1 of https://codereview.chromium.org/2367263002/ ) Reason for revert: Sorry, this CL also breaks build warterfall on Windows. https://uberchromegw.corp.google.com/i/client.pdfium/builders/windows/builds/1666 Uncaught Exception https://uberchromegw.corp.google.com/i/client.pdfium/builders/windows/builds/1666/steps/Uncaught%20Exception/logs/stdio need close before unlink in raw_io? Original issue's description: > Enable goma on pdfium buildbots by default. > > This CL is reland of https://codereview.chromium.org/2297663007/ > fix: set goma_dir in 'gn gen' step. > > BUG= 643139 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/df6070deda2483b959814f4af4ed12bc56a708ac TBR=phajdan.jr@chromium.org,dpranke@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 643139 Review-Url: https://codereview.chromium.org/2377553002 [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/android.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/drm_win_xfa.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/linux.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/linux_asan.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/linux_no_v8.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/linux_skia.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/linux_xfa.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/linux_xfa_asan.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/mac.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/mac_no_v8.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/mac_skia.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/mac_xfa.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/mac_xfa_rel.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/try-linux_xfa_asan.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/win.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/win_no_v8.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/win_skia.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/win_xfa.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/win_xfa_32.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/win_xfa_clang.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/win_xfa_clang_32.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.expected/win_xfa_rel.json [modify] https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a/scripts/slave/recipes/pdfium.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/e1ca4f6a4f4a35f61bc506374e18d95c2846bb25 commit e1ca4f6a4f4a35f61bc506374e18d95c2846bb25 Author: recipe-roller <recipe-roller@chromium.org> Date: Tue Sep 27 02:55:06 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/0cb873e7b39f017199077e4ac27a3322cbcbb278 commit 0cb873e7b39f017199077e4ac27a3322cbcbb278 Author: recipe-roller <recipe-roller@chromium.org> Date: Tue Sep 27 03:05:19 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a Revert of Enable goma on pdfium buildbots by default. (patchset #1 id:1 of https://codereview.chromium.org/2367263002/ ) (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2374663002 [modify] https://crrev.com/0cb873e7b39f017199077e4ac27a3322cbcbb278/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d11c6acb3fdf0b39c6cec99ce3a2724330d668a2 commit d11c6acb3fdf0b39c6cec99ce3a2724330d668a2 Author: recipe-roller <recipe-roller@chromium.org> Date: Tue Sep 27 03:07:17 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/3e51f3b4787dcc251a4d751572e1c1fd234e874a Revert of Enable goma on pdfium buildbots by default. (patchset #1 id:1 of https://codereview.chromium.org/2367263002/ ) (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2371073002 Cr-Commit-Position: refs/heads/master@{#421089} [modify] https://crrev.com/d11c6acb3fdf0b39c6cec99ce3a2724330d668a2/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/2ef451d6c8afe2635e0eeb55038a0e3fb564d3ad commit 2ef451d6c8afe2635e0eeb55038a0e3fb564d3ad Author: tikuta <tikuta@chromium.org> Date: Wed Sep 28 05:31:42 2016 Set close_fds True in Popen of cloudtail In windows, Popen inherits file descriptors and Exception occurs when raw_io unlinks opened files. Let's close fds when invoking cloudtail. This will fix the bug on windows buildbot. https://codereview.chromium.org/2377553002/ BUG= 643139 Review-Url: https://codereview.chromium.org/2374543005 [modify] https://crrev.com/2ef451d6c8afe2635e0eeb55038a0e3fb564d3ad/scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/e89c73215c58baed5aa51063b1eef88d379a95f2 commit e89c73215c58baed5aa51063b1eef88d379a95f2 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Sep 28 05:34:02 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0be4fe34aa8052d3544d1ece0b35afe307e16e24 commit 0be4fe34aa8052d3544d1ece0b35afe307e16e24 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Sep 28 05:55:06 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/2ef451d6c8afe2635e0eeb55038a0e3fb564d3ad Set close_fds True in Popen of cloudtail (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2380563002 Cr-Commit-Position: refs/heads/master@{#421458} [modify] https://crrev.com/0be4fe34aa8052d3544d1ece0b35afe307e16e24/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/8d77af3d80f8a24f0c41dc20882d3ddb8b85cd1c commit 8d77af3d80f8a24f0c41dc20882d3ddb8b85cd1c Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Sep 28 18:13:10 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/2ef451d6c8afe2635e0eeb55038a0e3fb564d3ad Set close_fds True in Popen of cloudtail (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2373953002 [modify] https://crrev.com/8d77af3d80f8a24f0c41dc20882d3ddb8b85cd1c/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976 commit d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976 Author: tikuta <tikuta@chromium.org> Date: Thu Sep 29 02:03:58 2016 Enable goma on pdfium buildbots by default. This CL is reland of https://codereview.chromium.org/2367263002/ fix: use close_fds in goma module https://codereview.chromium.org/2374543005/ BUG= 643139 Review-Url: https://codereview.chromium.org/2380553002 [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/android.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/drm_win_xfa.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/linux.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/linux_asan_lsan.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/linux_no_v8.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/linux_skia.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/linux_xfa.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/linux_xfa_asan_lsan.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/mac.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/mac_no_v8.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/mac_skia.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/mac_xfa.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/mac_xfa_rel.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/try-linux_xfa_asan_lsan.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/win.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/win_no_v8.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/win_skia.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/win_xfa.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/win_xfa_32.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/win_xfa_clang.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/win_xfa_clang_32.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.expected/win_xfa_rel.json [modify] https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976/scripts/slave/recipes/pdfium.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/a172c75dec9d8a53ac11e7cca4944b737a75d50f commit a172c75dec9d8a53ac11e7cca4944b737a75d50f Author: tikuta <tikuta@chromium.org> Date: Thu Sep 29 02:15:24 2016 Revert of Enable goma on pdfium buildbots by default. (patchset #1 id:1 of https://codereview.chromium.org/2380553002/ ) Reason for revert: https://uberchromegw.corp.google.com/i/client.pdfium/builders/windows https://uberchromegw.corp.google.com/i/client.pdfium/builders/windows/builds/1680/steps/start%20cloudtail/logs/stdio Traceback (most recent call last): File "E:\b\build\scripts/slave\recipe_modules\goma\resources\cloudtail_utils.py", line 63, in <module> sys.exit(main()) File "E:\b\build\scripts/slave\recipe_modules\goma\resources\cloudtail_utils.py", line 52, in main start_cloudtail(args) File "E:\b\build\scripts/slave\recipe_modules\goma\resources\cloudtail_utils.py", line 26, in start_cloudtail close_fds=True) File "E:\b\depot_tools\python276_bin\lib\subprocess.py", line 666, in __init__ raise ValueError("close_fds is not supported on Windows " ValueError: close_fds is not supported on Windows platforms if you redirect stdin/stdout/stderr Original issue's description: > Enable goma on pdfium buildbots by default. > > This CL is reland of https://codereview.chromium.org/2367263002/ > fix: use close_fds in goma module https://codereview.chromium.org/2374543005/ > > BUG= 643139 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976 TBR=phajdan.jr@chromium.org,dpranke@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 643139 Review-Url: https://codereview.chromium.org/2377193002 [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/android.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/drm_win_xfa.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/linux.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/linux_asan_lsan.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/linux_no_v8.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/linux_skia.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/linux_xfa.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/linux_xfa_asan_lsan.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/mac.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/mac_no_v8.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/mac_skia.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/mac_xfa.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/mac_xfa_rel.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/try-linux_xfa_asan_lsan.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/win.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/win_no_v8.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/win_skia.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/win_xfa.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/win_xfa_32.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/win_xfa_clang.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/win_xfa_clang_32.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.expected/win_xfa_rel.json [modify] https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f/scripts/slave/recipes/pdfium.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/c56069a1ba98870118c5e0a627a24e9c6f2d1df1 commit c56069a1ba98870118c5e0a627a24e9c6f2d1df1 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Sep 29 02:25:18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a3e8c6b16406e468d42ba80e1a205fe296c1a31 commit 2a3e8c6b16406e468d42ba80e1a205fe296c1a31 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Sep 29 02:28:56 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976 Enable goma on pdfium buildbots by default. (tikuta@chromium.org) https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f Revert of Enable goma on pdfium buildbots by default. (patchset #1 id:1 of https://codereview.chromium.org/2380553002/ ) (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2379873002 Cr-Commit-Position: refs/heads/master@{#421721} [modify] https://crrev.com/2a3e8c6b16406e468d42ba80e1a205fe296c1a31/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/9b4bbc285b92b89f9552b29fdc1b73ed45a2f685 commit 9b4bbc285b92b89f9552b29fdc1b73ed45a2f685 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Sep 29 02:35:43 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976 Enable goma on pdfium buildbots by default. (tikuta@chromium.org) https://crrev.com/a172c75dec9d8a53ac11e7cca4944b737a75d50f Revert of Enable goma on pdfium buildbots by default. (patchset #1 id:1 of https://codereview.chromium.org/2380553002/ ) (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2382533004 [modify] https://crrev.com/9b4bbc285b92b89f9552b29fdc1b73ed45a2f685/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/c7d36502f22665e021c122f9c3d04ccbd568b70a commit c7d36502f22665e021c122f9c3d04ccbd568b70a Author: tikuta <tikuta@chromium.org> Date: Fri Sep 30 20:11:58 2016 Stop redirect stdout/stderr and remove close_fds=True https://docs.python.org/2.7/library/subprocess.html#popen-constructor We can not set closed_fds True and redirect stdout/stderr at the same time on Windows. This CL will fix https://codereview.chromium.org/2380553002/ BUG= 643139 Review-Url: https://codereview.chromium.org/2375843005 [modify] https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a/scripts/slave/recipe_modules/goma/api.py [modify] https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a/scripts/slave/recipe_modules/goma/example.expected/linux.json [modify] https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a/scripts/slave/recipe_modules/goma/example.expected/linux_upload_logs.json [modify] https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a/scripts/slave/recipe_modules/goma/example.expected/mac.json [modify] https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a/scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json [modify] https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a/scripts/slave/recipe_modules/goma/example.expected/win.json [modify] https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a/scripts/slave/recipe_modules/goma/example.expected/win_upload_logs.json [modify] https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a/scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py [modify] https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a/scripts/slave/recipes/chromium_codesearch.expected/full_ChromiumOS_Codesearch.json [modify] https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a/scripts/slave/recipes/chromium_codesearch.expected/full_ChromiumOS_Codesearch_Builder.json [modify] https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a/scripts/slave/recipes/chromium_codesearch.expected/full_ChromiumOS_Codesearch_fail.json [modify] https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a/scripts/slave/recipes/chromium_codesearch.expected/full_Chromium_Linux_Codesearch.json [modify] https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a/scripts/slave/recipes/chromium_codesearch.expected/full_Chromium_Linux_Codesearch_Builder.json [modify] https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a/scripts/slave/recipes/wasm_llvm.expected/linux.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31abc59b6f7eb91d67e68c8a1e9c631d45ad4090 commit 31abc59b6f7eb91d67e68c8a1e9c631d45ad4090 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Sep 30 20:26:32 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a Stop redirect stdout/stderr and remove close_fds=True (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2382193003 Cr-Commit-Position: refs/heads/master@{#422204} [modify] https://crrev.com/31abc59b6f7eb91d67e68c8a1e9c631d45ad4090/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/544a2dfdc3b6ef189a27c11a4d007311edfa831e commit 544a2dfdc3b6ef189a27c11a4d007311edfa831e Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Sep 30 20:35:10 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/c7d36502f22665e021c122f9c3d04ccbd568b70a Stop redirect stdout/stderr and remove close_fds=True (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2388493002 [modify] https://crrev.com/544a2dfdc3b6ef189a27c11a4d007311edfa831e/infra/config/recipes.cfg
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/6e963ec767bfa7ce7d54eafa5eca2822f9ea47a7 commit 6e963ec767bfa7ce7d54eafa5eca2822f9ea47a7 Author: recipe-roller <recipe-roller@chromium.org> Date: Mon Oct 03 03:04:56 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/b66caa589fca0e42b535c0d7edc62eb6bf6764bd commit b66caa589fca0e42b535c0d7edc62eb6bf6764bd Author: tikuta <tikuta@chromium.org> Date: Fri Oct 07 02:13:16 2016 Enable goma on pdfium buildbots by default. This CL is reland of https://codereview.chromium.org/2380553002/ fix: Stop redirect stdout/stderr and remove close_fds=True https://codereview.chromium.org/2375843005/ BUG= 643139 Review-Url: https://codereview.chromium.org/2386253004 [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/android.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/drm_win_xfa.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/linux.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/linux_asan_lsan.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/linux_no_v8.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/linux_skia.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/linux_xfa.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/linux_xfa_asan_lsan.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/mac.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/mac_no_v8.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/mac_skia.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/mac_xfa.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/mac_xfa_rel.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/try-linux_xfa_asan_lsan.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/win.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/win_no_v8.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/win_skia.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/win_xfa.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/win_xfa_32.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/win_xfa_clang.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/win_xfa_clang_32.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.expected/win_xfa_rel.json [modify] https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd/scripts/slave/recipes/pdfium.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/d0b2d60ff207f4cc986a21dfd2ae483c1628e376 commit d0b2d60ff207f4cc986a21dfd2ae483c1628e376 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Oct 07 02:35:01 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd Enable goma on pdfium buildbots by default. (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2395243003 [modify] https://crrev.com/d0b2d60ff207f4cc986a21dfd2ae483c1628e376/infra/config/recipes.cfg
I confirmed that the CL enabled goma on pdfium buildbots. https://build.chromium.org/p/client.pdfium/waterfall If you have problems related to goma, notify goma team please.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbcc5467176d10fdbd9bbc62d20f05c8af004816 commit dbcc5467176d10fdbd9bbc62d20f05c8af004816 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Oct 07 04:27:49 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/b66caa589fca0e42b535c0d7edc62eb6bf6764bd Enable goma on pdfium buildbots by default. (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 643139 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2398043003 Cr-Commit-Position: refs/heads/master@{#423795} [modify] https://crrev.com/dbcc5467176d10fdbd9bbc62d20f05c8af004816/infra/config/recipes.cfg
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/ba74db9f1be6a4fe27b4ba54dddbd195865f3ec1 commit ba74db9f1be6a4fe27b4ba54dddbd195865f3ec1 Author: recipe-roller <recipe-roller@chromium.org> Date: Tue Oct 11 22:53:53 2016
Comment 1 by thestig@chromium.org
, Sep 1 2016