New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643127 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Non-Regression : Page Becomes unresponsive on Selecting 'CPU Throttling' options from Timeline

Project Member Reported by mm00333...@techmahindra.com, Sep 1 2016

Issue description

Version:54.0.2840.8
OS: Windows

What steps will reproduce the problem?
(1)Launch Chrome -> Open any Page (Ex: Go to chrome://downloads) Page
(2)Now press F12 to open Dev Tools -> Go to Timeline Section and select any  'CPU Throttling' options(Ex: High end Device)
(3)Now close the Dev Tools ->Now Again Open Dev tools and close it(Please refer Video)and observe 

Expected:Page should not become unresponsive 
Actual: Instead Page Becomes unresponsive on Selecting 'CPU Throttling' options from Timeline

Note:
1.After closing Dev tools for Second time open New tab and again go to Chrome://downloads page and observe page is seen Blank
2.Issue is not seen on Linux OS

This is Non-Regression Issue as 'CPU Throttling' dropdown is introduced from 54.0.2835.0

MANUAL CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/54.0.2834.0..54.0.2835.0?pretty=fuller&n=10000

Suspecting https://codereview.chromium.org/2262543002 from Manual Changelog

@alph: Please feel free to re-assign if its not related to your change


 
Actual_Page.webm
1.1 MB View Download

Comment 1 by ajha@chromium.org, Sep 1 2016

Labels: -M-54 M-55
Able to reproduce the issue on the latest canary(55.0.2846.0) on Windows 10 as well. Works fine on Mac OS 10.11.6 on the same chrome version.

Comment 2 by alph@chromium.org, Sep 15 2016

Labels: -Pri-2 Pri-1

Comment 3 by alph@chromium.org, Sep 15 2016

Labels: M-54

Comment 4 by alph@chromium.org, Oct 7 2016

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed96d750e94db5c11d44b987d7a1995a46f69fb4

commit ed96d750e94db5c11d44b987d7a1995a46f69fb4
Author: alph <alph@chromium.org>
Date: Fri Oct 07 23:59:45 2016

DevTools: Fix CPU page becoming unresponsive with timeline CPU throttling on Win

BUG= 643127 

Review-Url: https://codereview.chromium.org/2400363002
Cr-Commit-Position: refs/heads/master@{#424021}

[modify] https://crrev.com/ed96d750e94db5c11d44b987d7a1995a46f69fb4/content/renderer/devtools/devtools_cpu_throttler.cc

Comment 6 by alph@chromium.org, Oct 8 2016

Labels: Merge-Request-54

Comment 7 by alph@chromium.org, Oct 8 2016

Labels: Merge-Request-55

Comment 8 by dimu@chromium.org, Oct 8 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.

Comment 9 by dimu@chromium.org, Oct 8 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 10 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7eb72e767d09b245a92c689d5ab70de24989982

commit e7eb72e767d09b245a92c689d5ab70de24989982
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Oct 10 18:38:56 2016

DevTools: Fix CPU page becoming unresponsive with timeline CPU throttling on Win

BUG= 643127 

Review-Url: https://codereview.chromium.org/2400363002
Cr-Commit-Position: refs/heads/master@{#424021}
(cherry picked from commit ed96d750e94db5c11d44b987d7a1995a46f69fb4)

Review URL: https://codereview.chromium.org/2407773003 .

Cr-Commit-Position: refs/branch-heads/2883@{#16}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/e7eb72e767d09b245a92c689d5ab70de24989982/content/renderer/devtools/devtools_cpu_throttler.cc

Labels: -Merge-Review-54 Merge-Approved-54
Approved for 54, please make sure the merge happens before 5pm so that it will be included in today's stable cut.
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 10 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20ddd909068fb2bc09ea9e7e54d955780d45e1af

commit 20ddd909068fb2bc09ea9e7e54d955780d45e1af
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Oct 10 22:36:45 2016

DevTools: Fix CPU page becoming unresponsive with timeline CPU throttling on Win

BUG= 643127 

Review-Url: https://codereview.chromium.org/2400363002
Cr-Commit-Position: refs/heads/master@{#424021}
(cherry picked from commit ed96d750e94db5c11d44b987d7a1995a46f69fb4)

Review URL: https://codereview.chromium.org/2403253002 .

Cr-Commit-Position: refs/branch-heads/2840@{#710}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/20ddd909068fb2bc09ea9e7e54d955780d45e1af/content/renderer/devtools/devtools_cpu_throttler.cc

Comment 13 by alph@chromium.org, Oct 10 2016

Status: Fixed (was: Started)
Labels: TE-Verified-55.0.2883.9
Verified the fix on Chrome version 55.0.2883.9 on Windows 7 and 10, Followed steps provided in bug report and no unresponsive page or blank page was observed. 
Labels: TE-Verified-54.0.2840.59 TE-Verified-M54
Tested the issue on windows 7 using chrome version 54.0.2840.59 with the steps mentioned in comment #0.Fix is working fine,not observed any issue upon the closing the devtools after selecting the CPU Throttling.
Please find the attached screen cast for the same.

Adding TE-Verified labels.

643127.mp4
602 KB View Download
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7eb72e767d09b245a92c689d5ab70de24989982

commit e7eb72e767d09b245a92c689d5ab70de24989982
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Oct 10 18:38:56 2016

DevTools: Fix CPU page becoming unresponsive with timeline CPU throttling on Win

BUG= 643127 

Review-Url: https://codereview.chromium.org/2400363002
Cr-Commit-Position: refs/heads/master@{#424021}
(cherry picked from commit ed96d750e94db5c11d44b987d7a1995a46f69fb4)

Review URL: https://codereview.chromium.org/2407773003 .

Cr-Commit-Position: refs/branch-heads/2883@{#16}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/e7eb72e767d09b245a92c689d5ab70de24989982/content/renderer/devtools/devtools_cpu_throttler.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20ddd909068fb2bc09ea9e7e54d955780d45e1af

commit 20ddd909068fb2bc09ea9e7e54d955780d45e1af
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Oct 10 22:36:45 2016

DevTools: Fix CPU page becoming unresponsive with timeline CPU throttling on Win

BUG= 643127 

Review-Url: https://codereview.chromium.org/2400363002
Cr-Commit-Position: refs/heads/master@{#424021}
(cherry picked from commit ed96d750e94db5c11d44b987d7a1995a46f69fb4)

Review URL: https://codereview.chromium.org/2403253002 .

Cr-Commit-Position: refs/branch-heads/2840@{#710}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/20ddd909068fb2bc09ea9e7e54d955780d45e1af/content/renderer/devtools/devtools_cpu_throttler.cc

Sign in to add a comment