New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 643121 link

Starred by 1 user
Status: Fixed
Owner:
yunchao...@intel.com
Closed: Sep 2016
Cc:
█ kbr@chromium.org
█ qiankun....@intel.com
zmo@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug

Blocking:
issue 638470



Sign in to add a comment

copy-texture-image-luma-format.html failed on Mac and Windows

Project Member Reported by yunchao...@intel.com, Sep 1 2016 

When clear texture for a specific level before drawing, we may need to adjust the format to an appropriate one. 

Otherwise, it would fail on desktop core profile. Because some texture format are not supported, say LUMINANCE, ALPHA, etc. 

The failure is caused by this.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1687500b6fd9c005536a030e6a0801d67c8fb188

commit 1687500b6fd9c005536a030e6a0801d67c8fb188
Author: yunchao.he <yunchao.he@intel.com>
Date: Fri Sep 02 23:38:47 2016

[Command Buffer] We may need to adjust texture format when clear texture level by tex{Sub}Image.
Because some color formats in GLES, say LUMINANCE/ALPHA, can not be supported by desktop OGL directly.

BUG= 643121 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2301823003
Cr-Commit-Position: refs/heads/master@{#416388}

[modify] https://crrev.com/1687500b6fd9c005536a030e6a0801d67c8fb188/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/1687500b6fd9c005536a030e6a0801d67c8fb188/gpu/command_buffer/service/framebuffer_manager_unittest.cc
[modify] https://crrev.com/1687500b6fd9c005536a030e6a0801d67c8fb188/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/1687500b6fd9c005536a030e6a0801d67c8fb188/gpu/command_buffer/service/texture_manager_unittest.cc

Comment 2 by vakh@chromium.org, Sep 5 2016 

yunchao.he@intel.com: Can you please confirm that this is a security issue, not a functional issue?

Comment 3 by yunchao...@intel.com, Sep 13 2016

Status: Fixed (was: Started)
vakh@chromium.org, sorry for my late response. I think it is a functional issue, at least for the failure on Mac. 
This issue has been fixed, close this one. Please re-open it if necessary.
►

Sign in to add a comment