Enable autotest to do firmware repair with servo v4 |
||||||||||||
Issue descriptionservo.py _initialize_programmer() needs to support servo v4. That means in server/cros/servo/firmware_programmer.py: - FlashECProgrammer needs to take in a port. - FlashromProgrammer needs to pass in the serial of the uServo to flashrom (and flashrom needs to take in a serial - https://chromium-review.googlesource.com/#/c/352820/)
,
Sep 1 2016
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/4b4f00233d3fca7d5d124a6637fa9439b549b041 commit 4b4f00233d3fca7d5d124a6637fa9439b549b041 Author: Kevin Cheng <kevcheng@chromium.org> Date: Fri Sep 09 09:37:07 2016 servod: Add RPC to get all serials associated with servod process. BUG= chromium:643081 TEST=Check that I get the serials from a servo v4/uServo setup. Change-Id: I8d1fcdb546617f3b13fb52a5ddecc5bdf6cac5aa Reviewed-on: https://chromium-review.googlesource.com/383591 Commit-Ready: Kevin Cheng <kevcheng@chromium.org> Tested-by: Kevin Cheng <kevcheng@chromium.org> Reviewed-by: Todd Broch <tbroch@chromium.org> [modify] https://crrev.com/4b4f00233d3fca7d5d124a6637fa9439b549b041/servo/servo_postinit.py [modify] https://crrev.com/4b4f00233d3fca7d5d124a6637fa9439b549b041/servo/servo_server.py
,
Oct 26 2016
,
Nov 15 2016
,
Nov 15 2016
kevchang@, please help push your CL: https://chromium-review.googlesource.com/#/c/383592/ I have another CL depends on it.
,
Jan 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/df2e29f4bff8fbb53f3d90745b63ed92b6aed5d2 commit df2e29f4bff8fbb53f3d90745b63ed92b6aed5d2 Author: Kevin Cheng <kevcheng@chromium.org> Date: Fri Sep 09 09:31:22 2016 [autotest] Enable firmware install for servo v4. CQ-DEPEND=CL:352820 CQ-DEPEND=CL:383591 BUG= chromium:643081 TEST=not yet Change-Id: I8df2c8961031041fee2c06affc8f5a0a794d64a6 Reviewed-on: https://chromium-review.googlesource.com/383592 Commit-Ready: Wai-Hong Tam <waihong@google.com> Tested-by: Wai-Hong Tam <waihong@google.com> Reviewed-by: Wai-Hong Tam <waihong@google.com> [modify] https://crrev.com/df2e29f4bff8fbb53f3d90745b63ed92b6aed5d2/server/cros/servo/servo.py [modify] https://crrev.com/df2e29f4bff8fbb53f3d90745b63ed92b6aed5d2/server/cros/servo/firmware_programmer.py
,
Mar 16 2018
Bulk closing Infra>Client>ChromeOS issues untouched in over a year.
,
Mar 16 2018
This definitely needs to be implemented if it isn't already.
,
Mar 16 2018
,
Mar 17 2018
-> kevcheng I have little context on what this is. Was this implemented?
,
Mar 19 2018
This should be fixed, I'll let Tom verify that.
,
Mar 19 2018
I recalled that I randomly tried running the provision_FirmwareUpdate test on my local machine using the servo-v4 with servo-micro. It raised some errors but I forgot the details, as it was 2~3 months ago. Kevin, could you give us a pointer of your test plan? I checked your submitted CLs and didn't find any test procedures. I am sure not if it was well-tested, like some corners of repairing/programming multiple DUTs. +kmshelton@ who may be interested as they saw some issues when using multiple DUTs.
,
Mar 19 2018
I don't remember how I tested it so let's assume I didn't :\ My setup is offline so I'll need some time to get everything setup, if you have a setup ready, could you try it quickly to see how it failed? (And also some repro instructions as well? I'm a bit rusty on how the fw programming works)
,
Mar 19 2018
I don't have this setup. kmshelton@'s team has some setup in the stress lab like some labstations and several DUTs. You can check with him to use their machines.
,
Mar 19 2018
As my info was old, kmshelton@ knows better status of this work. He may correct me if I am wrong.
,
Mar 21 2018
->kmshelton to comment
,
Mar 27 2018
chromeos1-row1-rack9-labstation and chromeos1-row1-rack9-host1 are probably the best candidates to explore state of firmware repair on. We can add a v4 to host2 to understand state of the multiple DUT case (let's confirm the single DUT case first). Can provision_FirmwareUpdate be launched directly from the labstation, or what is the best way to launch it?
,
Apr 3 2018
You'll need to launch it through the main afe (http://cautotest/afe/#tab_id=job_list&state_filter=all&type_filter=all). Labstation doesn't have autotest installed on it so it can start jobs itself.
,
Apr 16 2018
what is the right way to specify a fw build to the AFE? example failure: https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/192504412-kmshelton/chromeos1-row1-rack9-host1/debug looks like i am hitting: https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/server/site_tests/provision_FirmwareUpdate/control?rcl=49083c3c5a8a34595222c2009881b175b03422b8&l=30 inspected gs://chromeos-releases/ and didn't see anything like the example given in the Firmware RW build field ("x86-alex-firmware/R41-6588.9.0")
,
Apr 16 2018
with "Image URL/Build" set to coral-release/R64-10068.55.0 Firmware RW build set to: coral-firmware/R64-10068.55.0 Firmware RO build set to: coral-firmware/R64-10068.55.0 AFE returns: "Only suite job supports updating both ChromeOS build and firmware build."
,
Dec 5
server/cros/servo/firmware_programmer.py was broken for a long time for servo v4 + micro, but I fixed it with https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1079697 not sure about the mutli servo case. My recommendation is to include automated testing for that in the Santiam (b1600 high touch) lab during labstation release testing. Don't think that is in scope for this issue, though. The scope defined is c1 I believe has long been addressed. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by kevcheng@chromium.org
, Sep 1 2016