New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643066 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Ripple effect of Enter Icon is seen overlapped with the other profile

Project Member Reported by mm00333...@techmahindra.com, Sep 1 2016

Issue description

Version: 55.0.2846.0
OS: Windows
 
What steps will reproduce the problem?
1.Launch chrome -> Sign into Profile
2.Now Create/import supervised user -> Then click on avatar Menu and choose option "Exit and childlock" (For First time Sign in Page is seen so enter correct password then profile gets unlocked and now again choose option "Exit and childlock" )
3.Now Switch person window is displayed -> Click on Locked profile -> Enter password -> Now observe 'Enter' Icon and its ripple effect

Expected:  Ripple effect of Enter Icon should not be  seen overlapped with the other profile
Actual:  Instead Ripple effect of Enter Icon is seen overlapped (Please refer screenshot)


This is Non Regression Issue seen from 55.0.2846.0
will provide bisect info soon


 
Actual_Overlapping.png
195 KB View Download

Comment 1 by ajha@chromium.org, Sep 1 2016

 Issue 643065  has been merged into this issue.
Owner: sammiequon@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Non-Regression : Ripple effect of Enter Icon is seen overlapped with the other profile (was: Ripple effect of Enter Icon is seen overlapped with the other profile)
MANUAL CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/55.0.2845.0..55.0.2846.0?pretty=fuller&n=10000

Suspecting https://codereview.chromium.org/2254623003 from Manual Changelog

@sammiequon : Please feel free to re-assign if its not related to your change

Note : Issue is also seen on Linux OS

Comment 3 by ajha@chromium.org, Sep 7 2016

Cc: nyerramilli@chromium.org sammiequon@chromium.org ranjitkan@chromium.org
 Issue 644624  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b3ff5ba9c14e072c179fd3cb54636c499bc4dd4

commit 8b3ff5ba9c14e072c179fd3cb54636c499bc4dd4
Author: sammiequon <sammiequon@chromium.org>
Date: Tue Sep 13 21:55:19 2016

Submit button incompatiable with desktop chrome.

Due to some complications I was not actually reproduce these bugs on desktop chrome. They should at the very least fix the bugs where the submit button shows up. I have confirmed they work as before on the chromeos side.

BUG= 643066 , 643069 ,644325, 644843 

Review-Url: https://codereview.chromium.org/2326833002
Cr-Commit-Position: refs/heads/master@{#418384}

[modify] https://crrev.com/8b3ff5ba9c14e072c179fd3cb54636c499bc4dd4/ui/login/account_picker/user_pod_row.css
[modify] https://crrev.com/8b3ff5ba9c14e072c179fd3cb54636c499bc4dd4/ui/login/account_picker/user_pod_row.js
[modify] https://crrev.com/8b3ff5ba9c14e072c179fd3cb54636c499bc4dd4/ui/login/account_picker/user_pod_template.html

Status: Fixed (was: Assigned)
Issue is not seen on Latest Linux Build 55.0.2862.0.
Attaching Video for reference.
OnLatestBuild55.0.2862.0.ogv
1.2 MB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 20 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80dd269ca1f309fc184c94e6e4f642b43cd563c5

commit 80dd269ca1f309fc184c94e6e4f642b43cd563c5
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Sep 20 23:28:03 2016

Submit button incompatiable with desktop chrome.

Due to some complications I was not actually reproduce these bugs on desktop chrome. They should at the very least fix the bugs where the submit button shows up. I have confirmed they work as before on the chromeos side.

BUG= 643066 , 643069 ,644325, 644843 

Review-Url: https://codereview.chromium.org/2326833002
Cr-Commit-Position: refs/heads/master@{#418384}
(cherry picked from commit 8b3ff5ba9c14e072c179fd3cb54636c499bc4dd4)

Review URL: https://codereview.chromium.org/2357623003 .

Cr-Commit-Position: refs/branch-heads/2840@{#450}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/80dd269ca1f309fc184c94e6e4f642b43cd563c5/ui/login/account_picker/user_pod_row.css
[modify] https://crrev.com/80dd269ca1f309fc184c94e6e4f642b43cd563c5/ui/login/account_picker/user_pod_row.js
[modify] https://crrev.com/80dd269ca1f309fc184c94e6e4f642b43cd563c5/ui/login/account_picker/user_pod_template.html

Labels: TE-Verified-M54 TE-Verified-54.0.2840.34
Verified the issue on windows 10 and Ubuntu 14.04 using chrome beta version #54.0.2840.34 as per the comment #0
Observed that the fix is working as expected.

Attaching screencast for reference

Hence, adding the verified labels.
643066.ogv
3.2 MB View Download
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80dd269ca1f309fc184c94e6e4f642b43cd563c5

commit 80dd269ca1f309fc184c94e6e4f642b43cd563c5
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Sep 20 23:28:03 2016

Submit button incompatiable with desktop chrome.

Due to some complications I was not actually reproduce these bugs on desktop chrome. They should at the very least fix the bugs where the submit button shows up. I have confirmed they work as before on the chromeos side.

BUG= 643066 , 643069 ,644325, 644843 

Review-Url: https://codereview.chromium.org/2326833002
Cr-Commit-Position: refs/heads/master@{#418384}
(cherry picked from commit 8b3ff5ba9c14e072c179fd3cb54636c499bc4dd4)

Review URL: https://codereview.chromium.org/2357623003 .

Cr-Commit-Position: refs/branch-heads/2840@{#450}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/80dd269ca1f309fc184c94e6e4f642b43cd563c5/ui/login/account_picker/user_pod_row.css
[modify] https://crrev.com/80dd269ca1f309fc184c94e6e4f642b43cd563c5/ui/login/account_picker/user_pod_row.js
[modify] https://crrev.com/80dd269ca1f309fc184c94e6e4f642b43cd563c5/ui/login/account_picker/user_pod_template.html

Sign in to add a comment