When defining an element, check for CustomElementRegistry`s element definition flag is running |
|||||||
Issue description
,
Sep 1 2016
,
Sep 2 2016
,
Sep 2 2016
,
Sep 2 2016
Taking a look.
,
Sep 2 2016
Patch up at https://codereview.chromium.org/2306923002
,
Sep 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fade7ae22a3ea448947c5c90cb1a2ac2b5c30781 commit fade7ae22a3ea448947c5c90cb1a2ac2b5c30781 Author: dominicc <dominicc@chromium.org> Date: Sun Sep 04 01:00:58 2016 Prevent recursion in critical part of CustomElementRegistry::define. Custom element registry used to allow recursion, but this complicated the check for whether a name was in use. Now define [1] has an simpler explicit recursion guard called the "element definition is running flag." [2] [1] https://html.spec.whatwg.org/#dom-customelementregistry-define [2] https://html.spec.whatwg.org/#element-definition-is-running BUG= 643051 Review-Url: https://codereview.chromium.org/2306923002 Cr-Commit-Position: refs/heads/master@{#416460} [modify] https://crrev.com/fade7ae22a3ea448947c5c90cb1a2ac2b5c30781/third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html [modify] https://crrev.com/fade7ae22a3ea448947c5c90cb1a2ac2b5c30781/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp [modify] https://crrev.com/fade7ae22a3ea448947c5c90cb1a2ac2b5c30781/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.h
,
Sep 7 2016
,
Sep 29 2016
Issue 640850 has been merged into this issue. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by davaajav@google.com
, Sep 1 2016