New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643051 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 643030



Sign in to add a comment

When defining an element, check for CustomElementRegistry`s element definition flag is running

Project Member Reported by davaajav@google.com, Sep 1 2016

Issue description

Blockedon: 643030
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 1 2016

Labels: Hotlist-Google
Blocking: 643030
Blockedon: -643030
Components: Blink>WebComponents
Labels: -Pri-3 Pri-2
Owner: dominicc@chromium.org
Status: started (was: Untriaged)
Taking a look.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fade7ae22a3ea448947c5c90cb1a2ac2b5c30781

commit fade7ae22a3ea448947c5c90cb1a2ac2b5c30781
Author: dominicc <dominicc@chromium.org>
Date: Sun Sep 04 01:00:58 2016

Prevent recursion in critical part of CustomElementRegistry::define.

Custom element registry used to allow recursion, but this complicated
the check for whether a name was in use. Now define [1] has an simpler
explicit recursion guard called the "element definition is running
flag." [2]

[1] https://html.spec.whatwg.org/#dom-customelementregistry-define
[2] https://html.spec.whatwg.org/#element-definition-is-running

BUG= 643051 

Review-Url: https://codereview.chromium.org/2306923002
Cr-Commit-Position: refs/heads/master@{#416460}

[modify] https://crrev.com/fade7ae22a3ea448947c5c90cb1a2ac2b5c30781/third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html
[modify] https://crrev.com/fade7ae22a3ea448947c5c90cb1a2ac2b5c30781/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp
[modify] https://crrev.com/fade7ae22a3ea448947c5c90cb1a2ac2b5c30781/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.h

Status: Fixed (was: Started)
Cc: dominicc@chromium.org kojii@chromium.org kochi@chromium.org
 Issue 640850  has been merged into this issue.

Sign in to add a comment