New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643050 link

Starred by 0 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Migrate ArcBitmap to use typemapping

Project Member Reported by xiy...@chromium.org, Sep 1 2016

Issue description

Raised during review of https://codereview.chromium.org/2269403004/, typemapping is preferred in the wonderful mojo world.
 
Components: Platform>ARC
Cc: lhchavez@chromium.org
Xiyuan, can I take this issue if you have not started yet?
Cc: -yoshiki@chromium.org xiy...@chromium.org
Owner: yoshiki@chromium.org
Sure. I have not started on it.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/377ca77ed026cd7e281fe8d915e109411ac065da

commit 377ca77ed026cd7e281fe8d915e109411ac065da
Author: yoshiki <yoshiki@chromium.org>
Date: Thu Sep 29 01:50:10 2016

Migrate ArcBitmap to use typemapping

BUG= 643050 
TEST=manual test: notification small icons show in the tray correctly
TEST=Autotest cheets_NotificationTest passes

Review-Url: https://codereview.chromium.org/2308663002
Cr-Commit-Position: refs/heads/master@{#421712}

[modify] https://crrev.com/377ca77ed026cd7e281fe8d915e109411ac065da/components/arc/BUILD.gn
[add] https://crrev.com/377ca77ed026cd7e281fe8d915e109411ac065da/components/arc/bitmap/OWNERS
[add] https://crrev.com/377ca77ed026cd7e281fe8d915e109411ac065da/components/arc/bitmap/bitmap_struct_traits.cc
[add] https://crrev.com/377ca77ed026cd7e281fe8d915e109411ac065da/components/arc/bitmap/bitmap_struct_traits.h
[delete] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/components/arc/bitmap/bitmap_type_converters.cc
[delete] https://crrev.com/5a139ba8b5636e7196714b4132b9240b18579ed3/components/arc/bitmap/bitmap_type_converters.h
[add] https://crrev.com/377ca77ed026cd7e281fe8d915e109411ac065da/components/arc/common/bitmap.typemap
[modify] https://crrev.com/377ca77ed026cd7e281fe8d915e109411ac065da/components/arc/common/typemaps.gni
[modify] https://crrev.com/377ca77ed026cd7e281fe8d915e109411ac065da/ui/arc/BUILD.gn
[modify] https://crrev.com/377ca77ed026cd7e281fe8d915e109411ac065da/ui/arc/notification/arc_custom_notification_item.cc
[modify] https://crrev.com/377ca77ed026cd7e281fe8d915e109411ac065da/ui/arc/notification/arc_custom_notification_item.h
[modify] https://crrev.com/377ca77ed026cd7e281fe8d915e109411ac065da/ui/arc/notification/arc_notification_item.cc
[modify] https://crrev.com/377ca77ed026cd7e281fe8d915e109411ac065da/ui/arc/notification/arc_notification_item.h
[modify] https://crrev.com/377ca77ed026cd7e281fe8d915e109411ac065da/ui/arc/notification/arc_notification_manager.cc

Status: Assignedfi (was: Assigned)
Status: Fixed (was: Assignedfi)

Comment 8 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55
Status: Verified (was: Fixed)
cheets_NotificationTest passes

Sign in to add a comment