New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643048 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 643030



Sign in to add a comment

Chrome does not pass the old and new documents to adoptedCallback.

Project Member Reported by davaajav@google.com, Sep 1 2016

Issue description

LayoutTests/fast/custom-elements/adopted-callback.html (various)

https://dom.spec.whatwg.org/#concept-node-adopt

 
Blockedon: 643030
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 1 2016

Labels: Hotlist-Google
Blocking: 643030
Blockedon: -643030
Components: Blink>WebComponents
Owner: dominicc@chromium.org
Status: Started (was: Untriaged)
Taking a look.
Patch up at https://codereview.chromium.org/2299033005 just waiting for bindings rubber stamp.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b19e5c9fb05d2f8af9e14dc3d7969324e1e5a8a

commit 9b19e5c9fb05d2f8af9e14dc3d7969324e1e5a8a
Author: dominicc <dominicc@chromium.org>
Date: Sun Sep 04 01:05:01 2016

Pass the old and new owner documents to the adoptedCallback.

The DOM adopt node steps [1] say to pass the old and new owner
documents to the adoptedCallback.

[1] https://dom.spec.whatwg.org/#concept-node-adopt

BUG= 643048 

Review-Url: https://codereview.chromium.org/2299033005
Cr-Commit-Position: refs/heads/master@{#416461}

[modify] https://crrev.com/9b19e5c9fb05d2f8af9e14dc3d7969324e1e5a8a/third_party/WebKit/LayoutTests/custom-elements/spec/adopt-node.html
[modify] https://crrev.com/9b19e5c9fb05d2f8af9e14dc3d7969324e1e5a8a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
[modify] https://crrev.com/9b19e5c9fb05d2f8af9e14dc3d7969324e1e5a8a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
[modify] https://crrev.com/9b19e5c9fb05d2f8af9e14dc3d7969324e1e5a8a/third_party/WebKit/Source/core/dom/TreeScopeAdopter.cpp
[modify] https://crrev.com/9b19e5c9fb05d2f8af9e14dc3d7969324e1e5a8a/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp
[modify] https://crrev.com/9b19e5c9fb05d2f8af9e14dc3d7969324e1e5a8a/third_party/WebKit/Source/core/dom/custom/CustomElement.h
[modify] https://crrev.com/9b19e5c9fb05d2f8af9e14dc3d7969324e1e5a8a/third_party/WebKit/Source/core/dom/custom/CustomElementAdoptedCallbackReaction.cpp
[modify] https://crrev.com/9b19e5c9fb05d2f8af9e14dc3d7969324e1e5a8a/third_party/WebKit/Source/core/dom/custom/CustomElementAdoptedCallbackReaction.h
[modify] https://crrev.com/9b19e5c9fb05d2f8af9e14dc3d7969324e1e5a8a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp
[modify] https://crrev.com/9b19e5c9fb05d2f8af9e14dc3d7969324e1e5a8a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
[modify] https://crrev.com/9b19e5c9fb05d2f8af9e14dc3d7969324e1e5a8a/third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp

Status: Fixed (was: Started)

Sign in to add a comment