New issue
Advanced search Search tips

Issue 643032 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 654690
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , All
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK failure in NavigationControllerImpl::RendererDidNavigate: pending_entry_index_ == -1 || pending_entry_->site_instance() || pending_entry_->restore_type() != NavigationEntryImpl::RESTORE_NONE.

Project Member Reported by ukai@chromium.org, Sep 1 2016

Issue description

Version: 55.0.2846.0 (Developer Build) (64-bit) with dcheck_always_on=1
OS: Linux

What steps will reproduce the problem?
(1) restart chromium, restore tabs
(2) google requires authentication?
(3)

What is the expected output?
What do you see instead?

[24639:24639:0901/113712:FATAL:navigation_controller_impl.cc(806)] Check failed:
 pending_entry_index_ == -1 || pending_entry_->site_instance() || pending_entry_->restore_type() != NavigationEntryImpl::RESTORE_NONE.

Please use labels and text to provide additional information.

 

Comment 1 by ukai@chromium.org, Sep 1 2016

Cc: fdegans@chromium.org
(gdb) bt
#0  0x00007fffeea12c37 in __GI_raise (sig=sig@entry=6)
    at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1  0x00007fffeea16028 in __GI_abort () at abort.c:89
#2  0x00007ffff7a6f522 in base::debug::BreakDebugger() ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#3  0x00007ffff7a9614a in logging::LogMessage::~LogMessage() ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#4  0x00007ffff57e77fb in content::NavigationControllerImpl::RendererDidNavigate(content::RenderFrameHostImpl*, FrameHostMsg_DidCommitProvisionalLoad_Params const&, content::LoadCommittedDetails*) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#5  0x00007ffff57f5d17 in content::NavigatorImpl::DidNavigate(content::RenderFrameHostImpl*, FrameHostMsg_DidCommitProvisionalLoad_Params const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#6  0x00007ffff57fc97b in content::RenderFrameHostImpl::OnDidCommitProvisionalLoad(IPC::Message const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#7  0x00007ffff57fa915 in content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#8  0x00007ffff59b8796 in content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#9  0x00007ffff4ab9865 in IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libipc.so
#10 0x00007ffff7a75e06 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#11 0x00007ffff7aa0855 in base::MessageLoop::RunTask(base::PendingTask const&)    ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#12 0x00007ffff7aa0bb8 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#13 0x00007ffff7aa0f6b in base::MessageLoop::DoWork() ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#14 0x00007ffff7aa2f7a in base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#15 0x00007ffff160de04 in g_main_dispatch (context=0x72fe5c0ec00)
    at /build/buildd/glib2.0-2.40.2/./glib/gmain.c:3064
#16 g_main_context_dispatch (context=context@entry=0x72fe5c0ec00)
    at /build/buildd/glib2.0-2.40.2/./glib/gmain.c:3663
#17 0x00007ffff160e048 in g_main_context_iterate (
    context=context@entry=0x72fe5c0ec00, block=block@entry=0,
    dispatch=dispatch@entry=1, self=<optimized out>)
    at /build/buildd/glib2.0-2.40.2/./glib/gmain.c:3734
#18 0x00007ffff160e0ec in g_main_context_iteration (context=0x72fe5c0ec00,
    may_block=0) at /build/buildd/glib2.0-2.40.2/./glib/gmain.c:3795
#19 0x00007ffff7aa2cd6 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#20 0x00007ffff7aa0351 in base::MessageLoop::RunHandler() ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#21 0x00007ffff7acd560 in base::RunLoop::Run() ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libbase.so
#22 0x00005555560249da in ChromeBrowserMainParts::MainMessageLoopRun(int*) ()
#23 0x00007ffff5705629 in content::BrowserMainLoop::RunMainMessageLoopParts()    ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#24 0x00007ffff5708d38 in content::BrowserMainRunnerImpl::Run() ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#25 0x00007ffff5700a2e in content::BrowserMain(content::MainFunctionParams const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#26 0x00007ffff600155e in content::RunNamedProcessTypeMain(std::string const&, content::MainFunctionParams const&, content::ContentMainDelegate*) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#27 0x00007ffff6002013 in content::ContentMainRunnerImpl::Run() ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#28 0x00007ffff6000870 in content::ContentMain(content::ContentMainParams const&) ()
   from /usr/local/google/home/ukai/src/chromium-git/src/out.0/Release/./libcontent.so
#29 0x0000555555a3599b in ChromeMain ()
#30 0x00007fffee9fdf45 in __libc_start_main (main=0x555555a35950 <main>,
    argc=2, argv=0x7fffffffdb38, init=<optimized out>, fini=<optimized out>,
    rtld_fini=<optimized out>, stack_end=0x7fffffffdb28) at libc-start.c:287
#31 0x0000555555a3586d in _start ()

https://chromium.googlesource.com/chromium/src/+/9caf66afae991a65c8cfa76322a15b8049365026
Cc: creis@chromium.org clamy@chromium.org carlosk@chromium.org
+people who actually still work on Chromium and have a higher chance of figuring out what is going on.

Comment 3 by creis@chromium.org, Sep 1 2016

Components: UI>Browser>Navigation
Labels: OS-Linux OS-All
Owner: creis@chromium.org
Summary: DCHECK failure in NavigationControllerImpl::RendererDidNavigate: pending_entry_index_ == -1 || pending_entry_->site_instance() || pending_entry_->restore_type() != NavigationEntryImpl::RESTORE_NONE. (was: FATAL:navigation_controller_impl.cc(806)] Check failed: pending_entry_index_ == -1 || pending_entry_->site_instance() || pending_entry_->restore_type() != NavigationEntryImpl::RESTORE_NONE.)
ukai@: What did you mean by "google requires authentication?"  Did you see one of the restored pages get redirected to a login page?  I wonder if that's causing us to have a non-restore pending entry with no SiteInstance.

(This is just a DCHECK, but it'd be good to know why it's failing.)

Comment 4 by ukai@chromium.org, Sep 2 2016

Yeah, I think I saw some restored page get redirected to a login page.

Comment 5 by creis@chromium.org, Oct 14 2016

Mergedinto: 654690
Status: Duplicate (was: Untriaged)

Sign in to add a comment