New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643031 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

debugd: cros_ec_panicinfo missing from feedback reports

Project Member Reported by drinkcat@chromium.org, Sep 1 2016

Issue description

Turns out "/bin/cat /sys/kernel/debug/cros_ec/panicinfo 2> /dev/null" cannot be run as non-priviledged user, so we always miss the panic information.

This is because /sys/kernel/debug is only accessible by user in debugfs-access group.
 
Status: Started (was: Available)
CL here: https://chromium-review.googlesource.com/#/c/379678/

Feedback report without the change: https://feedback.corp.google.com/product/208/neutron?lView=rd&lReport=19371160048

cros_ec_panicinfo=<empty>

And with the change: https://feedback.corp.google.com/product/208/neutron?lView=rd&lReport=19371262196

cros_ec_panicinfo=<base64>: AQINALBKACAAAAAAsEoAIGNmrd6kAAAANG0DCJNKAwgAAAAAAAAAAAAAAAAAAAAAkQkDCKQAAAA0bQMI7W0DCOhKACACAAAAAgAAAOkNACBTmgIIQHogAAAAAAAAAAAAGAAAAAwAAAACAAAAdAAAAFBuYyE=

Cc: moch@chromium.org josa...@chromium.org
Labels: Merge-Request-54
Wrongly referenced the old bug in https://chromium-review.googlesource.com/#/c/379678/, requesting merge to 54.

Comment 3 by dimu@chromium.org, Sep 6 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 6 2016

Labels: merge-merged-release-R54-8743.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0b522b85877d3b42ff11e2df57eb271bd3aa9c7d

commit 0b522b85877d3b42ff11e2df57eb271bd3aa9c7d
Author: Nicolas Boichat <drinkcat@google.com>
Date: Thu Sep 01 02:36:46 2016

debugd: log_tool: Change group to kDebugfsGroup to obtain EC panicinfo

/sys/kernel/debug is only accessible by user in debugfs-access group,
even though the panicinfo file itself is world-readable.

BUG= chromium:527904 
BUG= chromium:643031 
TEST=File feedback, panicinfo is present

Change-Id: I98fff3a511b944639bab10f78db8581923c4a32e
Previous-Reviewed-on: https://chromium-review.googlesource.com/379678
(cherry picked from commit f59e261a0cfd99b36a6772dcc266b915ad3baa26)
Reviewed-on: https://chromium-review.googlesource.com/381755
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>

[modify] https://crrev.com/0b522b85877d3b42ff11e2df57eb271bd3aa9c7d/debugd/src/log_tool.cc

Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 9 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-54

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment