MD Settings infinite setInterval when changing pages |
|||
Issue descriptionChanging pages with more than one page open (e.g., toggle Advanced, then navigate to About) or changing sub-pages (e.g. Site Settings -> Cookies) triggers an infinite setInterval loop in doWhenReady, pegging the CPU. This is because the page being tested does not match the page being displayed.
,
Sep 1 2016
yeah, so it doesn't really affect responsiveness
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e52c54ca4ad014ba5ac13451d1da456b06a4b80 commit 0e52c54ca4ad014ba5ac13451d1da456b06a4b80 Author: michaelpg <michaelpg@chromium.org> Date: Thu Sep 01 19:20:09 2016 MD Settings: fix infinite setInterval loop Pages that are not shown (but have been stamped) enter an infinite doWhenReady loop when transitioning to another page. We shouldn't use the doWhenReady hack if the page shouldn't be shown anyway. BUG= 643022 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2302703002 Cr-Commit-Position: refs/heads/master@{#416014} [modify] https://crrev.com/0e52c54ca4ad014ba5ac13451d1da456b06a4b80/chrome/browser/resources/settings/settings_main/settings_main.html [modify] https://crrev.com/0e52c54ca4ad014ba5ac13451d1da456b06a4b80/chrome/browser/resources/settings/settings_page/main_page_behavior.js
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6029c61672d1a5d59cb7fbd5b5047b54b0ea48c5 commit 6029c61672d1a5d59cb7fbd5b5047b54b0ea48c5 Author: michaelpg <michaelpg@chromium.org> Date: Thu Sep 01 22:36:14 2016 Address feedback from "MD Settings: fix infinite setInterval loop" BUG= 643022 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2302113002 Cr-Commit-Position: refs/heads/master@{#416089} [modify] https://crrev.com/6029c61672d1a5d59cb7fbd5b5047b54b0ea48c5/chrome/browser/resources/settings/settings_main/settings_main.html [modify] https://crrev.com/6029c61672d1a5d59cb7fbd5b5047b54b0ea48c5/chrome/browser/resources/settings/settings_page/main_page_behavior.js
,
Sep 20 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dbeam@chromium.org
, Sep 1 2016