[MD-Settings] Advanced button doesn't toggle on some URLs |
||||
Issue descriptionWhat steps will reproduce the problem? 1. Navigate to any section under Advanced (ex: chrome://md-settings/privacy) 2. Click the Advanced button to collapse the section What is the expected result? Section collapses What happens instead of that? Nothing happens when clicking this button after navigating to a section in advanced.
,
Sep 1 2016
I've reprod this as well. This could tie into Tommy's proposal that we remove routes to top-level sections (we'd still have all the routes from the old options - each pointing into sub-pages). There is a hick-up with that idea with regard to Blue Tooth settings on CrOS.
,
Sep 1 2016
643016
,
Sep 1 2016
I'll take a look.
,
Sep 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b8a42d0c7032ffe452a6b4bd020f8be2697fdd5 commit 3b8a42d0c7032ffe452a6b4bd020f8be2697fdd5 Author: tommycli <tommycli@chromium.org> Date: Wed Sep 14 01:33:51 2016 MD Settings: Fix Advanced Toggle when on an Advanced section route. BUG= 643016 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2307703002 Cr-Commit-Position: refs/heads/master@{#418447} [modify] https://crrev.com/3b8a42d0c7032ffe452a6b4bd020f8be2697fdd5/chrome/browser/resources/settings/settings_main/settings_main.html [modify] https://crrev.com/3b8a42d0c7032ffe452a6b4bd020f8be2697fdd5/chrome/browser/resources/settings/settings_main/settings_main.js [modify] https://crrev.com/3b8a42d0c7032ffe452a6b4bd020f8be2697fdd5/chrome/test/data/webui/settings/settings_main_test.js
,
Oct 25 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by hcarmona@chromium.org
, Sep 1 20164.7 MB
4.7 MB Download