New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643013 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Not currently working on Chromium
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 570121



Sign in to add a comment

bluetooth: web: Update Blacklist with Cypress & FIDO services.

Project Member Reported by scheib@chromium.org, Sep 1 2016

Issue description

https://github.com/WebBluetoothCG/registries/blob/master/gatt_blacklist.txt has been updated with 

Cypress bootloader service 00060000
https://github.com/WebBluetoothCG/registries/pull/13

FIDO authentication service fffd
https://github.com/WebBluetoothCG/registries/pull/14

that need to be incorporated into Chromium's implementation.

 
Description: Show this description
Summary: bluetooth: web: Update Blacklist with Cypress & FIDO services. (was: bluetooth: web: Update Blacklist with 2 new service UUIDs)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/783cbf77c054a6b31529d8031eefcd11b97f65b7

commit 783cbf77c054a6b31529d8031eefcd11b97f65b7
Author: scheib <scheib@chromium.org>
Date: Fri Sep 02 04:26:07 2016

bluetooth: web: Update Blacklist with Cypress & FIDO services.

https://github.com/WebBluetoothCG/registries/blob/master/gatt_blacklist.txt
has been updated to include 2 additional blacklisted services.

Cypress bootloader service 00060000
https://github.com/WebBluetoothCG/registries/pull/13

FIDO authentication service fffd
https://github.com/WebBluetoothCG/registries/pull/14

Unit tests also fixed to include all items from blacklist in the exhaustive tests at the end.

BUG= 570121 ,  643013 

Review-Url: https://codereview.chromium.org/2302693002
Cr-Commit-Position: refs/heads/master@{#416184}

[modify] https://crrev.com/783cbf77c054a6b31529d8031eefcd11b97f65b7/content/browser/bluetooth/bluetooth_blacklist.cc
[modify] https://crrev.com/783cbf77c054a6b31529d8031eefcd11b97f65b7/content/browser/bluetooth/bluetooth_blacklist_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45e66c790f6b93dec90df68aaaf826c09ae114a1

commit 45e66c790f6b93dec90df68aaaf826c09ae114a1
Author: scheib <scheib@chromium.org>
Date: Fri Sep 02 20:19:45 2016

bluetooth: web: Update Blacklist field trial with Cypress & FIDO services.

In preparation for deploying the Web Bluetooth Blacklist update via
field trial parameter this patch adds the payload to the
Field Trial Testing Config.

To support a browser test for this field trial parameter,
a test specific UUID is also added to the configs.

To enable readable comments in the json, the PRESUBMIT is
modified to accept comment keys.

BUG= 570121 ,  643013 

Review-Url: https://codereview.chromium.org/2306473002
Cr-Commit-Position: refs/heads/master@{#416332}

[modify] https://crrev.com/45e66c790f6b93dec90df68aaaf826c09ae114a1/chrome/browser/web_bluetooth_browsertest.cc
[modify] https://crrev.com/45e66c790f6b93dec90df68aaaf826c09ae114a1/testing/variations/PRESUBMIT.py
[modify] https://crrev.com/45e66c790f6b93dec90df68aaaf826c09ae114a1/testing/variations/fieldtrial_testing_config_android.json
[modify] https://crrev.com/45e66c790f6b93dec90df68aaaf826c09ae114a1/testing/variations/fieldtrial_testing_config_chromeos.json
[modify] https://crrev.com/45e66c790f6b93dec90df68aaaf826c09ae114a1/testing/variations/fieldtrial_testing_config_linux.json
[modify] https://crrev.com/45e66c790f6b93dec90df68aaaf826c09ae114a1/testing/variations/fieldtrial_testing_config_mac.json
[modify] https://crrev.com/45e66c790f6b93dec90df68aaaf826c09ae114a1/testing/variations/fieldtrial_testing_config_win.json

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b00368426e8e625edcce6c65814ea7ea08a7e841

commit b00368426e8e625edcce6c65814ea7ea08a7e841
Author: scheib <scheib@chromium.org>
Date: Tue Sep 06 20:53:17 2016

bluetooth: web: Blacklist field trial test handles missing config.

Field trials can be configured for testing by either
testing/variations/fieldtrial_testing_config_*.json
config files, or by procedurally creating a trial
in a test.

However, tests must be tolerant of config files
not being applied because official shipping builders
do not use field trial test configurations.

BUG= 570121 ,  643013 

Review-Url: https://codereview.chromium.org/2314953002
Cr-Commit-Position: refs/heads/master@{#416725}

[modify] https://crrev.com/b00368426e8e625edcce6c65814ea7ea08a7e841/chrome/browser/web_bluetooth_browsertest.cc

Comment 6 by scheib@chromium.org, Sep 14 2016

Status: Fixed (was: Started)

Sign in to add a comment