It's only available for desktop.
Currently working on Android version of this.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12b5effe518ea78f16e31ebaff3610d25df2c756 commit 12b5effe518ea78f16e31ebaff3610d25df2c756 Author: Mustafa Emre Acer <meacer@chromium.org> Date: Tue Sep 26 19:26:35 2017 Enable captive portal interstitial on Android Captive portal interstitial is currently only compiled if ENABLE_CAPTIVE_PORTAL_DETECTION is present. This flag enables Chrome's own captive portal detection and is off on Android. However, we still want to be able to display a captive portal interstitial on Android, by way of checking the certificates served by portals. For that reason, this CL enables the captive portal interstitial on Android and uses the CaptivePortalCertificateList feature to detect captive portal related certificates. It also adds a Java test for the new interstitial. Bug: 642993 Change-Id: I6be15ce10a5039fb1b1d8da0e7ef2f2c27dc48b4 Reviewed-on: https://chromium-review.googlesource.com/661795 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Reviewed-by: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#504457} [modify] https://crrev.com/12b5effe518ea78f16e31ebaff3610d25df2c756/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [add] https://crrev.com/12b5effe518ea78f16e31ebaff3610d25df2c756/chrome/android/java/src/org/chromium/chrome/browser/ssl/CaptivePortalHelper.java [modify] https://crrev.com/12b5effe518ea78f16e31ebaff3610d25df2c756/chrome/android/java_sources.gni [add] https://crrev.com/12b5effe518ea78f16e31ebaff3610d25df2c756/chrome/android/javatests/src/org/chromium/chrome/browser/ssl/CaptivePortalTest.java [modify] https://crrev.com/12b5effe518ea78f16e31ebaff3610d25df2c756/chrome/browser/BUILD.gn [modify] https://crrev.com/12b5effe518ea78f16e31ebaff3610d25df2c756/chrome/browser/ssl/captive_portal_blocking_page.cc [modify] https://crrev.com/12b5effe518ea78f16e31ebaff3610d25df2c756/chrome/browser/ssl/captive_portal_blocking_page.h [add] https://crrev.com/12b5effe518ea78f16e31ebaff3610d25df2c756/chrome/browser/ssl/captive_portal_helper_android.cc [add] https://crrev.com/12b5effe518ea78f16e31ebaff3610d25df2c756/chrome/browser/ssl/captive_portal_helper_android.h [modify] https://crrev.com/12b5effe518ea78f16e31ebaff3610d25df2c756/chrome/browser/ssl/ssl_error_handler.cc [modify] https://crrev.com/12b5effe518ea78f16e31ebaff3610d25df2c756/chrome/browser/ssl/ssl_error_handler_unittest.cc [modify] https://crrev.com/12b5effe518ea78f16e31ebaff3610d25df2c756/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabTitleObserver.java [modify] https://crrev.com/12b5effe518ea78f16e31ebaff3610d25df2c756/net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5deb8ee7d273e0f316d81f2bb20d6c151c34cf5 commit d5deb8ee7d273e0f316d81f2bb20d6c151c34cf5 Author: Mustafa Emre Acer <meacer@chromium.org> Date: Fri Sep 29 00:06:55 2017 Use OS API to trigger a captive portal interstitial on Android net::android::GetIsCaptivePortal API returns the captive portal status on Android. Use this API to determine whether to show a captive portal interstitial in addition to the captive portal certificate list. Bug: 642993 Change-Id: I8cdeaed47ea7e198a7589a3573f96b2093cd4fad Reviewed-on: https://chromium-review.googlesource.com/664342 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#505220} [modify] https://crrev.com/d5deb8ee7d273e0f316d81f2bb20d6c151c34cf5/chrome/android/java/src/org/chromium/chrome/browser/ssl/CaptivePortalHelper.java [modify] https://crrev.com/d5deb8ee7d273e0f316d81f2bb20d6c151c34cf5/chrome/android/javatests/src/org/chromium/chrome/browser/ssl/CaptivePortalTest.java [modify] https://crrev.com/d5deb8ee7d273e0f316d81f2bb20d6c151c34cf5/chrome/browser/ssl/captive_portal_helper_android.cc [modify] https://crrev.com/d5deb8ee7d273e0f316d81f2bb20d6c151c34cf5/chrome/browser/ssl/ssl_browser_tests.cc [modify] https://crrev.com/d5deb8ee7d273e0f316d81f2bb20d6c151c34cf5/chrome/browser/ssl/ssl_error_handler.cc [modify] https://crrev.com/d5deb8ee7d273e0f316d81f2bb20d6c151c34cf5/chrome/browser/ssl/ssl_error_handler.h [modify] https://crrev.com/d5deb8ee7d273e0f316d81f2bb20d6c151c34cf5/chrome/browser/ssl/ssl_error_handler_unittest.cc [modify] https://crrev.com/d5deb8ee7d273e0f316d81f2bb20d6c151c34cf5/tools/metrics/histograms/enums.xml
Removing iOS: The iOS interstitial is implemented in https://chromium-review.googlesource.com/c/chromium/src/+/591691
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13767698da506b60ea9e437511bb904829a60a6b commit 13767698da506b60ea9e437511bb904829a60a6b Author: Mustafa Emre Acer <meacer@chromium.org> Date: Wed Oct 04 21:11:06 2017 Fix captive portal interstitial tests on Android SSLErrorHandler ignores updates to SSL Error Assistant proto if the version_id of the new updated proto is not greater than the version_id of the current proto. The test helper was using INT_MAX for version_id of the updated proto. This meant that the proto was only being set once and subsequent updates were ignored. Also, the value of os_reports_captive_portal_for_testing_ wasn't reset properly in tests. Bug: 642993 Change-Id: I4b021e5973ae6d4e7d95e61d55d7b117e1c2824d Reviewed-on: https://chromium-review.googlesource.com/699425 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#506515} [modify] https://crrev.com/13767698da506b60ea9e437511bb904829a60a6b/chrome/android/javatests/src/org/chromium/chrome/browser/ssl/CaptivePortalTest.java [modify] https://crrev.com/13767698da506b60ea9e437511bb904829a60a6b/chrome/browser/ssl/ssl_error_handler.cc [modify] https://crrev.com/13767698da506b60ea9e437511bb904829a60a6b/chrome/browser/ssl/ssl_error_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcc89b40499917f2300c4698247ccab3e4a2e8a9 commit dcc89b40499917f2300c4698247ccab3e4a2e8a9 Author: Mustafa Emre Acer <meacer@chromium.org> Date: Sat Oct 07 01:40:49 2017 Put OS captive portal APIs behind CaptivePortalInterstitial feature Bug: 380762 , 642993 Change-Id: I915bbf54a974d74e860c5a0a1aee72f2c85444f5 Reviewed-on: https://chromium-review.googlesource.com/703458 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#507263} [modify] https://crrev.com/dcc89b40499917f2300c4698247ccab3e4a2e8a9/chrome/android/javatests/src/org/chromium/chrome/browser/ssl/CaptivePortalTest.java [modify] https://crrev.com/dcc89b40499917f2300c4698247ccab3e4a2e8a9/chrome/browser/ssl/ssl_browser_tests.cc [modify] https://crrev.com/dcc89b40499917f2300c4698247ccab3e4a2e8a9/chrome/browser/ssl/ssl_error_handler.cc [modify] https://crrev.com/dcc89b40499917f2300c4698247ccab3e4a2e8a9/chrome/browser/ssl/ssl_error_handler_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bfaf1e4248cf14da4c5f6a8d904875f47393232 commit 5bfaf1e4248cf14da4c5f6a8d904875f47393232 Author: Mustafa Emre Acer <meacer@chromium.org> Date: Mon Oct 09 20:33:37 2017 Remove ENABLE_CAPTIVE_PORTAL_DETECTION check from SSL browser tests Both CaptivePortalInterstitial and CaptivePortalCertificateList features are now enabled on all (non-iOS) platforms independent of the ENABLE_CAPTIVE_PORTAL_DETECTION flag. Clean up browser tests to reflect this. Bug: 642993 Change-Id: If9ff72abcbba8c4f8bf3f8998892f11a8a0c1fc7 Reviewed-on: https://chromium-review.googlesource.com/706643 Reviewed-by: Eric Lawrence <elawrence@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#507471} [modify] https://crrev.com/5bfaf1e4248cf14da4c5f6a8d904875f47393232/chrome/browser/ssl/ssl_browser_tests.cc
Comment 1 by mea...@chromium.org
, Sep 1 2016