"TracingControllerTest.NotWhitelistedMetadataStripped" is flaky |
||||||||||
Issue description"TracingControllerTest.NotWhitelistedMetadataStripped" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 7 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPwsSBUZsYWtlIjRUcmFjaW5nQ29udHJvbGxlclRlc3QuTm90V2hpdGVsaXN0ZWRNZXRhZGF0YVN0cmlwcGVkDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Sep 1 2016
Primiano could you please find an owner for this? Thanks. If I don't hear from you before, I'll disable the test when I get a chance.
,
Sep 1 2016
CL to disable test is in CQ. Moving bug out of Sheriff queue.
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30f869ca29ea81de0464779dec96d4453534c21f commit 30f869ca29ea81de0464779dec96d4453534c21f Author: battre <battre@chromium.org> Date: Thu Sep 01 10:12:25 2016 Disable TracingControllerTest.NotWhitelistedMetadataStripped for flakiness BUG=642991 TBR=primiano@chromium.org, dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2296863006 Cr-Commit-Position: refs/heads/master@{#415922} [modify] https://crrev.com/30f869ca29ea81de0464779dec96d4453534c21f/content/browser/tracing/tracing_controller_browsertest.cc
,
Nov 8 2016
ssid can you see what's going on here? Don't want to leave that test uncovered for too long. -dsinclair@chromium.org as this is clearly on me/ssid.
,
Nov 29 2016
Assigning to Zhen who wrote the test. Running the test locally fails all the time (not flaky). TracingControllerTest.NotWhitelistedMetadataStripped starts a content_shell with multiple processes, but SetArgumentFilterPredicate is called only on browser process. TraceLog::FinishFlush is called on all processes and argument filter is needed for ConvertTraceEventsToTraceFormat. So, I am not sure how thie test was running at all?
,
Nov 29 2016
Hm as far as I can remember the filtering predicate should always be set by ChromeMainDelegate::BasicStartupComplete for all Chrome processes but probably not for content_shell child processes, so that makes sense. Presumably what changed here is that no child process was started in the past in this test? Not sure why one would be started here now, we're not doing any navigations. Some non-renderer utility process?
,
Nov 29 2016
I tried to print the process type in trace_log (https://codereview.chromium.org/2533333002/). It seems the GPU process and renderer process does not have predicate set: [22665:22673:1129/093516:3356961746456:WARNING:trace_log.cc(1033)] ============================= gpu-process ==== 0 [1:2:1129/093516:3356961752064:WARNING:trace_log.cc(1033)] ============================= renderer ==== 0 [22630:22630:1129/093516:3356961848033:WARNING:trace_log.cc(1033)] ============================= ==== 1 The last one I think is the test process. But why do we have multiple processes here? I even used --single_process flag. Here is the command I used: ninja -C out/Debug content_browsertests && ./out/Debug/content_browsertests --gtest_filter=TracingControllerTest.NotWhitelistedMetadataStripped --single_process
,
Nov 29 2016
The predicate is being set by the test at TestStartAndStopTracingStringWithFilter(). Note that this is a content_browsertest and the ChromeMainDelegate::BasicStartupComplete is not called because it is in chrome.
,
Dec 16 2017
,
Jan 24 2018
,
Jan 24 2018
,
Nov 22
,
Nov 22
For #c7, the GPUMain doesn't seems to call: ChromeMainDelegate::BasicStartupComplete(int* exit_code) And the test was failing in this stackframe: 7923:197923:1121/151153.522324:FATAL:trace_log.cc(997)] Check failed: !argument_filter_predicate_.is_null(). #0 0x5566dc64db5f base::debug::StackTrace::StackTrace() #1 0x5566dc5ca8d0 logging::LogMessage::~LogMessage() #2 0x5566dc63daa0 base::trace_event::TraceLog::FinishFlush() #3 0x5566dc5d10b8 base::debug::TaskAnnotator::RunTask() #4 0x5566dc5d06bf base::MessageLoopImpl::RunTask() #5 0x5566dc5d0be2 base::MessageLoopImpl::DoWork() #6 0x5566dc5d2a39 base::MessagePumpGlib::Run() #7 0x5566dc5eb575 base::RunLoop::Run() #8 0x5566dee25f62 content::GpuMain() #9 0x5566dbbe7fed content::ContentMainRunnerImpl::Run() #10 0x5566dd887246 service_manager::Main() #11 0x5566db211361 content::ContentMain() #12 0x5566dc2d0c84 content::LaunchTests() #13 0x5566dc2ad930 main I'm putting a fix together. And I'll re-activate the tests.
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dcc6824cdbc7a65ad15a4b6d16298edc22ec50a commit 9dcc6824cdbc7a65ad15a4b6d16298edc22ec50a Author: Etienne Bergeron <etienneb@chromium.org> Date: Tue Nov 27 21:41:02 2018 Fix TracingControllerTest.NotWhitelistedMetadataStripped flakiness The |argument_filter_predicate_| is not set in the GPU process. The CHECK is triggered in the GPU process when flushing the buffer. void TraceLog::FinishFlush(int generation, bool discard_events) { [...] if (trace_options() & kInternalEnableArgumentFilter) { CHECK(!argument_filter_predicate_.is_null()); argument_filter_predicate = argument_filter_predicate_; } 7923:197923:1121/151153.522324:FATAL:trace_log.cc(997)] Check failed: !argument_filter_predicate_.is_null(). We tried with a CHECK to catch this case early in base::trace_event::TraceLog::SetEnabled(...). Which make the test fail here: [202280:202280:1121/152013.218605:FATAL:trace_log.cc(587)] Check failed: !trace_config.IsArgumentFilterEnabled() || !argument_filter_predicate_.is_null(). The current solution is to provide a default safe predicate filter in this case. R=oysteine@chromium.org Bug: 642991 Change-Id: Id52357299d170e66596081b8a020a42f9589754e Reviewed-on: https://chromium-review.googlesource.com/c/1348633 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#611343} [modify] https://crrev.com/9dcc6824cdbc7a65ad15a4b6d16298edc22ec50a/base/trace_event/trace_log.cc [modify] https://crrev.com/9dcc6824cdbc7a65ad15a4b6d16298edc22ec50a/content/browser/tracing/tracing_controller_browsertest.cc [modify] https://crrev.com/9dcc6824cdbc7a65ad15a4b6d16298edc22ec50a/content/browser/tracing/tracing_controller_impl.cc [modify] https://crrev.com/9dcc6824cdbc7a65ad15a4b6d16298edc22ec50a/content/browser/tracing/tracing_controller_impl.h |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by battre@chromium.org
, Sep 1 2016