New issue
Advanced search Search tips

Issue 642982 link

Starred by 1 user
Status: Assigned
Owner:
thestig@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

PDF Viewer should be able to toggle showing/hiding annotations

Project Member Reported by thestig@chromium.org, Aug 31 2016 
Now that we have made progress on  bug 62625  to display PDF annotations, they are displayed by default. Of course users may not always want to see annotations, so the PDF Viewer should have UI to toggle displaying / hiding them.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9b2754f28b5f29378a348f05ba27abbb1853f03

commit a9b2754f28b5f29378a348f05ba27abbb1853f03
Author: jaepark <jaepark@google.com>
Date: Fri Sep 09 22:48:40 2016

Add FPDF_ANNOT in PDFiumEngine::GetRenderingFlags.

This is a preparation CL for implementing toggle annotation button.

FPDF_ANNOT flag is needed to draw non-widget type PDF annotations, such
as text, highlight, underline, etc. Same flag needs to be passed to
FPDF_RenderPageBitmap_Start and FPDF_FFLDraw in order to display /
hide popup window associated to non-widget annotation on mouse-hover.

BUG=642982

Review-Url: https://codereview.chromium.org/2328893002
Cr-Commit-Position: refs/heads/master@{#417745}

[modify] https://crrev.com/a9b2754f28b5f29378a348f05ba27abbb1853f03/pdf/pdfium/pdfium_engine.cc
[modify] https://crrev.com/a9b2754f28b5f29378a348f05ba27abbb1853f03/pdf/pdfium/pdfium_engine.h

Comment 2 by jaepark@google.com, Sep 10 2016

Owner: thestig@chromium.org
►

Sign in to add a comment