New issue
Advanced search Search tips

Issue 642969 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

28.6% regression in media.android.tough_video_cases at 414804:414854

Project Member Reported by w...@chromium.org, Aug 31 2016

Issue description

See the link to graphs below.
 

Comment 1 by w...@chromium.org, Aug 31 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=642969

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgoY3duwkM


Bot(s) for this bug's original alert(s):

android-nexus7v2
Cc: reillyg@chromium.org
Owner: reillyg@chromium.org

=== Auto-CCing suspected CL author reillyg@chromium.org ===

Hi reillyg@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reland of move content::NotificationPermissionDispatcher. (patchset #1 id:1 of https://codereview.chromium.org/2258673002/ )
Author  : reillyg
Commit description:
  
Reason for revert:
Fixed the leak by adding a connection error handler that resets m_permissionService, breaking the circular reference between NotificationManager and pending Mojo callbacks.

Original issue's description:
> Revert of Remove content::NotificationPermissionDispatcher. (patchset #5 id:80001 of https://codereview.chromium.org/2244913002/ )
>
> Reason for revert:
> Causing failure on Builder WebKit Linux Leak
>
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/22036
>
> request-permission-detached-context.html
>
> 15:25:46.371 7635 worker/0 http/tests/notifications/request-permission-detached-context.html leaked
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.374 17565 [4/95] http/tests/notifications/request-permission-detached-context.html failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]}))
> 15:25:46.372 7635 worker/0 http/tests/notifications/request-permission-detached-context.html failed:
> 15:25:46.372 7635 worker/0  leak detected: ({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]})
>
> Original issue's description:
> > Remove content::NotificationPermissionDispatcher.
> >
> > blink::Notification can make calls to the Mojo PermissionService itself.
> >
> > BUG=561879
> >
> > Committed: https://crrev.com/be876eec511985fc0f476628b7b43dc951bd04c5
> > Cr-Commit-Position: refs/heads/master@{#412636}
>
> TBR=esprehn@chromium.org,haraken@chromium.org,johnme@chromium.org,mvanouwerkerk@chromium.org,peter@chromium.org,reillyg@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=561879
>
> Committed: https://crrev.com/5241216894d534ab30c763375a78ad68e0d155db
> Cr-Commit-Position: refs/heads/master@{#412678}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=561879

Review-Url: https://codereview.chromium.org/2258353002
Cr-Commit-Position: refs/heads/master@{#414820}
Commit  : a4fd553733bc0a7f6e0e110c66b0008c6dbf5a41
Date    : Fri Aug 26 21:45:52 2016


===== TESTED REVISIONS =====
Revision         Mean  Std Dev  N  Good?
chromium@414803  13.5  4.24264  8  good
chromium@414816  12.0  0.0      5  good
chromium@414818  12.0  0.0      5  good
chromium@414819  12.0  0.0      5  good
chromium@414820  16.0  0.0      5  bad    <--
chromium@414823  18.4  5.36656  5  bad
chromium@414829  18.4  5.36656  5  bad
chromium@414854  20.0  0.0      8  bad

Bisect job ran on: android_nexus7_perf_bisect
Bug ID: 642969

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests media.android.tough_video_cases
Test Metric: vm_shared_dirty_delta/crowd.wav_renderer
Relative Change: 38.89%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus7_perf_bisect/builds/3278
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9002770056970048064


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5832489556246528

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Labels: Needs-Feedback OS-Android
What is this metric measuring?

Comment 5 by w...@chromium.org, Sep 6 2016

renderer shared dirty memory delta from playing a wav file. 

If your change seems completely unrelated (as it appears to be) please feel free to wontfix. This might be noise.
Labels: -Needs-Feedback
Status: WontFix (was: Assigned)
My change probably did add a very small amount to renderer memory usage but it would be related to using the notification API. I agree that this is probably noise.

Sign in to add a comment