We'll need a M54 merge too, or M54 will likely hit this too when it goes to stable channel.

+ Prudhvi, can you please try to repro.

I tested a few old builds that correspond to commits in chrome/installers/linux/:

53.0.2747.0: has icons
53.0.2779.0: has icons
53.0.2783.0: missing (removed) icons

Which points to this change:

https://chromium.googlesource.com/chromium/src.git/+/c5e796b04c2dffb9bb2023ec6985d5c3457b6e99

It's still possible it's something outside that tree, so I'll try to test a couple more builds just to be sure.

It may be the case that all the affected users are running Cinnamon.

It's happening on my co-worker's unity environment as well.

53.0.2782.0 looks good. Suspect change is highly suspect.

When I install chrome 53 from scratch, icons are fine.  However, obviously the upgrade broke them.

Going to test if reverting the change will even fix this.

I don't see icons with either an upgrade or a clean (post-purge) install, though maybe it would behave differently on a completely clean system.

I see similar behaviour with unity as mentioned in comment#5 also checked with cinnamon as well, in both the Chrome icons are missing.

As per bisect provided by mmoss@ at #3, this bug exists before M53 branching (2785). And this seems to be a bad bug for affected users. Can we fall back to M52 build for Linux Stable until this issue is resolved? + Anantha, Jason

As per Joshua, fallback will be easy and doable.

The system package managers don't really support a version downgrade, at least not without manual intervention, so rolling back won't help people who already have it. Probably better to just get a fixed build out soon.

OK, let's go back if we can. How did this slip through testing?

FYI revert is on the way https://codereview.chromium.org/2299093002

Narayana, Can you check why ET team did not find this.

(FWIW) Re: #8, I installed Chrome on completely fresh VMs, and the icons appeared normally in all cases:
Ubuntu 16.04 LTS
    Unity
    Cinnamon 
Fedora 24:
    Gnome

Jason, go back isn't an option per mmoss@ update at #12.

Once fix is ready and safely merge to M53, we can do Linux ONLY Stable release tomorrow or Friday. 

Issue 642961 has been merged into this issue.

FYI, I happened to have Chrome Beta, and when I opened it, the main Chrome app started behaving as expected.

IMO we should consider rolling back the repo even if it won't fix users who have already received the update, because there are likely a large number of users who have not gotten the M53 update yet.

(We don't have great data on Linux update rates, so this is a bit of a guess.)

It is not clear from this bug: is it confirmed that reverting c5e796b04c2dffb9bb2023ec6985d5c3457b6e99 fixes this behavior?

#20 Unfortunately opening google-chrome-beta doesn't fix stable for me.

#21 The revert fixes icons on my machine, so https://codereview.chromium.org/2299093002/ is in the process of landing


I find it highly suspect that only googlers are hitting this issue.  mmoss@ Said that he was using goobuntu as the install platform.  However, #16 was unable to repro on a xenial VM.  I'm also unable to repro in a trusty, precise, or xenial VM.  Is anyone seeing this issue on a distro other than goobuntu?  Any non-googlers?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6884a31eba1024e7ca1a4d1d2906be06dd20936

commit a6884a31eba1024e7ca1a4d1d2906be06dd20936
Author: thomasanderson <thomasanderson@google.com>
Date: Thu Sep 01 01:43:08 2016

Revert of Support relocatable RPM packages (patchset #1 id:1 of https://codereview.chromium.org/2107893004/ )

Reason for revert:
Breaks icons on deb packages

Original issue's description:
> Support relocatable RPM packages
>
> BUG=31519
>
> Committed: https://crrev.com/c5e796b04c2dffb9bb2023ec6985d5c3457b6e99
> Cr-Commit-Position: refs/heads/master@{#402666}

TBR=thestig@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 642953 

Review-Url: https://codereview.chromium.org/2299093002
Cr-Commit-Position: refs/heads/master@{#415840}

[modify] https://crrev.com/a6884a31eba1024e7ca1a4d1d2906be06dd20936/chrome/installer/linux/common/apt.include
[modify] https://crrev.com/a6884a31eba1024e7ca1a4d1d2906be06dd20936/chrome/installer/linux/common/chromium-browser/chromium-browser.info
[modify] https://crrev.com/a6884a31eba1024e7ca1a4d1d2906be06dd20936/chrome/installer/linux/common/google-chrome/google-chrome.info
[modify] https://crrev.com/a6884a31eba1024e7ca1a4d1d2906be06dd20936/chrome/installer/linux/common/installer.include
[modify] https://crrev.com/a6884a31eba1024e7ca1a4d1d2906be06dd20936/chrome/installer/linux/common/postinst.include
[modify] https://crrev.com/a6884a31eba1024e7ca1a4d1d2906be06dd20936/chrome/installer/linux/common/prerm.include
[modify] https://crrev.com/a6884a31eba1024e7ca1a4d1d2906be06dd20936/chrome/installer/linux/common/rpm.include
[modify] https://crrev.com/a6884a31eba1024e7ca1a4d1d2906be06dd20936/chrome/installer/linux/common/symlinks.include
[modify] https://crrev.com/a6884a31eba1024e7ca1a4d1d2906be06dd20936/chrome/installer/linux/common/variables.include
[modify] https://crrev.com/a6884a31eba1024e7ca1a4d1d2906be06dd20936/chrome/installer/linux/debian/postinst
[modify] https://crrev.com/a6884a31eba1024e7ca1a4d1d2906be06dd20936/chrome/installer/linux/debian/postrm
[modify] https://crrev.com/a6884a31eba1024e7ca1a4d1d2906be06dd20936/chrome/installer/linux/debian/prerm
[modify] https://crrev.com/a6884a31eba1024e7ca1a4d1d2906be06dd20936/chrome/installer/linux/rpm/chrome.spec.template

Approving merge to M53 branch 2785 based on comment #22 (The revert fixes icons on thomasanderson@'s machine) and hoping it will be a safe revert.

Also per comment #22, if this issue is specific to Googlers only,can we push M53 build with the fix to Googlers only? I think it is possible, right Joshua?


Narayana, if possible can team please try to repro this bug on a distro other than goobuntu??

Rechecked this issue for chrome stable version 53.0.2785.89 on Ubuntu 14.04 in normal and with Cinnamon mode, Fedora 22, OpenSUSE42.1. Unable to reproduce the issue. Screenshots attached where icon appears in Menu, task bar.

Please do let us know if any thing else is required here.

Deleted: Cinnamon_Ubuntu.png 399 KB

	Cinnamon_Ubuntu.png 399 KB View Download

Deleted: Linux_Menu icon.png 3.1 MB

	Linux_Menu icon.png 3.1 MB View Download

Deleted: linux_taskBaricon.png 2.3 MB

	linux_taskBaricon.png 2.3 MB View Download

Deleted: OpenSUSE42.1_dashboard.png 241 KB

	OpenSUSE42.1_dashboard.png 241 KB View Download

Deleted: OpenSUSE42.1.png 288 KB

	OpenSUSE42.1.png 288 KB View Download

All,

I might be experiencing something similar. On my RHEL 7 box, after last nights update, Google Chrome seems to have "disappeared". I mean, it's still there, but something vital is missing. 

To wit, on GNOME:

(674) $ grep Exec /usr/share/applications/google-chrome.desktop
Exec=/usr/bin/google-chrome-stable %U
Exec=/usr/bin/google-chrome-stable
Exec=/usr/bin/google-chrome-stable --incognito

So the desktop is looking for /usr/bin/google-chrome-stable, but:

(677) $ ls -ltr /usr/bin/google*
lrwxrwxrwx. 1 root root 31 Sep  1 03:06 /usr/bin/google-chrome -> /etc/alternatives/google-chrome
(678) $ ls -ltr /etc/alternatives/google-chrome
lrwxrwxrwx. 1 root root 29 Sep  1 03:06 /etc/alternatives/google-chrome -> /usr/bin/google-chrome-stable

Since /usr/bin/google-chrome-stable does not exist, the symlink chain fails, all because /usr/bin/google-chrome-stable isn't around.  If I check the installed RPM:

(679) $ rpm -qil google-chrome-stable-53.0.2785.89-1.x86_64 | grep usr
/usr/bin/google-chrome
/usr/share/applications/google-chrome.desktop
/usr/share/gnome-control-center/default-apps/google-chrome.xml
/usr/share/man/man1/google-chrome.1

Well, the RPM surely isn't installing /usr/bin/google-chrome-stable either.

I can sort of "hack" things by running /opt/google/google-chrome, but that throws fun warnings ("Make Google Chrome your default!") because GNOME expects to use /usr/bin/google-chrome-stable as its default browser.

fortran@ All of my symlinks are set up on both a deb and rpm install, however links are still broken.

$ grep Exec /usr/share/applications/google-chrome.desktop 
Exec=/usr/bin/google-chrome-stable %U
Exec=/usr/bin/google-chrome-stable
Exec=/usr/bin/google-chrome-stable --incognito
$ ls -l /usr/bin/google-chrome-stable
lrwxrwxrwx 1 root root 32 Sep  1 06:36 /usr/bin/google-chrome-stable -> /opt/google/chrome/google-chrome
$ ls -l /opt/google/chrome/google-chrome
-rwxr-xr-x 1 root root 2112 Aug 30 16:58 /opt/google/chrome/google-chrome

rlyons@ said that logging out and logging back in fixes the menu entries and launcher icons.  Can mmoss@ or anyone else confirm?

Maybe this is a visual issue?  The change causes the post install scriplets unlink and relink /usr/bin/google-chrome-stable, so maybe the unlink is confusing desktop environments?

> Also per comment #22, if this issue is specific to Googlers only,can we push M53 build with the fix to Googlers only? I think it is possible, right Joshua?

Our ability to serve different content to Googlers is unfortunately based on network address, not the presence of goobuntu, so sadly this won't work for many Googler devices.

Yeah, got it. Thank you Joshua.

Interesting observation,when I restarted my machine I got all my shortcuts back. I have verified the same with couple of my teammates as well on both Unity and Cinnamon.

@pbommana Does logging out/logging in work as well?

What happens if you purge and then install the package again? Do the icons go away again? I wonder if the problem is more related to some external process on goobuntu machines, which was maybe in some bad state after an update, and was fixed by a restart (which probably doesn't happen often for goobuntu machines). 

Yeah logout and login back gets the shortcuts back again.

Seems like there is a workaround. Logout and login fixes the issue.

Anantha/Jason, do we still need to do Linux only Stable release this week or it can wait until next full stable release?  

Please find below cases which I have tried after running the purge :

test 1 : 
1. Purge the existing Chrome on Linux machine
2. Did a clean install suing "sudo apt-get install google-chrome-stable"

Observed behavior : 
No shortcuts were created, but when I logout and re-login back I see all shortcuts in place.


test 2 : 
1. Purge the existing Chrome on Linux machine
2. Installed Chrome M52(52.0.2743.116) using following command : sudo dpkg -i google-chrome-stable_52.0.2743.116-1_amd64.deb
3. Over install using Chrome M53(53.0.2785.89) using following command : sudo dpkg -i google-chrome-stable_53.0.2785.89-1_amd64.deb

Observed behavior :
Straight away after the over install happened Chrome shortcuts were missing, but when I logout and re-login back I see all shortcuts in place.

Re #36, Spoke to Anantha and we're going to do Linux ONLY stable release tomorrow with the fix. 	

thomasanderson@, please merge you change ASAP. So I can trigger RC for release tomorrow.

M53 merge.. https://codereview.chromium.org/2299273002

Re #39, merge is not yet landed to M53 branch 2785.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eeee448c002d6c4bfd098d02ec4d04f93122398

commit 9eeee448c002d6c4bfd098d02ec4d04f93122398
Author: thomasanderson <thomasanderson@google.com>
Date: Thu Sep 01 21:07:29 2016

Revert of Support relocatable RPM packages (patchset #1 id:1 of https://codereview.chromium.org/2107893004/ )

Reason for revert:
Breaks icons on deb packages

Original issue's description:
> Support relocatable RPM packages
>
> BUG=31519
>
> Committed: https://crrev.com/c5e796b04c2dffb9bb2023ec6985d5c3457b6e99
> Cr-Commit-Position: refs/heads/master@{#402666}

TBR=thestig@chromium.org
BUG= 642953 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2299093002
Review-Url: https://codereview.chromium.org/2299273002
Cr-Original-Commit-Position: refs/heads/master@{#415840}
Cr-Commit-Position: refs/branch-heads/2785@{#806}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/9eeee448c002d6c4bfd098d02ec4d04f93122398/chrome/installer/linux/common/apt.include
[modify] https://crrev.com/9eeee448c002d6c4bfd098d02ec4d04f93122398/chrome/installer/linux/common/chromium-browser/chromium-browser.info
[modify] https://crrev.com/9eeee448c002d6c4bfd098d02ec4d04f93122398/chrome/installer/linux/common/google-chrome/google-chrome.info
[modify] https://crrev.com/9eeee448c002d6c4bfd098d02ec4d04f93122398/chrome/installer/linux/common/installer.include
[modify] https://crrev.com/9eeee448c002d6c4bfd098d02ec4d04f93122398/chrome/installer/linux/common/postinst.include
[modify] https://crrev.com/9eeee448c002d6c4bfd098d02ec4d04f93122398/chrome/installer/linux/common/prerm.include
[modify] https://crrev.com/9eeee448c002d6c4bfd098d02ec4d04f93122398/chrome/installer/linux/common/rpm.include
[modify] https://crrev.com/9eeee448c002d6c4bfd098d02ec4d04f93122398/chrome/installer/linux/common/symlinks.include
[modify] https://crrev.com/9eeee448c002d6c4bfd098d02ec4d04f93122398/chrome/installer/linux/common/variables.include
[modify] https://crrev.com/9eeee448c002d6c4bfd098d02ec4d04f93122398/chrome/installer/linux/debian/postinst
[modify] https://crrev.com/9eeee448c002d6c4bfd098d02ec4d04f93122398/chrome/installer/linux/debian/postrm
[modify] https://crrev.com/9eeee448c002d6c4bfd098d02ec4d04f93122398/chrome/installer/linux/debian/prerm
[modify] https://crrev.com/9eeee448c002d6c4bfd098d02ec4d04f93122398/chrome/installer/linux/rpm/chrome.spec.template

Thank you thomasanderson@. Just triggered M53 RC build for Linux.

[Automated comment] Reverts referenced in bugdroid comments, after merge request, needs manual review.

For M54, I want to let it bake for a day before approving the merge.

FYI I've identified the cause of this bug.

The offending CL added a race condition between the installer and the desktop environment.  Previously, /usr/bin/google-chrome-stable was created around the same time as /usr/share/applications/google-chrome.desktop.  However, the CL caused the desktop file to be added after the symlink.  The desktop environment monitors /usr/share/applications for changes, and if it got the change before the symlink was created, this would result in broken icons.

If I take the 53.0.2785.89 deb that was pushed out yesterday and install it on my system that's under no load, the icons appear.  However, if I run "stress -c 200" while installing the same deb, the icons don't appear.  Using apt-get instead of dpkg does something that makes the race condition worse and icons usually break even under no load.

For a quick fix, move /usr/share/applications/google-chrome.desktop somewhere else and back.

I have verified the fix with latest Chrome M53(53.0.2785.92) on Ubuntu 14.04Lts with Cinnamon and Ubuntu, all shortcuts are available :

Test1 : 
1. Install Chrome 52.0.2743.116 
2. Over install/update with Chrome 53.0.2785.89 
3. Make sure that Chrome icons are missing after the update.
4. Then again over install/update to Chrome 53.0.2785.89 


Test 2 : 
1. Install Chrome 52.0.2743.116 
2. Then again over install/update to Chrome 53.0.2785.89


Test 3 : 
1. Clean install Chrome 53.0.2785.89


Please let me know if I missed something which should be covered.

thomasanderson@/mmoss@, could ptal test/verification listed at #48. If nothing else is pending, I can move forward with release. Thank you.

sgtm

pbommana@ verification lgtm

Thank you all. Moving forward with Beta/Stable push.

This is now fixed with version 53.0.2785.92 per comment #48, #50 and #51.

Reopening as M54 is still pending.

This change meets the bar and is approved for M54

I have verified the fix with latest Chrome M53(53.0.2785.101) on Ubuntu 14.04Lts with Cinnamon and Ubuntu, all shortcuts are available :

Test1 : 
1. Install Chrome 52.0.2743.116 
2. Over install/update with Chrome 53.0.2785.89 
3. Make sure that Chrome icons are missing after the update.
4. Then again over install/update to Chrome 53.0.2785.92 
5. Then again over install/update to Chrome 53.0.2785.101


Test 2 : 
1. Install Chrome 52.0.2743.116 
2. Then again over install/update to Chrome 53.0.2785.101


Test 3 : 
1. Clean install Chrome 53.0.2785.101

Test 4 : 
1. Install Chrome 53.0.2785.89 
2. Then again over install/update to Chrome 53.0.2785.101


Please let me know if I missed something which should be covered.

Please merge your change to M54 (branch: 2840) before 3:00 PM PST today if you would like to make it to M54 Beta promotion on Thursday [09/08].

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a85e7c8369c7971199a37be163dca6b9603288b

commit 5a85e7c8369c7971199a37be163dca6b9603288b
Author: thomasanderson <thomasanderson@google.com>
Date: Wed Sep 07 21:34:55 2016

Revert of Support relocatable RPM packages (patchset #1 id:1 of https://codereview.chromium.org/2107893004/ )

Reason for revert:
Breaks icons on deb packages

Original issue's description:
> Support relocatable RPM packages
>
> BUG=31519
>
> Committed: https://crrev.com/c5e796b04c2dffb9bb2023ec6985d5c3457b6e99
> Cr-Commit-Position: refs/heads/master@{#402666}

TBR=thestig@chromium.org
BUG= 642953 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2323513002
Cr-Commit-Position: refs/branch-heads/2840@{#217}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/apt.include
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/chromium-browser/chromium-browser.info
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/google-chrome/google-chrome.info
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/installer.include
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/postinst.include
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/prerm.include
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/rpm.include
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/symlinks.include
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/variables.include
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/debian/postinst
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/debian/postrm
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/debian/prerm
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/rpm/chrome.spec.template

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a85e7c8369c7971199a37be163dca6b9603288b

commit 5a85e7c8369c7971199a37be163dca6b9603288b
Author: thomasanderson <thomasanderson@google.com>
Date: Wed Sep 07 21:34:55 2016

Revert of Support relocatable RPM packages (patchset #1 id:1 of https://codereview.chromium.org/2107893004/ )

Reason for revert:
Breaks icons on deb packages

Original issue's description:
> Support relocatable RPM packages
>
> BUG=31519
>
> Committed: https://crrev.com/c5e796b04c2dffb9bb2023ec6985d5c3457b6e99
> Cr-Commit-Position: refs/heads/master@{#402666}

TBR=thestig@chromium.org
BUG= 642953 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2323513002
Cr-Commit-Position: refs/branch-heads/2840@{#217}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/apt.include
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/chromium-browser/chromium-browser.info
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/google-chrome/google-chrome.info
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/installer.include
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/postinst.include
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/prerm.include
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/rpm.include
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/symlinks.include
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/common/variables.include
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/debian/postinst
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/debian/postrm
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/debian/prerm
[modify] https://crrev.com/5a85e7c8369c7971199a37be163dca6b9603288b/chrome/installer/linux/rpm/chrome.spec.template