Issue 642945 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	afakhry@chromium.org
Closed:	Sep 2016
Cc:	x...@chromium.org abodenha@chromium.org █ warx@chromium.org tbuck...@chromium.org afakhry@chromium.org malaykeshav@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
M-55 VerifyIn-59 VerifyIn-60 VerifyIn-61

separate debug shortcuts and dev shortcuts

Project Member Reported by osh...@chromium.org, Aug 31 2016

Issue description

Currently the debug shortcuts includes ones that should not be enabled on device.
We should have a one for debugging on device, and one for development.

Examples:
Debug shortcuts:
* print layer/window tree
* toggle touch view mode
* toggle FPS counter
etc


Dev shortcuts:
* Display modifications
* shortcuts to avoid conflicts with desktop environments

Then consolidate TouchView testing flag into debug shortcuts flag.

Anyone interested? (otherwise, I'll look into this next week)

Comment 1 by afakhry@chromium.org, Aug 31 2016

Owner: afakhry@chromium.org
Status: Assigned (was: Available)

Let me take a look.

Comment 2 by afakhry@chromium.org, Sep 8 2016

Status: Started (was: Assigned)

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd09f64d921e02333652d2fae387b8b406201cf8

commit cd09f64d921e02333652d2fae387b8b406201cf8
Author: afakhry <afakhry@chromium.org>
Date: Fri Sep 16 22:26:56 2016

Separate debugging and developer accelerators

Hide developer accelerators behind --ash-developer-shortcuts command line
switch.

BUG= 642945 , 642551 

Review-Url: https://codereview.chromium.org/2323863002
Cr-Commit-Position: refs/heads/master@{#419301}

[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/accelerators/accelerator_controller_delegate_aura.cc
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/common/accelerators/accelerator_controller.cc
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/common/accelerators/accelerator_table.cc
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/common/accelerators/accelerator_table.h
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/common/accelerators/debug_commands.cc
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/common/accelerators/debug_commands.h
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/common/ash_switches.cc
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/common/ash_switches.h
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/mus/accelerators/accelerator_controller_delegate_mus.cc
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/mus/accelerators/accelerator_controller_unittest.cc