Issue metadata
Sign in to add a comment
|
chrome://bookmarks does not show complete list of bookmarks for attached BMB
Reported by
ugurcan....@gmail.com,
Aug 31 2016
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2845.0 Safari/537.36 Steps to reproduce the problem: 1. Attach bookmarks bar (with a lot of bookmarks) 2. Go to chrome://bookmarks 3. Detach the bookmarks bar (Alt+Cmd+B) 4. Observe the change in the list. What is the expected behavior? It should show the complete list of bookmarks for attached bookmarks bar. What went wrong? It only shows the complete list of bookmarks if the bookmarks bar is detached. Did this work before? Yes I don't remember. Chrome version: 55.0.2845.0 Channel: canary OS Version: OS X 10.11.6 Flash Version: Shockwave Flash 23.0 r0 BMB stands for bookmarks bar.
,
Sep 1 2016
Able to reproduce the issue on the latest canary(55.0.2846.0) on Window=10, Mac OS 10.11.6 and Linux Ubuntu 14.04. This is a regression issue broken in M-54. Last good build: 54.0.2817.0 First bad build: 54.0.2819.0 Changelog from Bisect tool: https://chromium.googlesource.com/chromium/src/+log/6526c5b4ac92c26c3903146941ceb267422ebf8c..8dfa12f1b8845bc912728471d19d9915119456d7 aberent@: Could you please take a look at this and confirm if the above suspect from the bisect tool is related. Thank you!
,
Sep 2 2016
Please have the fix baked in canary and merged to 2840 branch before 09/05 Monday for Dev Release Scheduled on Tuesday 09/06.The same will be promoted to Beta on 09/08.
,
Sep 5 2016
I have been on vacation. I will take a look, but that CL seems unlikely, since it was supposed to only change anything on Android.
,
Sep 5 2016
I can't reproduce this (with 25 bookmarks) with a local Linux build from master. Any other clues on how to reproduce?
,
Sep 5 2016
I can now reproduce this on 55.0.2845.0; but not on a local Linux build from master. I have tried both debug and release official builds. I still think this is very unlikely to be my CL; how exactly was this tested with the bisect tool?
,
Sep 5 2016
ajha@: Can you please recheck the regression range? Thanks in advance.
,
Sep 5 2016
Stranger and stranger! I have just realised that the behaviour I am seeing in the build I downloaded is the opposite of that reported in the original bug. Namely when the bookmark bar is hidden I only see a few bookmarks in the bookmark manager, but when it is visible I see them all. See the attached images. Note that, when I remove the bookmark bar, the list of bookmarks in the bookmark manager only changes when I refresh the page.
,
Sep 5 2016
Hmm, I've tested the situation, so let's make it clear. -chrome://bookmarks shows *incomplete* list of bookmarks whether you use attached/detached BMB -chrome://bookmarks shows *complete* list of bookmarks when you change the BMB behaviour (make detached BMB attached or vice versa) while you are on the page chrome://bookmarks: +If you use detached BMB,go to chrome://bookmarks you will see *incomplete* list. Make BMB attached, the page will show *complete* list (No need to refresh). +If you use attached BMB,go to chrome://bookmarks you will see *incomplete* list. Make BMB detached, the page will show *complete* list (No need to refresh).
,
Sep 5 2016
Okay, I did a deeper bisect and the regression range is this: https://chromium.googlesource.com/chromium/src/+log/67b240c6628573aa3437e14fc82edcb7de78e944..8dfa12f1b8845bc912728471d19d9915119456d7 Probably this is the culprit: https://codereview.chromium.org/2205843003 rune@opera.com: Can you please check, if your change is breaking the Bookmarks Manager? Thanks in advance!
,
Sep 5 2016
Not verified, but since this is in the same regression range and also for chrome://bookmarks I suspect it's the same as issue 634704 .
,
Sep 29 2016
CR 634704 fixed. Merged to m54 beta today, will appear with next beta update (~10/5?) |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Sep 1 2016Labels: -Type-Bug -Pri-2 Needs-Bisect Pri-1 Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)