sperigo: Another one! The idea is to add the custom interstitial at https://pinning-test.badssl.com/ to chrome://interstitials page. The code for chrome://interstitials is at https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/interstitials/interstitial_ui.cc

Quick question about this! Is the interstitial at https://pinning-test.badssl.com/ not the same as the one at chrome://interstitials/ssl?overridable=0&strict_enforcement=0? What exactly are you hoping for me to add here?

The error code at chrome://interstitials/ssl?overridable=0&strict_enforcement=0 is NET:ERR_CERT_CONTAINS_ERRORS – it would be good to have one that triggers the NET::ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN directly, in case they ever become different.

Here are screenshots of the chrome://interstitials page with the new "Pinned certificate error" and the corresponding interstitial that that link opens.

Deleted: Screenshot from 2017-06-27 11:52:45.png 52.6 KB

	Screenshot from 2017-06-27 11:52:45.png 52.6 KB View Download

Deleted: Screenshot from 2017-06-27 11:53:07.png 38.2 KB

	Screenshot from 2017-06-27 11:53:07.png 38.2 KB View Download

Hmm, it seems that the screenshot doesn't show ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN. Could you make sure you have the correct screenshot?

Sorry about that! Here are screenshots reflecting the correct, fixed behavior:

Deleted: Screenshot from 2017-06-27 11:52:45.png 52.6 KB

	Screenshot from 2017-06-27 11:52:45.png 52.6 KB View Download

Deleted: Screenshot from 2017-06-27 15:12:08.png 50.3 KB

	Screenshot from 2017-06-27 15:12:08.png 50.3 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6022f5947cba1db0d2f7f236d7de307955adf12a

commit 6022f5947cba1db0d2f7f236d7de307955adf12a
Author: sperigo <sperigo@chromium.org>
Date: Wed Jun 28 00:15:49 2017

Add pinned cert interstitial to chrome://interstitials

BUG= 642935 

TEST=Spin up an instance of Chrome and navigate to chrome://interstitials. Click on "Pinned certificate error." A full page interstitial should appear. Check to make sure the header reads "Privacy error" and the error code is "NET::ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN." See also interstitial_ui_browsertest.cc.

Review-Url: https://codereview.chromium.org/2957953002
Cr-Commit-Position: refs/heads/master@{#482810}

[modify] https://crrev.com/6022f5947cba1db0d2f7f236d7de307955adf12a/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
[modify] https://crrev.com/6022f5947cba1db0d2f7f236d7de307955adf12a/chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc
[modify] https://crrev.com/6022f5947cba1db0d2f7f236d7de307955adf12a/components/security_interstitials/core/browser/resources/list_of_interstitials.html