New issue
Advanced search Search tips

Issue 642925 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Jan 2018
Cc:
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Default favicon looks like breaking spacing

Reported by ugurcan....@gmail.com, Aug 31 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2845.0 Safari/537.36

Steps to reproduce the problem:
1. Add a bookmark has not favicon so the default favicon can be seen in the bookmarks bar
2. 
3. 

What is the expected behavior?
The default favicon should be well spaced to match normal favicons pages may have.

What went wrong?
Spacing for the default favicon looks incorrect. There might be some drawing miscalculations for bookmarks bar spacings as well as the vector favicon.

Did this work before? N/A 

Chrome version: 55.0.2845.0  Channel: canary
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 23.0 r0

Compare the default favicon spacings and the YouTube favicon. 

Please assign this to +shrike who handles bookmarks bar work.
Ekran Resmi 2016-09-01 00.54.54.png
657 KB View Download
Ekran Resmi 2016-09-01 00.55.59.png
657 KB View Download

Comment 1 by meh...@chromium.org, Sep 1 2016

Cc: shrike@chromium.org
Components: -UI UI>Browser>Bookmarks
Labels: Proj-MaterialDesign-NativeUI
For me, the spacing is correct. The Default-Favicon is much more narrow than e.g. the YouTube Favicon, therefore the spacing looks not correct for you. 

shrike@: Is this WontFix?

Comment 2 by ugurcan....@gmail.com, Sep 1 2016 

Yes, it is narrow. I think the problem is the default-favicon in the BMB is much more narrow than how it drawn in the tab. See the attached screenshot to compare YouTube favicon and the Default-Favicon for tabs. Then compare them with the bookmarks bar ones. Thank you.
Ekran Resmi 2016-09-01 11.47.23.png
24.0 KB View Download

Comment 3 by shrike@chromium.org, Sep 1 2016

Cc: -shrike@chromium.org sgabr...@chromium.org
Owner: shrike@chromium.org
Status: Assigned (was: Unconfirmed)
The tab icon is 10x14, for a ratio of 0.71. The bookmark version is 8x12, for a ratio of 0.67. So the bookmark version is proportionally narrower than in the tabs but unfortunately I don't think it can be widened. Increasing to 10x12 gives a ratio of 0.83, which is much fatter than the tabs. 9x12 is 0.75, so it would look a little fatter but with its odd width will be off-center.

I've attached a mock-up of the 10x8 icon. I think it feels too wide. sgabriel@, what do you think?

Comment 4 by shrike@chromium.org, Sep 1 2016 

Sorry - I widened the tab icon in c#3.

Here are the 9x12 and 10x12 mock-ups in the bookmarks bar.
9x12BookmarkImage.png
36.6 KB View Download
10x12BookmarkImage.png
37.0 KB View Download

Comment 5 by sgabr...@chromium.org, Sep 5 2016 

10x12 definitely too wide. 9x12 is fine.

Comment 6 by shrike@chromium.org, Nov 16 2016

Labels: Proj-NativeMacMD

Comment 7 by shrike@chromium.org, Jan 23 2018

Owner: ----
Status: Untriaged (was: Assigned)
Back to triage (not sure if it's still an issue).

Comment 8 by meh...@chromium.org, Jan 23 2018

Status: WontFix (was: Untriaged)
I would say it is looking fine as it is. Closing.
►

Sign in to add a comment