Issue metadata
Sign in to add a comment
|
Unable to open RAW file( .CR2 , .ARW) |
||||||||||||||||||||||
Issue descriptionGoogle Chrome 54.0.2840.7 (Official Build) dev (64-bit) Platform 8743.5.0 (Official Build) dev-channel samus Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: Try to open attached file from the File.app Expected Result: Should open RAW files. Its not reproduced M53(8530.76.0/53.0.2785.87) Actual Result: Error " The file couldn't be displayed" How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) 100% What is the impact to the user, and is there a workaround? If so, what is it? Please provide any additional information below. Attach a screen shot or log if possible.
,
Aug 31 2016
,
Aug 31 2016
,
Sep 1 2016
Reproduced the issue. It looks like a blocker.
,
Sep 1 2016
image_loader extension says: PiexLoaderError: NaCL module load failed: PnaclCoordinator: pexe load failed (pp_error=-2)
,
Sep 1 2016
Given that it worked in M53, it seems this is a recent regression. I'll bisect it.
,
Sep 1 2016
After bisection, https://codereview.chromium.org/2138583002 turned out to be the first bad revision. Lei, I'm not sure about what output_all_resource_defines="false" means, but setting output_all_resource_defines="true" in ui/chromeos/resources/ui_chromeos_resources.grd fixes this issue. (NaCL module load failure.) Is output_all_resource_defines="true" a proper fix for this issue?
,
Sep 1 2016
No, we should look into why it won't work with output_all_resource_defines="false". It is likely my CL just exposed another bug. See also bug 634044 . If it is reproducible with a ChromeOS on Linux build and you need help, please let me know and I can take a look.
,
Sep 1 2016
Thanks! It'd be great if you can take a look at this issue. This issue is reproducible with a Chrome OS on Linux with official build. i.e. with gn flag: is_official_build = true is_chrome_branded = true
,
Sep 1 2016
Oops, "ui/chromeos/resources/ui_chromeos_resources.grd" in comment #7 was wrong. It should be "ui/file_manager/file_manager_resources.grd".
,
Sep 1 2016
Sure. Let me kick off a build and see how it goes. I have sample RAW files somewhere.
,
Sep 1 2016
Yes, I can repro and flipping the bit in file_manager_resources.grd does make the problem go away.
,
Sep 1 2016
I see IDR_IMAGE_LOADER_PIEX_LOADER_PNACL is missing, but not sure why yet.
,
Sep 1 2016
,
Sep 1 2016
Actually, grit is doing what it is told. The .grd file is wrong but it worked before because grit was generating all resources anyway. Now we tell grit to drop resources that are in <if> blocks that evaluate to false, and suddenly files go missing. Though there is no compile time failure because IDR_IMAGE_LOADER_PIEX_LOADER_PNACL is never directly referenced from C++. https://codereview.chromium.org/2305583003
,
Sep 2 2016
Assigning back to hirono, who has written https://codereview.chromium.org/2300283002/
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55e10010b0e3c851165f7b8af4465d05d525d729 commit 55e10010b0e3c851165f7b8af4465d05d525d729 Author: hirono <hirono@chromium.org> Date: Fri Sep 02 21:59:32 2016 Refer internal PIEX library by using <include> tag in piex.pexe.txt. We put PIEX internal library in ui/file_manager/internal directory. The problem is we cannot access the resources in the directory by using chrome-extension:// URL because it's not under extension directory. Previously we prepared the dummy file of PIEX file in image_loader extension, and assigns the same resource ID both to the dummy file and internal library. It enabled the image loader extension to access internal library via the URL of dummy file. The CL removes the hack and adds <include> tag to the dummy file. The contents of dummy file is replaced with the internal library by <include> tag at the compile time. BUG= 642924 TEST=load raw file with official chrome Review-Url: https://codereview.chromium.org/2300283002 Cr-Commit-Position: refs/heads/master@{#416358} [modify] https://crrev.com/55e10010b0e3c851165f7b8af4465d05d525d729/ui/file_manager/file_manager_resources.grd [modify] https://crrev.com/55e10010b0e3c851165f7b8af4465d05d525d729/ui/file_manager/image_loader/piex/piex.pexe.txt
,
Sep 5 2016
,
Sep 5 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0d8bece245e83fd7e9af27020f4f86f614cc391 commit d0d8bece245e83fd7e9af27020f4f86f614cc391 Author: Daichi Hirono <hirono@chromium.org> Date: Mon Sep 05 03:27:44 2016 Refer internal PIEX library by using <include> tag in piex.pexe.txt. We put PIEX internal library in ui/file_manager/internal directory. The problem is we cannot access the resources in the directory by using chrome-extension:// URL because it's not under extension directory. Previously we prepared the dummy file of PIEX file in image_loader extension, and assigns the same resource ID both to the dummy file and internal library. It enabled the image loader extension to access internal library via the URL of dummy file. The CL removes the hack and adds <include> tag to the dummy file. The contents of dummy file is replaced with the internal library by <include> tag at the compile time. BUG= 642924 TEST=load raw file with official chrome Review-Url: https://codereview.chromium.org/2300283002 Cr-Commit-Position: refs/heads/master@{#416358} (cherry picked from commit 55e10010b0e3c851165f7b8af4465d05d525d729) Review URL: https://codereview.chromium.org/2308323002 . Cr-Commit-Position: refs/branch-heads/2840@{#148} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/d0d8bece245e83fd7e9af27020f4f86f614cc391/ui/file_manager/file_manager_resources.grd [modify] https://crrev.com/d0d8bece245e83fd7e9af27020f4f86f614cc391/ui/file_manager/image_loader/piex/piex.pexe.txt
,
Sep 21 2016
Chrome OS 54.2840.33/8743.35.0
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0d8bece245e83fd7e9af27020f4f86f614cc391 commit d0d8bece245e83fd7e9af27020f4f86f614cc391 Author: Daichi Hirono <hirono@chromium.org> Date: Mon Sep 05 03:27:44 2016 Refer internal PIEX library by using <include> tag in piex.pexe.txt. We put PIEX internal library in ui/file_manager/internal directory. The problem is we cannot access the resources in the directory by using chrome-extension:// URL because it's not under extension directory. Previously we prepared the dummy file of PIEX file in image_loader extension, and assigns the same resource ID both to the dummy file and internal library. It enabled the image loader extension to access internal library via the URL of dummy file. The CL removes the hack and adds <include> tag to the dummy file. The contents of dummy file is replaced with the internal library by <include> tag at the compile time. BUG= 642924 TEST=load raw file with official chrome Review-Url: https://codereview.chromium.org/2300283002 Cr-Commit-Position: refs/heads/master@{#416358} (cherry picked from commit 55e10010b0e3c851165f7b8af4465d05d525d729) Review URL: https://codereview.chromium.org/2308323002 . Cr-Commit-Position: refs/branch-heads/2840@{#148} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/d0d8bece245e83fd7e9af27020f4f86f614cc391/ui/file_manager/file_manager_resources.grd [modify] https://crrev.com/d0d8bece245e83fd7e9af27020f4f86f614cc391/ui/file_manager/image_loader/piex/piex.pexe.txt |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by abod...@chromium.org
, Aug 31 2016