[Offline Pages] Capture UMA on number of attempts for completed requests and on network connection when prerenderer fails with Unsupported Scheme |
||||
Issue descriptionAs a follow-up to bug 642025 and the patch landed to mitigate it, we want some UMA on both how many attempts we are seeing (for better tuning) and how often the network is known to be disconnected when we get Unsupported Scheme failure from the prerenderer.
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22647f96af79fb0d563644640689a8fc678f15ac commit 22647f96af79fb0d563644640689a8fc678f15ac Author: dougarnett <dougarnett@chromium.org> Date: Thu Sep 01 22:55:11 2016 [Offline Pages] Adds UMA for number of started attempts and for network connection when Unsupported Scheme error encountered. These changes are a follow-up to bug 642025 and the patch landed to mitigate it. They are meant to give us more visibility for tuning the policy for max number of started attempts for a request and whether we might use the network connection to better understand the nature of the Unsupported Scheme error. Also this reduces the max number of start attempts from 5 to 4. I tried 2 EM URLs that took 3 attempts on GIN-2g on GIN-2g-poor and one took only 2 attempts while the other took 4 attempts so I don't want to lower this too much yet (and see what new UMA reveals). BUG= 642923 Review-Url: https://codereview.chromium.org/2301703002 Cr-Commit-Position: refs/heads/master@{#416101} [modify] https://crrev.com/22647f96af79fb0d563644640689a8fc678f15ac/chrome/browser/android/offline_pages/prerendering_loader.cc [modify] https://crrev.com/22647f96af79fb0d563644640689a8fc678f15ac/components/offline_pages/background/offliner_policy.h [modify] https://crrev.com/22647f96af79fb0d563644640689a8fc678f15ac/components/offline_pages/background/request_coordinator.cc [modify] https://crrev.com/22647f96af79fb0d563644640689a8fc678f15ac/components/offline_pages/background/request_coordinator.h [modify] https://crrev.com/22647f96af79fb0d563644640689a8fc678f15ac/components/offline_pages/background/request_notifier.h [modify] https://crrev.com/22647f96af79fb0d563644640689a8fc678f15ac/tools/metrics/histograms/histograms.xml
,
Sep 2 2016
,
Sep 2 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 5 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d69874fb6de3c8c2e688cd264c416bb2c0fc906 commit 8d69874fb6de3c8c2e688cd264c416bb2c0fc906 Author: Pete Williamson <petewil@chromium.org> Date: Tue Sep 06 20:57:40 2016 [Offline Pages] Adds UMA for number of started attempts and for network connection when Unsupported Scheme error encountered. These changes are a follow-up to bug 642025 and the patch landed to mitigate it. They are meant to give us more visibility for tuning the policy for max number of started attempts for a request and whether we might use the network connection to better understand the nature of the Unsupported Scheme error. Also this reduces the max number of start attempts from 5 to 4. I tried 2 EM URLs that took 3 attempts on GIN-2g on GIN-2g-poor and one took only 2 attempts while the other took 4 attempts so I don't want to lower this too much yet (and see what new UMA reveals). BUG= 642923 Review-Url: https://codereview.chromium.org/2301703002 Cr-Commit-Position: refs/heads/master@{#416101} (cherry picked from commit 22647f96af79fb0d563644640689a8fc678f15ac) Review URL: https://codereview.chromium.org/2314263002 . Cr-Commit-Position: refs/branch-heads/2840@{#183} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/8d69874fb6de3c8c2e688cd264c416bb2c0fc906/chrome/browser/android/offline_pages/prerendering_loader.cc [modify] https://crrev.com/8d69874fb6de3c8c2e688cd264c416bb2c0fc906/components/offline_pages/background/offliner_policy.h [modify] https://crrev.com/8d69874fb6de3c8c2e688cd264c416bb2c0fc906/components/offline_pages/background/request_coordinator.cc [modify] https://crrev.com/8d69874fb6de3c8c2e688cd264c416bb2c0fc906/components/offline_pages/background/request_coordinator.h [modify] https://crrev.com/8d69874fb6de3c8c2e688cd264c416bb2c0fc906/components/offline_pages/background/request_notifier.h [modify] https://crrev.com/8d69874fb6de3c8c2e688cd264c416bb2c0fc906/tools/metrics/histograms/histograms.xml
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d69874fb6de3c8c2e688cd264c416bb2c0fc906 commit 8d69874fb6de3c8c2e688cd264c416bb2c0fc906 Author: Pete Williamson <petewil@chromium.org> Date: Tue Sep 06 20:57:40 2016 [Offline Pages] Adds UMA for number of started attempts and for network connection when Unsupported Scheme error encountered. These changes are a follow-up to bug 642025 and the patch landed to mitigate it. They are meant to give us more visibility for tuning the policy for max number of started attempts for a request and whether we might use the network connection to better understand the nature of the Unsupported Scheme error. Also this reduces the max number of start attempts from 5 to 4. I tried 2 EM URLs that took 3 attempts on GIN-2g on GIN-2g-poor and one took only 2 attempts while the other took 4 attempts so I don't want to lower this too much yet (and see what new UMA reveals). BUG= 642923 Review-Url: https://codereview.chromium.org/2301703002 Cr-Commit-Position: refs/heads/master@{#416101} (cherry picked from commit 22647f96af79fb0d563644640689a8fc678f15ac) Review URL: https://codereview.chromium.org/2314263002 . Cr-Commit-Position: refs/branch-heads/2840@{#183} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/8d69874fb6de3c8c2e688cd264c416bb2c0fc906/chrome/browser/android/offline_pages/prerendering_loader.cc [modify] https://crrev.com/8d69874fb6de3c8c2e688cd264c416bb2c0fc906/components/offline_pages/background/offliner_policy.h [modify] https://crrev.com/8d69874fb6de3c8c2e688cd264c416bb2c0fc906/components/offline_pages/background/request_coordinator.cc [modify] https://crrev.com/8d69874fb6de3c8c2e688cd264c416bb2c0fc906/components/offline_pages/background/request_coordinator.h [modify] https://crrev.com/8d69874fb6de3c8c2e688cd264c416bb2c0fc906/components/offline_pages/background/request_notifier.h [modify] https://crrev.com/8d69874fb6de3c8c2e688cd264c416bb2c0fc906/tools/metrics/histograms/histograms.xml |
||||
►
Sign in to add a comment |
||||
Comment 1 by dougarnett@chromium.org
, Aug 31 2016