In Harmony, MdTextButton will replace STYLE_BUTTON buttons. For now there are factory functions that allow you to create the appropriate button type based on the command line flags you pass.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2bc680cc11f5b0bc1763c2b783ddd8744d4ad87 commit e2bc680cc11f5b0bc1763c2b783ddd8744d4ad87 Author: estade <estade@chromium.org> Date: Thu Sep 01 20:45:56 2016 Remove some more LabelButton::STYLE_BUTTON references. BUG=642920 TBR=mkwst@chromium.org Review-Url: https://codereview.chromium.org/2296173004 Cr-Commit-Position: refs/heads/master@{#416041} [modify] https://crrev.com/e2bc680cc11f5b0bc1763c2b783ddd8744d4ad87/ash/shell/lock_view.cc [modify] https://crrev.com/e2bc680cc11f5b0bc1763c2b783ddd8744d4ad87/ash/shell/widgets.cc [modify] https://crrev.com/e2bc680cc11f5b0bc1763c2b783ddd8744d4ad87/content/shell/browser/shell_views.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05cb506faa6d5da3990acc94b915bdb8a7768478 commit 05cb506faa6d5da3990acc94b915bdb8a7768478 Author: estade <estade@chromium.org> Date: Thu Sep 01 23:04:50 2016 Change buttons in WindowTypeLauncher to MdTextButton This isn't guarded by any flag because it's non-production code. You can see the WindowTypeLauncher by building and running ash_shell_with_content. BUG=642920 Review-Url: https://codereview.chromium.org/2299583003 Cr-Commit-Position: refs/heads/master@{#416107} [modify] https://crrev.com/05cb506faa6d5da3990acc94b915bdb8a7768478/ash/shell/window_type_launcher.cc [modify] https://crrev.com/05cb506faa6d5da3990acc94b915bdb8a7768478/ash/shell/window_type_launcher.h [modify] https://crrev.com/05cb506faa6d5da3990acc94b915bdb8a7768478/mash/example/window_type_launcher/window_type_launcher.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9de559d6273578ee0faf616cb62ca101ff00c57b commit 9de559d6273578ee0faf616cb62ca101ff00c57b Author: estade <estade@chromium.org> Date: Fri Sep 02 00:52:39 2016 Prepare some BlueButtons in chrome browser ui for switch to Harmony. Relevant to the linked bug as BlueButtons are STYLE_BUTTON LabelButtons. BUG=642920 Review-Url: https://codereview.chromium.org/2299993005 Cr-Commit-Position: refs/heads/master@{#416147} [modify] https://crrev.com/9de559d6273578ee0faf616cb62ca101ff00c57b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc [modify] https://crrev.com/9de559d6273578ee0faf616cb62ca101ff00c57b/chrome/browser/ui/views/profiles/profile_chooser_view.cc [modify] https://crrev.com/9de559d6273578ee0faf616cb62ca101ff00c57b/chrome/browser/ui/views/sad_tab_view.cc [modify] https://crrev.com/9de559d6273578ee0faf616cb62ca101ff00c57b/chrome/browser/ui/views/screen_capture_notification_ui_views.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d4a2889b976a49a743d7ba32797883190af303b commit 2d4a2889b976a49a743d7ba32797883190af303b Author: estade <estade@chromium.org> Date: Tue Sep 06 23:03:50 2016 Make notifier settings combobox a real combobox. It looks and acts like a combobox but was actually a menu button. I needed to change this to remove another reference to STYLE_BUTTON, and generally to improve consistency of appearance and behavior. I also got sucked into rearranging padding/margins. BUG=642920 Review-Url: https://codereview.chromium.org/2300893002 Cr-Commit-Position: refs/heads/master@{#416749} [modify] https://crrev.com/2d4a2889b976a49a743d7ba32797883190af303b/ui/base/models/combobox_model.h [modify] https://crrev.com/2d4a2889b976a49a743d7ba32797883190af303b/ui/message_center/views/notifier_settings_view.cc [modify] https://crrev.com/2d4a2889b976a49a743d7ba32797883190af303b/ui/message_center/views/notifier_settings_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/057f0a2628a0bea9016ef0a84a5af1a17e53e8db commit 057f0a2628a0bea9016ef0a84a5af1a17e53e8db Author: estade <estade@chromium.org> Date: Wed Sep 07 03:47:37 2016 Update some example + test code to use MdTextButton instead of STYLE_BUTTON label buttons. BUG=642920 Review-Url: https://codereview.chromium.org/2310213002 Cr-Commit-Position: refs/heads/master@{#416836} [modify] https://crrev.com/057f0a2628a0bea9016ef0a84a5af1a17e53e8db/ui/views/examples/vector_example.cc [modify] https://crrev.com/057f0a2628a0bea9016ef0a84a5af1a17e53e8db/ui/views/focus/focus_manager_unittest.cc [modify] https://crrev.com/057f0a2628a0bea9016ef0a84a5af1a17e53e8db/ui/views/focus/focus_traversal_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a575a3f269a58521f5c5241f31b4acd5dfacfd8b commit a575a3f269a58521f5c5241f31b4acd5dfacfd8b Author: estade <estade@chromium.org> Date: Fri Sep 23 17:37:12 2016 Update a few STYLE_BUTTON buttons in mash. BUG=642920 Review-Url: https://codereview.chromium.org/2357363002 Cr-Commit-Position: refs/heads/master@{#420648} [modify] https://crrev.com/a575a3f269a58521f5c5241f31b4acd5dfacfd8b/mash/example/window_type_launcher/window_type_launcher.cc [modify] https://crrev.com/a575a3f269a58521f5c5241f31b4acd5dfacfd8b/mash/login/login.cc [modify] https://crrev.com/a575a3f269a58521f5c5241f31b4acd5dfacfd8b/mash/screenlock/screenlock.cc [modify] https://crrev.com/a575a3f269a58521f5c5241f31b4acd5dfacfd8b/mash/task_viewer/task_viewer.cc
Is there any manual repro steps available to verify this issue on Dev #55.0.2873.0 from Chrome-TE end ?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3766983525e4061113eadae678d3f18e6010fe81 commit 3766983525e4061113eadae678d3f18e6010fe81 Author: estade <estade@chromium.org> Date: Thu May 04 16:54:54 2017 Remove a new usage of LabelButton::SetStyle (in ChromeCleanerDialog). This still can't be removed until secondary MD is on by default (and it can't be protected for now either since Translate is still using it). Rename to SetStyleDeprecated to discourage further use. BUG=642920 Review-Url: https://codereview.chromium.org/2855093002 Cr-Commit-Position: refs/heads/master@{#469362} [modify] https://crrev.com/3766983525e4061113eadae678d3f18e6010fe81/chrome/browser/ui/views/chrome_cleaner_dialog.cc [modify] https://crrev.com/3766983525e4061113eadae678d3f18e6010fe81/chrome/browser/ui/views/chrome_cleaner_dialog.h [modify] https://crrev.com/3766983525e4061113eadae678d3f18e6010fe81/chrome/browser/ui/views/translate/translate_bubble_view.cc [modify] https://crrev.com/3766983525e4061113eadae678d3f18e6010fe81/ui/views/controls/button/blue_button.cc [modify] https://crrev.com/3766983525e4061113eadae678d3f18e6010fe81/ui/views/controls/button/blue_button_unittest.cc [modify] https://crrev.com/3766983525e4061113eadae678d3f18e6010fe81/ui/views/controls/button/label_button.cc [modify] https://crrev.com/3766983525e4061113eadae678d3f18e6010fe81/ui/views/controls/button/label_button.h [modify] https://crrev.com/3766983525e4061113eadae678d3f18e6010fe81/ui/views/controls/button/label_button_unittest.cc [modify] https://crrev.com/3766983525e4061113eadae678d3f18e6010fe81/ui/views/controls/button/md_text_button.cc [modify] https://crrev.com/3766983525e4061113eadae678d3f18e6010fe81/ui/views/examples/button_example.cc [modify] https://crrev.com/3766983525e4061113eadae678d3f18e6010fe81/ui/views/examples/widget_example.cc
Comment 1 by bugdroid1@chromium.org
, Sep 1 2016