New issue
Advanced search Search tips

Issue 642912 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[tracking] move wasm-related tests out of LayoutTests/WontFix

Project Member Reported by mtrofin@chromium.org, Aug 31 2016

Issue description

Currently, wasm-related features are behind the --enable-wasm flag. Layout
tests involving wasm are listed as WontFix, and exercised as a virtual 
test.

Once wasm ships, we can move these tests out of virtual and WontFix.
 
Components: Blink>JavaScript>WebAssembly
Owner: adamk@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3

commit 2247aec8d4c5ef9d93009d9e30a135c5d4e587a3
Author: Adam Klein <adamk@chromium.org>
Date: Fri Sep 21 22:53:41 2018

Remove WebAssemblyStreaming runtime flag

This flag has been enabled by default for quite some time now.

Bug:  642912 ,  875009 , v8:8015
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2d1638c4b93eeff8e864eb7dbdc360b34e02e526
Reviewed-on: https://chromium-review.googlesource.com/1239335
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593362}
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/chrome/browser/about_flags.cc
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/content/child/runtime_features.cc
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/content/public/common/content_features.cc
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/content/public/common/content_features.h
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/337471139a22264cf842b0555117ca70627b9660/third_party/WebKit/LayoutTests/virtual/enable_wasm_streaming/README.txt
[delete] https://crrev.com/337471139a22264cf842b0555117ca70627b9660/third_party/WebKit/LayoutTests/virtual/enable_wasm_streaming/http/tests/wasm_streaming/README.txt
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/blink/renderer/bindings/core/v8/v8_wasm_response_extensions.cc
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/blink/renderer/platform/runtime_enabled_features.json5

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a77ea689e0f1f3eeb2d57e584e51bc5b7d3fce63

commit a77ea689e0f1f3eeb2d57e584e51bc5b7d3fce63
Author: Adam Klein <adamk@chromium.org>
Date: Wed Oct 03 20:54:01 2018

Remove enable_wasm virtual test suite

WebAssembly has been enabled by default for a long while now.

Bug:  642912 , v8:8015
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I50fdf1a15f5183e91fdafa5cf921aa33493a9a7c
Reviewed-on: https://chromium-review.googlesource.com/c/1239212
Commit-Queue: Adam Klein <adamk@chromium.org>
Reviewed-by: Ben Smith <binji@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596352}
[modify] https://crrev.com/a77ea689e0f1f3eeb2d57e584e51bc5b7d3fce63/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/a77ea689e0f1f3eeb2d57e584e51bc5b7d3fce63/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/a77ea689e0f1f3eeb2d57e584e51bc5b7d3fce63/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/a77ea689e0f1f3eeb2d57e584e51bc5b7d3fce63/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/a77ea689e0f1f3eeb2d57e584e51bc5b7d3fce63/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a77ea689e0f1f3eeb2d57e584e51bc5b7d3fce63/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/third_party/WebKit/LayoutTests/virtual/enable_wasm/README.txt
[delete] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/third_party/WebKit/LayoutTests/virtual/enable_wasm/external/wpt/wasm/README.txt
[delete] https://crrev.com/c6fe63e6dc839ce96dc6ad417eaf382985d3e8b2/third_party/WebKit/LayoutTests/virtual/enable_wasm/http/tests/wasm/README.txt

Status: Fixed (was: Started)

Sign in to add a comment