Remove "Nope" button from update passwords UI on iOS |
||||||
Issue descriptionRemove "Nope" button from update passwords UI on iOS
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b988c041a2b9886b42cdd36cb0d904d84478da21 commit b988c041a2b9886b42cdd36cb0d904d84478da21 Author: jyquinn <jyquinn@chromium.org> Date: Thu Sep 01 23:19:46 2016 [Password Manager] Remove "Nope" button from update passwords UI on iOS Removes "Nope" button from the update passwords infobar on iOS, as specified by the updated design: https://folio.googleplex.com/chrome-ux/mocks/321-password-manager/password%20update/mobile BUG= 642910 Review-Url: https://codereview.chromium.org/2295133003 Cr-Commit-Position: refs/heads/master@{#416114} [modify] https://crrev.com/b988c041a2b9886b42cdd36cb0d904d84478da21/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/b988c041a2b9886b42cdd36cb0d904d84478da21/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.h [modify] https://crrev.com/b988c041a2b9886b42cdd36cb0d904d84478da21/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm
,
Sep 6 2016
,
Sep 6 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5389894fd03abe5a25d7dd3cec6a06a8df9999c commit d5389894fd03abe5a25d7dd3cec6a06a8df9999c Author: Jackie Quinn <jyquinn@chromium.org> Date: Tue Sep 06 19:26:04 2016 [Password Manager] Remove "Nope" button from update passwords UI on iOS Removes "Nope" button from the update passwords infobar on iOS, as specified by the updated design: https://folio.googleplex.com/chrome-ux/mocks/321-password-manager/password%20update/mobile BUG= 642910 Review-Url: https://codereview.chromium.org/2295133003 Cr-Commit-Position: refs/heads/master@{#416114} (cherry picked from commit b988c041a2b9886b42cdd36cb0d904d84478da21) Review URL: https://codereview.chromium.org/2317793002 . Cr-Commit-Position: refs/branch-heads/2840@{#181} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/d5389894fd03abe5a25d7dd3cec6a06a8df9999c/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/d5389894fd03abe5a25d7dd3cec6a06a8df9999c/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.h [modify] https://crrev.com/d5389894fd03abe5a25d7dd3cec6a06a8df9999c/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm
,
Sep 14 2016
"Nope" button is no more seen in the Update Password infobar. Jackie, can you please change the status to "Fixed" so that I can go ahead and close the bug.
,
Sep 14 2016
Thanks!
,
Sep 15 2016
"Nope" button is not displayed in the Update Password infobar Verified on iPad Mini(iOS 9.3.5), iPhone SE(10.0.1) in 54.0.2840.28 dev
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5389894fd03abe5a25d7dd3cec6a06a8df9999c commit d5389894fd03abe5a25d7dd3cec6a06a8df9999c Author: Jackie Quinn <jyquinn@chromium.org> Date: Tue Sep 06 19:26:04 2016 [Password Manager] Remove "Nope" button from update passwords UI on iOS Removes "Nope" button from the update passwords infobar on iOS, as specified by the updated design: https://folio.googleplex.com/chrome-ux/mocks/321-password-manager/password%20update/mobile BUG= 642910 Review-Url: https://codereview.chromium.org/2295133003 Cr-Commit-Position: refs/heads/master@{#416114} (cherry picked from commit b988c041a2b9886b42cdd36cb0d904d84478da21) Review URL: https://codereview.chromium.org/2317793002 . Cr-Commit-Position: refs/branch-heads/2840@{#181} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/d5389894fd03abe5a25d7dd3cec6a06a8df9999c/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/d5389894fd03abe5a25d7dd3cec6a06a8df9999c/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.h [modify] https://crrev.com/d5389894fd03abe5a25d7dd3cec6a06a8df9999c/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jyqu...@chromium.org
, Aug 31 2016